Skip to contentSkip to conversation

mx28evk: add trimffs to nand command

PATCH New Eric Bénard 5 participants 6 messages Apr 8, 2013 – Apr 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx28evk: add trimffs to nand command

this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)

---
 include/configs/mx28evk.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/mx28evk.h +1 -0
index d470b47..b22a20b 100644
@@ -63,6 +63,7 @@
 #define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
 #define CONFIG_CMD_NAND
+#define CONFIG_CMD_NAND_TRIMFFS
 
 /* Memory configurations */
 #define CONFIG_NR_DRAM_BANKS		1		/* 1 bank of DRAM */
Signature · 1 line
1.7.11.7
#2 lore raw

PATCH 1/1 mx28evk: add trimffs to nand command

In reply to Eric Bénard
Quoted 13 lines · Eric B?nard

this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)

---
 include/configs/mx28evk.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/mx28evk.h +0 -0
index d470b47..b22a20b 100644

include/configs/mx28evk.h line 66

Quoted 4 lines
include/configs/mx28evk.h +1 -0
@@ -63,6 +63,7 @@
 #define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
 #define CONFIG_CMD_NAND
+#define CONFIG_CMD_NAND_TRIMFFS

You should add this into mx28evk_nand.h, available in u-boot.imx tree.

#3 lore raw

PATCH 1/1 mx28evk: add trimffs to nand command

Hi Fabio,

Le Tue, 9 Apr 2013 15:02:44 -0300,
Fabio Estevam <[email protected]> a ?crit :

Quoted 9 lines
Quoted 8 lines · Eric B?nard

this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)

---
 include/configs/mx28evk.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

include/configs/mx28evk.h line 66

Quoted 9 lines
include/configs/mx28evk.h +1 -0
index d470b47..b22a20b 100644
@@ -63,6 +63,7 @@
 #define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
 #define CONFIG_CMD_NAND
+#define CONFIG_CMD_NAND_TRIMFFS

You should add this into mx28evk_nand.h, available in u-boot.imx tree.

that's the second time you ask this but mx28evk_nand.h doesn't exist, even in u-boot-imx tree, and you are the developer who added nand support to mx28evk in commit ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)

Here is a reminder of what you did in that commit : you added the mx28evk_nand option in boards.cfg which defines ENV_IS_IN_NAND when mx28evk defines ENV_IS_IN_MMC and both are using the same config which is include/configs/mx28evk.h :
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=ab461be65dbfe3e2fa45f7cd836faa99663be5bb

So this patch is fine against u-boot-imx.

Best regards
Eric

#4 lore raw

PATCH 1/1 mx28evk: add trimffs to nand command

Hi Eric,

Quoted 5 lines · Eric B?nard

that's the second time you ask this but mx28evk_nand.h doesn't exist, even in u-boot-imx tree, and you are the developer who added nand support to mx28evk in commit ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)

Right, mx28_evk.h only existed in my first version of the patch, and then the patch I submitted handles both ENV_IS_NAND and ENV_IS_MMC with the same config file.

Sorry for the confusion :-)

#5 lore raw

PATCH 1/1 mx28evk: add trimffs to nand command

In reply to Eric Bénard
Quoted 5 lines · Eric B?nard

this is usefull when writing an UBI image which contains and UBIFS volume (check README.nand and UBI FAQ for more details)

---

Applied to u-boot-imx, -next branch, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================