Skip to contentSkip to conversation

Btrfs-progs: don't set INCOMPAT_EXTENDED_IREF flag when making a new fs

PATCH In review Miao Xie 2 participants 3 messages Apr 11, 2013 – Apr 12, 2013 Btrfs file system

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

PATCH 1/1 Btrfs-progs: don't set INCOMPAT_EXTENDED_IREF flag when making a new fs

There is no extended irefs in the new fs, and we can mount it on the old kernel without extended iref function safely. So we needn't set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set it when we actually insert a extended iref.

---
 mkfs.c | 2 --
 1 file changed, 2 deletions(-)
mkfs.c +0 -2
index c8cb395..aca6e46 100644
@@ -1654,8 +1654,6 @@ raid_groups:
 
 	super = root->fs_info->super_copy;
 	flags = btrfs_super_incompat_flags(super);
-	flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF;
-
 	if (mixed)
 		flags |= BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS;
 
Signature · 1 line
1.8.0.1
#1 lore raw
Quoted 17 lines · Miao Xie

There is no extended irefs in the new fs, and we can mount it on the old kernel without extended iref function safely. So we needn't set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set it when we actually insert a extended iref.

---
 mkfs.c | 2 --
 1 file changed, 2 deletions(-)
mkfs.c +0 -0
index c8cb395..aca6e46 100644

mkfs.c raid_groups: · line 1659

Quoted 8 lines
mkfs.c +0 -2
@@ -1654,8 +1654,6 @@ raid_groups:
 
 	super = root->fs_info->super_copy;
 	flags = btrfs_super_incompat_flags(super);
-	flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF;
-
 	if (mixed)
 		flags |= BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS;
 

This one should have a large

*** do not apply until kernel patches from "[PATCH 0/2] do not open the extend *** inode reference at the beginning" have been merged.

tag. Otherwise, extended irefs are disabled entirely for all new file systems in environments where they have been working so far.

-Jan

author
#2 lore raw
Quoted 29 lines · Jan Schmidt
Quoted 17 lines · Miao Xie

There is no extended irefs in the new fs, and we can mount it on the old kernel without extended iref function safely. So we needn't set INCOMPAT_EXTENDED_IREF flag when making a new fs, and just set it when we actually insert a extended iref.

---
 mkfs.c | 2 --
 1 file changed, 2 deletions(-)
mkfs.c +0 -0
index c8cb395..aca6e46 100644

mkfs.c raid_groups: · line 1659

Quoted 8 lines
mkfs.c +0 -2
@@ -1654,8 +1654,6 @@ raid_groups:
 
 	super = root->fs_info->super_copy;
 	flags = btrfs_super_incompat_flags(super);
-	flags |= BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF;
-
 	if (mixed)
 		flags |= BTRFS_FEATURE_INCOMPAT_MIXED_GROUPS;
 

This one should have a large

Quoted 5 lines

*** do not apply until kernel patches from "[PATCH 0/2] do not open the extend *** inode reference at the beginning" have been merged.

tag. Otherwise, extended irefs are disabled entirely for all new file systems in environments where they have been working so far.

Yes, thanks to point it out.

Miao