SCSI: really use SATL version in VPD

PATCH Applied Baruch Even 2 participants 2 messages Apr 5, 2013 – Apr 11, 2013 1 message not in the archive libata

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): satl-driver-version-v3

Baruch Even

author

2013-04-05 16:12 UTC #1 lore raw

PATCH v3 1/1 SCSI: really use SATL version in VPD

As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) We need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version.

Signed-off-by Baruch Even <[email protected]>

---
 drivers/ata/libata-scsi.c |    1 -
 1 file changed, 1 deletion(-)

drivers/ata/libata-scsi.c +0 -1

index 318b413..e61a054 100644
@@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)
 	memcpy(&rbuf[8], "linux   ", 8);
 	memcpy(&rbuf[16], "libata          ", 16);
 	memcpy(&rbuf[32], DRV_VERSION, 4);
-	ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4);
 
 	/* we don't store the ATA device signature, so we fake it */

Signature · 1 line

1.7.10.4

Jeff Garzik

Applied

2013-04-11 23:45 UTC #2 lore raw

Quoted 9 lines · Baruch Even

As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) We need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version.
Signed-off-by Baruch Even <[email protected]>
---
  drivers/ata/libata-scsi.c |    1 -
  1 file changed, 1 deletion(-)

applied