Skip to contentSkip to conversation

mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register

PATCH New Philip Paeps 2 participants 4 messages Apr 9, 2013 – Apr 16, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register

This makes mxc_iomux_set_input() work as expected.

---
 arch/arm/cpu/arm1136/mx35/iomux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/cpu/arm1136/mx35/iomux.c +1 -1
index a302575..d6f4ced 100644
@@ -35,7 +35,7 @@ enum iomux_reg_addr {
 	IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324,	/* last MUX control */
 	IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328,	/* Pad control */
 	IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794,	/* last Pad control */
-	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC,	/* input select */
+	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8,	/* input select */
 	IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4,	/* last input select */
 };
 
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH v2 1/1 mx35 iomux: correct offsets of IOMUX registers

This makes mxc_iomux_set_input() work correctly. Previously, the incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() to write to the wrong register, possibly resulting in unexpected behaviour.

---
Changes in v2:
- While here, also correct the offset of the last pad control register. This is mostly cosmetic.

 arch/arm/cpu/arm1136/mx35/iomux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm1136/mx35/iomux.c +2 -2
index a302575..698909e 100644
@@ -34,8 +34,8 @@ enum iomux_reg_addr {
 	IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4,		/* MUX control */
 	IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324,	/* last MUX control */
 	IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328,	/* Pad control */
-	IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794,	/* last Pad control */
-	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC,	/* input select */
+	IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4,	/* last Pad control */
+	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8,	/* input select */
 	IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4,	/* last input select */
 };
 
Signature · 1 line
1.7.2.5
#2 lore raw

PATCH v2 1/1 mx35 iomux: correct offsets of IOMUX registers

Quoted 7 lines · Philip Paeps

This makes mxc_iomux_set_input() work correctly. Previously, the incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() to write to the wrong register, possibly resulting in unexpected behaviour.

---

Hi Philip,

Quoted 12 lines

Changes in v2:
- While here, also correct the offset of the last pad control register. This is mostly cosmetic.

 arch/arm/cpu/arm1136/mx35/iomux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm1136/mx35/iomux.c +0 -0
index a302575..698909e 100644

arch/arm/cpu/arm1136/mx35/iomux.c enum iomux_reg_addr { · line 40

Quoted 9 lines
arch/arm/cpu/arm1136/mx35/iomux.c +2 -2
@@ -34,8 +34,8 @@ enum iomux_reg_addr {
 	IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4,		/* MUX control */
 	IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324,	/* last MUX control */
 	IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328,	/* Pad control */
-	IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794,	/* last Pad control */
-	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC,	/* input select */
+	IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4,	/* last Pad control */
+	IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8,	/* input select */
 	IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4,	/* last input select */
 };

You're right, offset were wrong.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 1/1 mx35 iomux: correct offsets of IOMUX registers

In reply to Philip Paeps
Quoted 7 lines · Philip Paeps

This makes mxc_iomux_set_input() work correctly. Previously, the incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() to write to the wrong register, possibly resulting in unexpected behaviour.

---

Applied to u-boot-imx, -next branch, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================