Skip to contentSkip to conversation

busybox: don't disable static option

PATCH New Patrick Ziegler 3 participants 3 messages Apr 15, 2013 – Apr 17, 2013

lore
Share & tools
lore

Patrick Ziegler

author
#0 lore raw

PATCH 1/1 busybox: don't disable static option

Don't change the busybox STATIC option if buildroots PREFER_STATIC_LIB option is not set. Not to prefer static linking doesn't imply prefer dynamic linking for all packages.

Signed-off-by Patrick Ziegler <[email protected]>
---
 package/busybox/busybox.mk |    4 ----
 1 file changed, 4 deletions(-)
package/busybox/busybox.mk +0 -4
index 900896f..985203c 100644
@@ -106,10 +106,6 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
 define BUSYBOX_PREFER_STATIC
 	$(call KCONFIG_ENABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
 endef
-else
-define BUSYBOX_PREFER_STATIC
-	$(call KCONFIG_DISABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
-endef
 endif
 
 # Disable usage of inetd if netkit-base package is selected
Signature · 20 lines
1.7.10.4



-- 
Dipl.-Inf. (FH) Patrick Ziegler

University Of Applied Sciences
Kaiserslautern

Amerikastrasse 1
D-66482 Zweibruecken
Germany

Phone:  +49 631 3724 5526
Mail:   patrick.ziegler at fh-kl.de
PGP KeyID 0xB4796B8C

http://www.fh-kl.de
http://www.fh-kl.de/fachbereiche/imst/iuk-knowhow.html
#1 lore raw

PATCH 1/1 busybox: don't disable static option

Quoted 5 lines · Patrick Ziegler

Don't change the busybox STATIC option if buildroots PREFER_STATIC_LIB option is not set. Not to prefer static linking doesn't imply prefer dynamic linking for all packages.

Signed-off-by Patrick Ziegler <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Quoted 20 lines
---
  package/busybox/busybox.mk |    4 ----
  1 file changed, 4 deletions(-)
package/busybox/busybox.mk +0 -4
index 900896f..985203c 100644
@@ -106,10 +106,6 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
  define BUSYBOX_PREFER_STATIC
  	$(call KCONFIG_ENABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
  endef
-else
-define BUSYBOX_PREFER_STATIC
-	$(call KCONFIG_DISABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
-endef
  endif
 
  # Disable usage of inetd if netkit-base package is selected
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 busybox: don't disable static option

In reply to Patrick Ziegler
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Patrick" == Patrick Ziegler <[email protected]> writes:

Patrick> Don't change the busybox STATIC option if buildroots Patrick> PREFER_STATIC_LIB option is not set. Not to prefer static Patrick> linking doesn't imply prefer dynamic linking for all packages.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard