Skip to contentSkip to conversation

ARM: dts: OMAP5: add PWM capability to timer nodes missing it

PATCH New Suman Anna 3 participants 4 messages Apr 17, 2013 – Jun 3, 2013 Device tree bindings

lore
Share & tools
lore

Suman Anna

author
#0 lore raw

PATCH 1/2 ARM: dts: OMAP5: add PWM capability to timer nodes missing it

OMAP5 has 6 timers (GPTimers 5, 6, 8 to 11) that are capable of PWM. The PWM capability property is missing from the node definitions of couple of timers, and this has been fixed.

---
 arch/arm/boot/dts/omap5.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/omap5.dtsi +3 -0
index 790bb2a..0d155f5 100644
@@ -422,6 +422,7 @@
 			interrupts = <0 41 0x4>;
 			ti,hwmods = "timer5";
 			ti,timer-dsp;
+			ti,timer-pwm;
 		};
 
 		timer6: timer@4013a000 {
@@ -458,6 +459,7 @@
 			reg = <0x4803e000 0x80>;
 			interrupts = <0 45 0x4>;
 			ti,hwmods = "timer9";
+			ti,timer-pwm;
 		};
 
 		timer10: timer@48086000 {
@@ -465,6 +467,7 @@
 			reg = <0x48086000 0x80>;
 			interrupts = <0 46 0x4>;
 			ti,hwmods = "timer10";
+			ti,timer-pwm;
 		};
 
 		timer11: timer@48088000 {
Signature · 1 line
1.8.2
#1 lore raw

PATCH 1/2 ARM: dts: OMAP5: add PWM capability to timer nodes missing it

Quoted 30 lines · Suman Anna

OMAP5 has 6 timers (GPTimers 5, 6, 8 to 11) that are capable of PWM. The PWM capability property is missing from the node definitions of couple of timers, and this has been fixed.

---
 arch/arm/boot/dts/omap5.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/omap5.dtsi +2 -0
index 790bb2a..0d155f5 100644
@@ -422,6 +422,7 @@
 			interrupts = <0 41 0x4>;
 			ti,hwmods = "timer5";
 			ti,timer-dsp;
+			ti,timer-pwm;
 		};
 
 		timer6: timer at 4013a000 {
@@ -458,6 +459,7 @@
 			reg = <0x4803e000 0x80>;
 			interrupts = <0 45 0x4>;
 			ti,hwmods = "timer9";
+			ti,timer-pwm;
 		};
 
 		timer10: timer at 48086000 {

arch/arm/boot/dts/omap5.dtsi line 473

Quoted 7 lines
arch/arm/boot/dts/omap5.dtsi +1 -0
@@ -465,6 +467,7 @@
 			reg = <0x48086000 0x80>;
 			interrupts = <0 46 0x4>;
 			ti,hwmods = "timer10";
+			ti,timer-pwm;
 		};
 
 		timer11: timer at 48088000 {

Make sure you copy the linux-arm and device-tree mailing lists.

Thanks!
Jon

#2 lore raw

PATCH 1/2 ARM: dts: OMAP5: add PWM capability to timer nodes missing it

Benoit, Tony,

Quoted 37 lines · Suman Anna
Quoted 36 lines

OMAP5 has 6 timers (GPTimers 5, 6, 8 to 11) that are capable of PWM. The PWM capability property is missing from the node definitions of couple of timers, and this has been fixed.

---
 arch/arm/boot/dts/omap5.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/omap5.dtsi +3 -0
index 790bb2a..0d155f5 100644
@@ -422,6 +422,7 @@
 			interrupts = <0 41 0x4>;
 			ti,hwmods = "timer5";
 			ti,timer-dsp;
+			ti,timer-pwm;
 		};
 
 		timer6: timer at 4013a000 {
@@ -458,6 +459,7 @@
 			reg = <0x4803e000 0x80>;
 			interrupts = <0 45 0x4>;
 			ti,hwmods = "timer9";
+			ti,timer-pwm;
 		};
 
 		timer10: timer at 48086000 {
@@ -465,6 +467,7 @@
 			reg = <0x48086000 0x80>;
 			interrupts = <0 46 0x4>;
 			ti,hwmods = "timer10";
+			ti,timer-pwm;
 		};
 
Quoted 6 lines

arch/arm/boot/dts/omap5.dtsi line 473

Quoted 1 line
arch/arm/boot/dts/omap5.dtsi +0 -0
 		timer11: timer at 48088000 {

Make sure you copy the linux-arm and device-tree mailing lists.

Can you include this patch in your next fixes pull request (if you haven't already done so)? The other patch in the series is a feature change, but this is a fix, and can go into 3.10 itself.

Regards
Suman

#3 lore raw

PATCH 1/2 ARM: dts: OMAP5: add PWM capability to timer nodes missing it

Hi Suman,

Quoted 43 lines · Suman

Benoit, Tony,

Quoted 41 lines · Suman Anna
Quoted 30 lines

OMAP5 has 6 timers (GPTimers 5, 6, 8 to 11) that are capable of PWM. The PWM capability property is missing from the node definitions of couple of timers, and this has been fixed.

---
 arch/arm/boot/dts/omap5.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/omap5.dtsi +2 -0
index 790bb2a..0d155f5 100644
@@ -422,6 +422,7 @@
 			interrupts = <0 41 0x4>;
 			ti,hwmods = "timer5";
 			ti,timer-dsp;
+			ti,timer-pwm;
 		};
 
 		timer6: timer at 4013a000 {
@@ -458,6 +459,7 @@
 			reg = <0x4803e000 0x80>;
 			interrupts = <0 45 0x4>;
 			ti,hwmods = "timer9";
+			ti,timer-pwm;
 		};
 
 		timer10: timer at 48086000 {

arch/arm/boot/dts/omap5.dtsi line 473

Quoted 7 lines
arch/arm/boot/dts/omap5.dtsi +1 -0
@@ -465,6 +467,7 @@
 			reg = <0x48086000 0x80>;
 			interrupts = <0 46 0x4>;
 			ti,hwmods = "timer10";
+			ti,timer-pwm;
 		};
 
 		timer11: timer at 48088000 {

Make sure you copy the linux-arm and device-tree mailing lists.

Quoted 6 lines
Quoted 2 lines

Can you include this patch in your next fixes pull request (if you haven't already done so)? The other patch in the series is a feature change, but this is a fix, and can go into 3.10 itself.

I've just sent a pull request with two fixes to Tony. Since -rc4 is already there, I'll update it with this fix.

Tony,

I will resend a new pull-request rebased on -rc4 that will include this new fix.

Regards,
Benoit