Skip to contentSkip to conversation

ALSA: hda - fix error return code in patch_alc662()

PATCH Wang Shilong 1 participant 2 messages Apr 18, 2013

lore
Share & tools
lore
#0 lore raw

Hello Wei,

+++ b/sound/pci/hda/patch_realtek.c
@@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec)
if ((alc_get_coef0(codec) & (1 << 14)) &&
codec->bus->pci->subsystem_vendor == 0x1025 && spec->cdefine.platform_type == 1) {
- if (alc_codec_rename(codec, "ALC272X") < 0)

I don't think we should fix this problem. And your changelog is wrong!

Thanks,
Wang
+ err = alc_codec_rename(codec, "ALC272X");
+ if (err < 0)
goto error;
}

--

#1 lore raw

Sorry, i miss something..

Thanks,
wang

Quoted 21 lines

Hello Wei,

+++ b/sound/pci/hda/patch_realtek.c

(quoted diff) +0 -1
@@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec)
 	if ((alc_get_coef0(codec) & (1 << 14)) &&
 	    codec->bus->pci->subsystem_vendor == 0x1025 &&
 	    spec->cdefine.platform_type == 1) {
-		if (alc_codec_rename(codec, "ALC272X") < 0)
 

I don't think we should fix this problem. And your changelog is wrong!

Thanks,
Wang

(quoted diff) +2 -1
+		err = alc_codec_rename(codec, "ALC272X");
+		if (err < 0)
 			goto error;
 	}
 
 
--