Skip to contentSkip to conversation

ARM64: kernel: compiling issue: need define readq and writeq for driver module using.

PATCH In review Chen Gang 4 participants 5 messages Apr 19, 2013 – Apr 20, 2013 arm64

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 ARM64: kernel: compiling issue: need define readq and writeq for driver module using.

when compiling with allmodconfig, CONFIG_64BIT=y
the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.

so we need implement these functions.

BTW:
the coding style can not pass ./scripts/checkpatch.pl. it seems better to provide additional patch for beautifying code.

---
 arch/arm64/include/asm/io.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm64/include/asm/io.h +4 -0
index 57f12c9..2e12258 100644
@@ -92,10 +92,12 @@ static inline u64 __raw_readq(const volatile void __iomem *addr)
 #define readb_relaxed(c)	({ u8  __v = __raw_readb(c); __v; })
 #define readw_relaxed(c)	({ u16 __v = le16_to_cpu((__force __le16)__raw_readw(c)); __v; })
 #define readl_relaxed(c)	({ u32 __v = le32_to_cpu((__force __le32)__raw_readl(c)); __v; })
+#define readq_relaxed(c)	({ u64 __v = le64_to_cpu((__force __le64)__raw_readq(c)); __v; })
 
 #define writeb_relaxed(v,c)	((void)__raw_writeb((v),(c)))
 #define writew_relaxed(v,c)	((void)__raw_writew((__force u16)cpu_to_le16(v),(c)))
 #define writel_relaxed(v,c)	((void)__raw_writel((__force u32)cpu_to_le32(v),(c)))
+#define writeq_relaxed(v,c)	((void)__raw_writeq((__force u64)cpu_to_le64(v),(c)))
 
 /*
  * I/O memory access primitives. Reads are ordered relative to any
@@ -105,10 +107,12 @@ static inline u64 __raw_readq(const volatile void __iomem *addr)
 #define readb(c)		({ u8  __v = readb_relaxed(c); __iormb(); __v; })
 #define readw(c)		({ u16 __v = readw_relaxed(c); __iormb(); __v; })
 #define readl(c)		({ u32 __v = readl_relaxed(c); __iormb(); __v; })
+#define readq(c)		({ u64 __v = readq_relaxed(c); __iormb(); __v; })
 
 #define writeb(v,c)		({ __iowmb(); writeb_relaxed((v),(c)); })
 #define writew(v,c)		({ __iowmb(); writew_relaxed((v),(c)); })
 #define writel(v,c)		({ __iowmb(); writel_relaxed((v),(c)); })
+#define writeq(v,c)		({ __iowmb(); writeq_relaxed((v),(c)); })
 
 /*
  *  I/O port access primitives.
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Chen Gang

when compiling with allmodconfig, CONFIG_64BIT=y
the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.

so we need implement these functions.

BTW:
the coding style can not pass ./scripts/checkpatch.pl. it seems better to provide additional patch for beautifying code.

#2 lore raw
Quoted 4 lines · Arnd Bergmann
Quoted 3 lines · Chen Gang
Quoted 3 lines

when compiling with allmodconfig, CONFIG_64BIT=y
the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

so we need implement these functions.

BTW:
the coding style can not pass ./scripts/checkpatch.pl. it seems better to provide additional patch for beautifying code.

thanks.

Signature · 3 lines
Chen Gang

Flying Transformer
maintainer
#3 lore raw
In reply to Chen Gang
Quoted 9 lines · Chen Gang

when compiling with allmodconfig, CONFIG_64BIT=y
the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.

so we need implement these functions.

BTW:
the coding style can not pass ./scripts/checkpatch.pl. it seems better to provide additional patch for beautifying code.

If it complains about long lines, just ignore it. I wouldn't worry too much about checkpatch.pl and coding style warnings ;)

Quoted 1 line

Thanks.

Signature · 1 line
Catalin
author
#4 lore raw
Quoted 5 lines · Catalin Marinas
Quoted 4 lines · Chen Gang
Quoted 4 lines

when compiling with allmodconfig, CONFIG_64BIT=y
the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

so we need implement these functions.

BTW:
the coding style can not pass ./scripts/checkpatch.pl. it seems better to provide additional patch for beautifying code.

If it complains about long lines, just ignore it. I wouldn't worry too much about checkpatch.pl and coding style warnings ;)

ok, I can understand.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation