video: exynos_fb: Add the missing #else clause
Subsystems (2)
PATCH 1/1 video: exynos_fb: Add the missing #else clause
This patch fixes a bug introduced while adding DT support to Exynos FIMD driver:
commit c23f3157d69bbb6c044256870f745f195b12431e Author: Ajay Kumar <[email protected]> Date: Thu Feb 21 23:53:01 2013 +0000 video: exynos_fb: add DT support for FIMD driver
Even though this part of code was missing, things were working fine on Exynos5250 because, samsung_get_base_fimd() used to give the correct base address for Exynos5250 FIMD.
--- drivers/video/exynos_fimd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/exynos_fimd.c +2 -1
@@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid) node, "reg");if (fimd_ctrl ==NULL )debug ("Can't get the FIMD base address\n" ); -#endif +#else fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd (); +#endif offset =exynos_fimd_get_base_offset ();
Signature · 1 line
1.8.0
PATCH 1/1 video: exynos_fb: Add the missing #else clause
ping.
Quoted 42 lines · Ajay Kumar
This patch fixes a bug introduced while adding DT support to Exynos FIMD driver:
commit
c23f3157d69bbb6c044256870f745f195b12431e
Author: Ajay Kumar <[email protected]>
Date: Thu Feb 21 23:53:01 2013 +0000video:
exynos_fb: add DT support for FIMD driverEven though this part of code was missing, things were working fine on Exynos5250 because,
samsung_get_base_fimd()used to give the correct base address for Exynos5250 FIMD.Signed-off-by Ajay Kumar <[email protected]>--- drivers/video/exynos_fimd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/video/exynos_fimd.c +2
-2@@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid) node, "reg");if (fimd_ctrl ==NULL )debug ("Can't get the FIMD base address\n" ); -#endif +#else fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd (); +#endif offset =exynos_fimd_get_base_offset (); --1.8.0
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH 1/1 video: exynos_fb: Add the missing #else clause
It looks good to me.
Thank you,
Donghwa Lee
Quoted 50 lines · Ajay kumar
ping.
On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <[email protected] <mailto:[email protected]>> wrote:
This patch fixes a bug introduced while adding DT support to Exynos FIMD driver: commit c23f3157d69bbb6c044256870f745f195b12431e Author: Ajay Kumar <[email protected] <mailto:[email protected]>> Date: Thu Feb 21 23:53:01 2013 +0000 video: exynos_fb: add DT support for FIMD driver Even though this part of code was missing, things were working fine on Exynos5250 because, samsung_get_base_fimd() used to give the correct base address for Exynos5250 FIMD. Signed-off-by: Ajay Kumar <[email protected] <mailto:[email protected]>> --- drivers/video/exynos_fimd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c index 3359949..7243ea3 100644 --- a/drivers/video/exynos_fimd.c +++ b/drivers/video/exynos_fimd.c @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid) node, "reg"); if (fimd_ctrl == NULL) debug("Can't get the FIMD base address\n"); -#endif +#else fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd(); +#endif offset = exynos_fimd_get_base_offset(); -- 1.8.0 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de <mailto:[email protected]> http://lists.denx.de/mailman/listinfo/u-boot
PATCH 1/1 video: exynos_fb: Add the missing #else clause
Quoted 57 lines · Donghwa Lee
It looks good to me.
Acked-by Donghwa Lee <[email protected]>Thank you,
Donghwa LeeQuoted 47 lines · Ajay kumar
ping.
On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <
ajaykumar.rsat samsung.com <mailto:[email protected]>> wrote:This patch fixes a bug introduced while adding DT support to Exynos FIMD driver: commit c23f3157d69bbb6c044256870f745f195b12431e Author: Ajay Kumar <ajaykumar.rs at samsung.com <mailto:[email protected]>> Date: Thu Feb 21 23:53:01 2013 +0000 video: exynos_fb: add DT support for FIMD driver Even though this part of code was missing, things were working fine on Exynos5250 because, samsung_get_base_fimd() used to give the correct base address for Exynos5250 FIMD. Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com <mailto:[email protected]>> --- drivers/video/exynos_fimd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c index 3359949..7243ea3 100644 --- a/drivers/video/exynos_fimd.c +++ b/drivers/video/exynos_fimd.c @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid) node, "reg"); if (fimd_ctrl == NULL) debug("Can't get the FIMD base address\n"); -#endif +#else fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd(); +#endif offset = exynos_fimd_get_base_offset(); -- 1.8.0 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de <mailto:[email protected]> http://lists.denx.de/mailman/listinfo/u-boot
applied to u-boot-samsung.
thanks,
Minkyu Kang.