fs/buffer.c: Remove unnecessary init operation after, allocating buffer_head.
Subsystems (2)
PATCH 1/1 fs/buffer.c: Remove unnecessary init operation after, allocating buffer_head.
Because alloc 'struct buffer_head' using kmem_cache_zalloc,so it doesn't need to call 'init_buffer(bh, NULL, NULL)' and other set-zero-operation.
Signed-off-by Jianpeng Ma <[email protected]>
--- fs/buffer.c | 2 -- fs/jbd/journal.c | 2 -- fs/jbd2/journal.c | 2 -- 3 files changed, 6 deletions(-)
fs/buffer.c +0 -2
@@ -865,8 +865,6 @@ try_again:/* Link the buffer to its page */ set_bh_page (bh, page, offset); - -init_buffer (bh,NULL ,NULL ); }return head;/*
fs/jbd/journal.c +0 -2
@@ -310,8 +310,6 @@ int journal_write_metadata_buffer(transaction_t *transaction, new_bh =alloc_buffer_head (GFP_NOFS |__GFP_NOFAIL);/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =journal_add_journal_head (new_bh);/* This sleeps */
fs/jbd2/journal.c +0 -2
@@ -367,8 +367,6 @@ retry_alloc: }/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =jbd2_journal_add_journal_head (new_bh);/* This sleeps */
Signature · 1 line
1.8.2.rc2.4.g7799588
Jan Kara
reviewerQuoted 4 lines · majianpeng
Because alloc 'struct
buffer_head' using kmem_cache_zalloc,so it doesn't need to call 'init_buffer(bh, NULL, NULL)' and other set-zero-operation.Signed-off-by Jianpeng Ma <[email protected]>
Looks good. If noone objects, I'll merge the patch through my tree.
Honza
Quoted 48 lines
--- fs/buffer.c | 2 -- fs/jbd/journal.c | 2 -- fs/jbd2/journal.c | 2 -- 3 files changed, 6 deletions(-)fs/buffer.c +0
-2@@ -865,8 +865,6 @@ try_again:/* Link the buffer to its page */ set_bh_page (bh, page, offset); - -init_buffer (bh,NULL ,NULL ); }return head;/* fs/jbd/journal.c +0
-2@@ -310,8 +310,6 @@ int journal_write_metadata_buffer(transaction_t *transaction, new_bh =alloc_buffer_head (GFP_NOFS |__GFP_NOFAIL);/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =journal_add_journal_head (new_bh);/* This sleeps */ fs/jbd2/journal.c +0
-2@@ -367,8 +367,6 @@ retry_alloc: }/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =jbd2_journal_add_journal_head (new_bh);/* This sleeps */ Signature · 1 line
1.8.2.rc2.4.g7799588
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Jan Kara
reviewerQuoted 4 lines · majianpeng
Because alloc 'struct
buffer_head' using kmem_cache_zalloc,so it doesn't need to call 'init_buffer(bh, NULL, NULL)' and other set-zero-operation.Signed-off-by Jianpeng Ma <[email protected]>
I've just noticed the whitespace is still mangled. Gmail is known for
destroying whitespace so please send the patch as an attachment. Thanks.
Honza
Quoted 48 lines
--- fs/buffer.c | 2 -- fs/jbd/journal.c | 2 -- fs/jbd2/journal.c | 2 -- 3 files changed, 6 deletions(-)fs/buffer.c +0
-2@@ -865,8 +865,6 @@ try_again:/* Link the buffer to its page */ set_bh_page (bh, page, offset); - -init_buffer (bh,NULL ,NULL ); }return head;/* fs/jbd/journal.c +0
-2@@ -310,8 +310,6 @@ int journal_write_metadata_buffer(transaction_t *transaction, new_bh =alloc_buffer_head (GFP_NOFS |__GFP_NOFAIL);/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =journal_add_journal_head (new_bh);/* This sleeps */ fs/jbd2/journal.c +0
-2@@ -367,8 +367,6 @@ retry_alloc: }/* keep subsequent assertions sane */ - new_bh->b_state =0 ; -init_buffer (new_bh,NULL ,NULL );atomic_set (&new_bh->b_count,1 ); new_jh =jbd2_journal_add_journal_head (new_bh);/* This sleeps */ Signature · 1 line
1.8.2.rc2.4.g7799588
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR