Skip to contentSkip to conversation

named pipe writes on readonly filesystems

DISCUSSION Chris Mason 3 participants 4 messages Mar 13, 2001

lore
Share & tools
lore
#0 lore raw

Hello everyone,

Since fs/pipe.c:pipe_write() calls mark_inode_dirty, and it is legal to write to a named pipe on a readonly filesystem, we can end up writing an inode on a readonly FS.

reiserfs prints a warning whenever someone tries to write an inode on a readonly FS, so we've been getting a few complaints about this.

I see at least 3 choices:

drop the reiserfs warning, it was only there to chase things similar to the remount root readonly bug in 2.4.0.

change mark_inode_dirty or write_inode to exit early on readonly filesystems.

change pipe_write to leave the inode clean when the FS is readonly.

Does anyone have a preference? I'd rather not see each FS have to check for this on their own, but the other filesystems aren't as picky as reiserfs in this case ;-)

-chris

#1 lore raw
Quoted 5 lines · Chris Mason

Hello everyone,

Since fs/pipe.c:pipe_write() calls mark_inode_dirty, and it is legal to write to a named pipe on a readonly filesystem, we can end up writing an inode on a readonly FS.

I would check that in pipe_write()...
Cheers,
Al

#2 lore raw
In reply to Chris Mason
Quoted 6 lines · Alexander Viro
Quoted 3 lines · Chris Mason

Since fs/pipe.c:pipe_write() calls mark_inode_dirty, and it is legal to write to a named pipe on a readonly filesystem, we can end up writing an inode on a readonly FS.

I would check that in pipe_write()...

So atime and mtime of a named pipe are meaningless in general? That would make sense, since you cannot access the data anymore, once they are through the pipe.

Regards

Ingo Oeser

Signature · 2 lines
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
#3 lore raw
Quoted 11 lines · Ingo Oeser
Quoted 6 lines · Alexander Viro
Quoted 3 lines · Chris Mason

Since fs/pipe.c:pipe_write() calls mark_inode_dirty, and it is legal to write to a named pipe on a readonly filesystem, we can end up writing an inode on a readonly FS.

I would check that in pipe_write()...

So atime and mtime of a named pipe are meaningless in general? That would make sense, since you cannot access the data anymore, once they are through the pipe.

Huh? They are meaningless if fs is read-only. Can't change inode in such situation... For normal filesystems it's "how long ago somebody did <type of access> with this FIFO".