xf86-dri-vivante: add missing dependency on xf86driproto
PATCH 1/1 xf86-dri-vivante: add missing dependency on xf86driproto
Without this dependency recipe failed to compile (triggered by bitbake core-image-x11)
From 8d371da2536cb985c53908d58a8e68100ed113ba Mon Sep 17 00:00:00 2001
From: Christian Charreyre <[email protected]>
Date: Fri, 19 Apr 2013 16:41:39 +0200
Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driproto
--- .../xorg-driver/xf86-dri-vivante_1.1.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb +1 -1
@@ -4,7 +4,7 @@ LICENSE = "MIT" SECTION = "x11/base" -DEPENDS = "virtual/xserver xf86-video-imxfb-vivante" +DEPENDS = "virtual/xserver xf86-video-imxfb-vivante xf86driproto" LIC_FILES_CHKSUM =
"file://src/dri.h;enline=27;md5=1d0d59e1dc96f5197ea3a8b101bf1fcc"
SRC_URI = "${FSL_MIRROR}/xserver-xorg-video-imx-viv-${PV}.tar.gz \
Signature · 10 lines
1.7.9.5 -- Christian Charreyre CIO Informatique Industrielle 11 Avenue Marigny 13014 Marseille Tél : 04 95 05 19 41 http://www.cioinfoindus.fr
begin:vcard
fn:Christian Charreyre n:Charreyre;Christian
org:CIO Informatique Industrielle adr;dom:;;11 Avenue Marigny;Marseille;;13014 email;internet:[email protected] tel;work:04 95 05 19 41 url:http://www.cioinfoindus.fr
version:2.1
end:vcard
Quoted 2 lines · Christian Charreyre
Without this dependency recipe failed to compile (triggered by bitbake core-image-x11)
First, thanks for the patch. This explanation would be good to have in the commit log or something generic if you prefer.
Quoted 6 lines
From
8d371da2536cb985c53908d58a8e68100ed113baMon Sep 17 00:00:00 2001
From: Christian Charreyre <[email protected]>
Date: Fri, 19 Apr 2013 16:41:39 +0200
Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driprotoSigned-off-by Christian Charreyre <[email protected]>
I am a bit confused as virtual/xserver is provided by xserver-xorg and this depends on xf86driproto so we'd be safe here.
I started a clean build here to check if I can reproduce it. In any case, please resend the patch using git send-email so if I can reproduce it here we can apply it.
--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Quoted 13 lines · Otavio Salvador
Quoted 2 lines · Christian Charreyre
Without this dependency recipe failed to compile (triggered by bitbake core-image-x11)
First, thanks for the patch. This explanation would be good to have in the commit log or something generic if you prefer.
Quoted 5 lines
From
8d371da2536cb985c53908d58a8e68100ed113baMon Sep 17 00:00:00 2001
From: Christian Charreyre <[email protected]>
Date: Fri, 19 Apr 2013 16:41:39 +0200
Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driproto
Quoted 8 lines
Quoted 1 line
Signed-off-by Christian Charreyre <[email protected]>I am a bit confused as virtual/xserver is provided by xserver-xorg and this depends on xf86driproto so we'd be safe here.
I started a clean build here to check if I can reproduce it. In any case, please resend the patch using git send-email so if I can reproduce it here we can apply it.
I did a full build from scratch of xf86-dri-vivante (no tmp, no sstate-cache) and it did work so I think you had other failure.
--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): CAP9ODKpbHrRStioy4C6MgSkW8zrdF+xSmPX2GtNftKBbvnysJQ@mail.gmail.com
Quoted 12 lines · Otavio Salvador
Quoted 10 lines · Christian Charreyre
Quoted 8 lines · Otavio Salvador
Quoted 6 lines · Otavio Salvador
Quoted 2 lines · Christian Charreyre
Without this dependency recipe failed to compile (triggered by bitbake core-image-x11)
First, thanks for the patch. This explanation would be good to have in the commit log or something generic if you prefer.
Quoted 7 lines
Quoted 3 lines
Sorry for the bad format, it's my first send, and I didn't find an explanation on the good practices for patch submission. Is there one anywhere ?
https://wiki.yoctoproject.org/wiki/Contribution_Guidelines#Patch_Headers_and_Commit_Messages
But the change does seem not required. I did a full build without it and had no issues.
Thanks for the pointer. I do understand that this patch was not necessary.
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
I did a full build from scratch of xf86-dri-vivante (no tmp, no sstate-cache) and it did work so I think you had other failure.
With the patch I succedeed to build xf86-dri-vivante, but I have another problem when building complete image (
do_rootfs).
After more investigation, it seems that the problem is inDISTRO_FEATURES. As I have not specifiedDISTRO_FEATURESin my local.conf, and uses the very neutral one from openembedded-core, I do not have glx in my distro features. I will try to add x11 and glx inDISTRO_FEATURES, and report then what happens.
Quoted 2 lines
I've been building using Poky, not OE-Core. If you find out how to reproduce the issue let me know and I can check it as well.
Question : do you work with a yocto base, or do you use a poky config on an openembedded-core base ?
I've first tried generating meta-fsl-arm over yocto (danny), but I got errors (versionning problem between components I guess), so I read the README of the layer meta-fsl-arm, and it tells that it depends only on :
openembedded-core
branch master
revision HEAD,
not yocto, so this is the reason why I swapped to OE-core, but I think OE-core is too distribution agnostic for core-x11-image.
Quoted 7 lines
--
Otavio SalvadorO.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Signature · 5 lines
Christian Charreyre CIO Informatique Industrielle 11 Avenue Marigny 13014 Marseille Tél : 04 95 05 19 41 http://www.cioinfoindus.fr
Quoted 14 lines · Christian Charreyre
Quoted 3 lines · Otavio Salvador
On Mon, Apr 22, 2013 at 10:34 AM, Christian Charreyre I've been building using Poky, not OE-Core. If you find out how to reproduce the issue let me know and I can check it as well.
Question : do you work with a yocto base, or do you use a poky config on an openembedded-core base ?
I've first tried generating meta-fsl-arm over yocto (danny), but I got errors
(versionning problem between components I guess), so I read the README of the layer meta-fsl-arm, and it tells that it depends only on :
Quoted 7 lines
openembedded-core
branch master
revision HEAD,not yocto, so this is the reason why I swapped to OE-core, but I think OE-core
is too distribution agnostic for core-x11-image.
I usually work on Poky but it depends on the project. The README could have some love to be clear about it (patches welcome) but you should be able to run it with oe-core and poky.
--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br