Skip to contentSkip to conversation

rtl8192c:dm: Properly initialize local array and set value.

PATCH In review Han Shen 2 participants 2 messages Apr 22, 2013 Networking drivers (wireless)

lore
Share & tools
lore

Han Shen

author
#0 lore raw

PATCH v2 1/1 rtl8192c:dm: Properly initialize local array and set value.

GCC 4.8 is spitting out uninitialized-variable warnings against "drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c". This patch adds initialization to the variable and properly sets its value.

---
 drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c +2 -2
index b793a65..34150de 100644
@@ -669,7 +669,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
 	u8 thermalvalue, delta, delta_lck, delta_iqk;
 	long ele_a, ele_d, temp_cck, val_x, value32;
 	long val_y, ele_c = 0;
-	u8 ofdm_index[2], ofdm_index_old[2], cck_index_old = 0;
+	u8 ofdm_index[2], ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
 	s8 cck_index = 0;
 	int i;
 	bool is2t = IS_92C_SERIAL(rtlhal->version);
@@ -717,7 +717,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
 			for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
 				if (ele_d == (ofdmswing_table[i] &
 				    MASKOFDM_D)) {
-
+					ofdm_index_old[1] = (u8) i;
 					RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
 						 DBG_LOUD,
 						 "Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index=0x%x\n",
Signature · 1 line
1.8.2.1
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Han Shen

GCC 4.8 is spitting out uninitialized-variable warnings against "drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c". This patch adds initialization to the variable and properly sets its value.

---
  drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks,

Larry

Quoted 24 lines
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c +2 -2
index b793a65..34150de 100644
@@ -669,7 +669,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
  	u8 thermalvalue, delta, delta_lck, delta_iqk;
  	long ele_a, ele_d, temp_cck, val_x, value32;
  	long val_y, ele_c = 0;
-	u8 ofdm_index[2], ofdm_index_old[2], cck_index_old = 0;
+	u8 ofdm_index[2], ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
  	s8 cck_index = 0;
  	int i;
  	bool is2t = IS_92C_SERIAL(rtlhal->version);
@@ -717,7 +717,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
  			for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
  				if (ele_d == (ofdmswing_table[i] &
  				    MASKOFDM_D)) {
-
+					ofdm_index_old[1] = (u8) i;
  					RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
  						 DBG_LOUD,
  						 "Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index=0x%x\n",