Skip to contentSkip to conversation

glibmm: new package

PATCH New nmenegale 3 participants 4 messages Apr 23, 2013

lore
Share & tools
lore

nmenegale

author
#0 lore raw

PATCH 1/2 glibmm: new package

---
v0: initial commit
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)

---
 package/Config.in        |  1 +
 package/glibmm/Config.in |  8 ++++++++
 package/glibmm/glibmm.mk | 13 +++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 package/glibmm/Config.in
 create mode 100644 package/glibmm/glibmm.mk
package/Config.in +1 -0
index 06bcdef..c75c3ec 100644
@@ -558,6 +558,7 @@ source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
 source "package/argp-standalone/Config.in"
 source "package/boost/Config.in"
+source "package/glibmm/Config.in"
 source "package/gmp/Config.in"
 source "package/gsl/Config.in"
 source "package/gtest/Config.in"
package/glibmm/Config.in new file +8 -0
new file mode 100644
index 0000000..16a7a9b
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_GLIBMM
+	bool "glibmm"
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBSIGC
+	help
+	  The GLibmm package is a set of C++ bindings for GLib. 
+	  	
+	  http://www.gtkmm.org/
package/glibmm/glibmm.mk new file +13 -0
new file mode 100644
index 0000000..f7f49bd
@@ -0,0 +1,13 @@
+#############################################################
+#
+# Glibmm
+#
+#############################################################
+GLIBMM_VERSION = 2.30.1
+GLIBMM_LICENSE = LGPLv2.1
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 2/2 libxml++: new package

---
v0: initial commit
libxml++ is a C++ wrapper for libxml2 it has glibmm as dependency

---
 package/Config.in            |  1 +
 package/libxmlpp/Config.in   |  8 ++++++++
 package/libxmlpp/libxmlpp.mk | 15 +++++++++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 package/libxmlpp/Config.in
 create mode 100644 package/libxmlpp/libxmlpp.mk
package/Config.in +1 -0
index c75c3ec..8ce344b 100644
@@ -620,6 +620,7 @@ source "package/json-glib/Config.in"
 source "package/libroxml/Config.in"
 source "package/libxml-parser-perl/Config.in"
 source "package/libxml2/Config.in"
+source "package/libxmlpp/Config.in"
 source "package/libxslt/Config.in"
 source "package/libyaml/Config.in"
 source "package/mxml/Config.in"
package/libxmlpp/Config.in new file +8 -0
new file mode 100644
index 0000000..e8b2419
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBXMLPP
+	bool "libxmlpp"
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_GLIBMM
+	help
+	  libxml++ is a C++ wrapper for the libxml XML parser library.	
+	  
+	  http://libxmlplusplus.sourceforge.net/
package/libxmlpp/libxmlpp.mk new file +15 -0
new file mode 100644
index 0000000..693a83c
@@ -0,0 +1,15 @@
+#############################################################
+#
+# LibXML++
+#
+#############################################################
+LIBXMLPP_VERSION_MAJOR = 2.34
+LIBXMLPP_VERSION_MINOR = 2
+LIBXMLPP_VERSION = $(LIBXMLPP_VERSION_MAJOR).$(LIBXMLPP_VERSION_MINOR)
+LIBXMLPP_LICENSE = LGPLv2+
+LIBXMLPP_SOURCE = libxml++-$(LIBXMLPP_VERSION).tar.bz2
+LIBXMLPP_SITE = http://ftp.gnome.org/pub/GNOME/sources/libxml++/$(LIBXMLPP_VERSION_MAJOR)
+LIBXMLPP_INSTALL_STAGING = YES
+LIBXMLPP_DEPENDENCIES = libxml2 glibmm host-pkgconf
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/2 glibmm: new package

In reply to nmenegale

package/glibmm/Config.in line 8

Quoted 10 lines · nmenegale

+++ b/package/glibmm/Config.in

package/glibmm/Config.in new file +8 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_GLIBMM
+	bool "glibmm"
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBSIGC
+	help
+	  The GLibmm package is a set of C++ bindings for GLib. 
+	  	
+	  http://www.gtkmm.org/

This should depend on BR2_INSTALL_LIBSTDCPP since it requires a toolchain with C++ support, with a comment otherwise like other packages do (look at package/protobuf/Config.in for an example).
Same case with libxml++.

Quoted 5 lines

+++ b/package/glibmm/glibmm.mk

package/glibmm/glibmm.mk new file +3 -0
@@ -0,0 +1,13 @@
+#############################################################
+#
+# Glibmm

package/glibmm/glibmm.mk line 13

Quoted 10 lines
package/glibmm/glibmm.mk new file +10 -0
+#
+#############################################################
+GLIBMM_VERSION = 2.30.1
+GLIBMM_LICENSE = LGPLv2.1
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))

You define GLIBMM_LICENSE but no GLIBMM_LICENSE_FILES, could you fix that since glibmm ships them?
libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend in Config.in
Otherwise it's looking good, thanks.
Regards.

#3 lore raw

PATCH 1/2 glibmm: new package

Dear Gustavo Zacarias,

Quoted 2 lines · Gustavo Zacarias

libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend in Config.in

And therefore the libxml++ should also carry this dependency as a consequence.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com