can: sja1000: use common prefix for all sja1000 defines

This is a follow up patch to:

f901b6b can: sja1000: fix define conflict on SH

That patch fixed a define conflict between the SH architecture and the sja1000 driver, by addind a prefix to one macro only. This patch consistently renames the prefix of the SJA1000 controller registers from "REG_" to "SJA1000_".

Signed-off-by Oliver Hartkopp <[email protected]>

---

Hello Marc,

to not miss the current net-next window, here's a well formatted patch for my REG_ rename proposal. It renames the formerly register defines from REG_ to SJA1000_ and leaves the content definitions of the registers as-is. This is because of all content definitions would have to be changed in sja1000.h AND include/linux/can/platform/sja1000.h to have a consistent naming scheme.

Hi linux-can members,

I currently wonder whether it exists any way of getting the list of the installed CAN interfaces, from a C program?
I mean, getting the network interfaces list is available using ioctl(SIOCGIFCONF).
But AFAIK, this (only) returns the IP interfaces found in the system, even using a socket CAN file descriptor.
And, I would also like to avoid some pipe/fork/grep/sed in this C program too ;-)

Thanks for your help and best regards,

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.:
DE39305391 Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, [email protected]
----
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

Kurt

Quoted 24 lines · Stephane Grosjean

Hi linux-can members,

I currently wonder whether it exists any way of getting the list of the installed CAN interfaces, from a C program?
I mean, getting the network interfaces list is available using ioctl(SIOCGIFCONF).
But AFAIK, this (only) returns the IP interfaces found in the system, even using a socket CAN file descriptor.
And, I would also like to avoid some pipe/fork/grep/sed in this C program too ;-)

Thanks for your help and best regards,

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.:
DE39305391 Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, [email protected]
----
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

Quoted 21 lines · Wolfgang Grandegger

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Quoted 3 lines

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

Good idea, Stephane, can you license the code under a permissive license like LGPL or BSD?

Quoted 26 lines · Marc Kleine-Budde

Quoted 24 lines · Wolfgang Grandegger

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

Quoted 2 lines

Good idea, Stephane, can you license the code under a permissive license like LGPL or BSD?

Errr...sorry. It's Kurt, who posted that code.

Kurt, can you give the code a nice license? :)

Quoted 27 lines · Marc Kleine-Budde

Quoted 26 lines · Marc Kleine-Budde

Quoted 24 lines · Wolfgang Grandegger

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

Quoted 6 lines

Quoted 2 lines

Good idea, Stephane, can you license the code under a permissive license like LGPL or BSD?

Errr...sorry. It's Kurt, who posted that code.

Kurt, can you give the code a nice license? :)

What is needed for LGPL or BSD?
Is there a short overview available?

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

Wolfgang.

Quoted 29 lines

Kurt

Quoted 24 lines · Stephane Grosjean

Hi linux-can members,

I currently wonder whether it exists any way of getting the list of the installed CAN interfaces, from a C program?
I mean, getting the network interfaces list is available using ioctl(SIOCGIFCONF).
But AFAIK, this (only) returns the IP interfaces found in the system, even using a socket CAN file descriptor.
And, I would also like to avoid some pipe/fork/grep/sed in this C program too ;-)

Thanks for your help and best regards,

Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.:
DE39305391 Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, [email protected]
----
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 21 lines · Wolfgang Grandegger

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Quoted 3 lines

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

would it make sense to maintain the split into enumif-test.c and enumif.c, so for example Stephane could just link to libenumif.a?

Quoted 22 lines · Kurt Van Dijck

Quoted 21 lines · Wolfgang Grandegger

Hi Kurt,

Quoted 6 lines · Kurt Van Dijck

Hi Stephane,

I have written this some time ago, not using it actually. I tried a modular approach, don't know if its usefull.

PS: I used attachments.

~/enumif$ ./enumif
1: lo {loopback} <LOOPBACK,UP,LOWER_UP> UNKNOWN
2: eth0 {ether} <BROADCAST,MULTICAST> DOWN
3: eth1 {ether} <BROADCAST,MULTICAST,UP,LOWER_UP> UNKNOWN
4: eth3 {ether} <NO-CARRIER,BROADCAST,MULTICAST,UP> DOWN
5: can0 {can} <NOARP,UP,LOWER_UP,ECHO> UNKNOWN
6: can1 {can} <NOARP,ECHO> DOWN
7: can2 {can} <NOARP,ECHO> DOWN
8: can3 {can} <NOARP,ECHO> DOWN
9: pan0 {ether} <BROADCAST,MULTICAST> DOWN

Quoted 6 lines

Quoted 3 lines

Cool! We know that "ip link" does list all network interfaces but the code doing the job is not really strength-forward. I think this would be a nice enhancement of the can-utils.

would it make sense to maintain the split into enumif-test.c and enumif.c, so for example Stephane could just link to libenumif.a?

Well, a better place might be libsocketcan then. In general it would be nice to host libsocketcan (maybe as liblinuxcan) at
https://gitorious.org/linux-can as well.

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

I was just thinking that it has not that much to do with CAN altogether, and may deserve a seperate git tree.

I'm just rewriting the code a bit to work without callback, and be more like if_nameindex().

Quoted 5 lines · Kurt Van Dijck

I was just thinking that it has not that much to do with CAN altogether, and may deserve a seperate git tree.

I'm just rewriting the code a bit to work without callback, and be more like if_nameindex().

Would be cool if the functions follows the same semantics as if_nameindex(), i.e. it could be named canif_nameindex() and just return CAN interfaces, not all.

Marc

Signature · 4 lines

Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Quoted 4 lines · Marc Kleine-Budde

Quoted 3 lines · Kurt Van Dijck

I was just thinking that it has not that much to do with CAN altogether, and may deserve a seperate git tree.

Quoted 6 lines

Quoted 2 lines

I'm just rewriting the code a bit to work without callback, and be more like if_nameindex().

Would be cool if the functions follows the same semantics as if_nameindex(), i.e. it could be named canif_nameindex() and just return CAN interfaces, not all.

and such function belongs to libsocketcan, indeed. sounds like a plan.

Hi linux-can members,

I currently wonder whether it exists any way of getting the list of the installed CAN interfaces, from a C program? I mean, getting the network interfaces list is available using ioctl(SIOCGIFCONF).
But AFAIK, this (only) returns the IP interfaces found in the system, even using a socket CAN file descriptor. And, I would also like to avoid some pipe/fork/grep/sed in this C program too ;-)

Thanks for your help and best regards,

Stéphane

Signature · 5 lines

PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, [email protected]
----
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Stephane,

This is what i have done in a open source project i have started, a web can analyzer called ewecan (https://bitbucket.org/Mongo/ewecan):
It parses /sys/class/net but unfortunately, as noted in comments, it cannot make the difference between up or down interfaces.

/* Get a list of available socketcan interfaces and return them in
a string as a JS array like ["can0", "can1", "vcan"] Returned string must be freed after use
BUG : it also returns interfaces that are present but down !
*/

Stephane,

This is what i have done in a open source project i have started, a web can analyzer called ewecan (https://bitbucket.org/Mongo/ewecan):
It parses /sys/class/net but unfortunately, as noted in comments, it cannot make the difference between up or down interfaces.

/* Get a list of available socketcan interfaces and return them in
a string as a JS array like ["can0", "can1", "vcan"] Returned string must be freed after use
BUG : it also returns interfaces that are present but down !
*/
char *cmd_listitf(void)

{
    char *buf = malloc(255);
    if(!buf)
        return NULL;
    /* looking for socketcan interfaces in /sys */
    DIR *fdir = opendir("/sys/class/net");
    if(fdir == NULL){
        perror("opendir");
        free(buf);
        return NULL;
    }
    struct dirent *fic;
    int firstdone = 0;
    buf[0] = '[';
    buf[1] = '\0';
    while(1){
        fic = readdir(fdir);
        if(fic == NULL)
            break;
        if(!strstr(fic->d_name, "can"))
            continue;
        /* if the new string does not fit in buf, stop here */
        if((strlen(fic->d_name) + strlen(buf) + 4) >= 255)
            break;
        if(firstdone)
            strcat(buf, ",");
        strcat(buf, "\"");
        strcat(buf, fic->d_name);
        strcat(buf, "\"");
        firstdone = 1;
    }
    strcat(buf, "]");
    closedir(fdir);
    return buf;
}

Hope it can help !

Regards

--
François Beaulier
www.ingelibre.fr

Quoted 11 lines · Stephane Grosjean

Hi linux-can members,

I currently wonder whether it exists any way of getting the list of the installed CAN interfaces, from a C program?
I mean, getting the network interfaces list is available using ioctl(SIOCGIFCONF).
But AFAIK, this (only) returns the IP interfaces found in the system, even using a socket CAN file descriptor.
And, I would also like to avoid some pipe/fork/grep/sed in this C program too ;-)

Quoted 13 lines

Thanks for your help and best regards,

Stéphane

Signature · 9 lines

PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA
Darmstadt HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078,
WEE-Reg.-Nr.: DE39305391 Tel.+49 (0)6151-817320 / Fax:+49
(0)6151-817329, [email protected]
----
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html