Skip to contentSkip to conversation

cpuidle: add maintainer entry

PATCH New Daniel Lezcano 8 participants 14 messages Apr 24, 2013 – Apr 26, 2013 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Currently the cpuidle drivers are spread across the different archs.

The patch submission for cpuidle are following different path: the cpuidle core code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific tree, sh goes through sh arch tree, pseries goes through PowerPC and finally intel goes through Len's tree while acpi_idle goes under linux-pm.

That makes difficult to consolidate the code and to propagate modifications from the cpuidle core to the different drivers.

Hopefully, a movement has initiated to put the cpuidle drivers into the drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c

Add an explicit maintainer entry in the MAINTAINER to clarify the situation and prevent new cpuidle drivers to goes to an arch directory.

The upstreaming process is unchanged: Rafael takes the patches to merge them into its tree but with the acked-by from the driver's maintainer. So the header must contains the name of the maintainer.

This organization will be the same than cpufreq.

---
 MAINTAINERS                        |    7 +++++++
 drivers/cpuidle/cpuidle-calxeda.c  |    4 +++-
 drivers/cpuidle/cpuidle-kirkwood.c |    5 +++--
 3 files changed, 13 insertions(+), 3 deletions(-)
MAINTAINERS +7 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:	Maintained
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
+CPUIDLE DRIVERS
+M:	Rafael J. Wysocki <[email protected]>
+L:	linux-pm at vger.kernel.org
+S:	Maintained
+F:	drivers/cpuidle/*
+F:	include/linux/cpuidle.h
+
 CPU FREQUENCY DRIVERS - ARM BIG LITTLE
 M:	Viresh Kumar <[email protected]>
 M:	Sudeep KarkadaNagesha <[email protected]>
drivers/cpuidle/cpuidle-calxeda.c +3 -1
index e344b56..2378c39 100644
@@ -1,7 +1,6 @@
 /*
  * Copyright 2012 Calxeda, Inc.
  *
- * Based on arch/arm/plat-mxc/cpuidle.c:
  * Copyright 2012 Freescale Semiconductor, Inc.
  * Copyright 2012 Linaro Ltd.
  *
@@ -16,6 +15,9 @@
  *
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author    : Rob Herring <[email protected]>
+ * Maintainer: Rob Herring <[email protected]>
  */
 
 #include <linux/cpuidle.h>
drivers/cpuidle/cpuidle-kirkwood.c +3 -2
index 53290e1..521b0a7 100644
@@ -1,6 +1,4 @@
 /*
- * arch/arm/mach-kirkwood/cpuidle.c
- *
  * CPU idle Marvell Kirkwood SoCs
  *
  * This file is licensed under the terms of the GNU General Public
@@ -11,6 +9,9 @@
  * to implement two idle states -
  * #1 wait-for-interrupt
  * #2 wait-for-interrupt and DDR self refresh
+ *
+ * Maintainer: Jason Cooper <[email protected]>
+ * Maintainer: Andrew Lunn <[email protected]>
  */
 
 #include <linux/kernel.h>
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 20 lines · Daniel Lezcano

Currently the cpuidle drivers are spread across the different archs.

The patch submission for cpuidle are following different path: the cpuidle core code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific tree, sh goes through sh arch tree, pseries goes through PowerPC and finally intel goes through Len's tree while acpi_idle goes under linux-pm.

That makes difficult to consolidate the code and to propagate modifications from the cpuidle core to the different drivers.

Hopefully, a movement has initiated to put the cpuidle drivers into the drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c

Add an explicit maintainer entry in the MAINTAINER to clarify the situation and prevent new cpuidle drivers to goes to an arch directory.

The upstreaming process is unchanged: Rafael takes the patches to merge them into its tree but with the acked-by from the driver's maintainer. So the header must contains the name of the maintainer.

Quoted 8 lines

This organization will be the same than cpufreq.

---
 MAINTAINERS                        |    7 +++++++
 drivers/cpuidle/cpuidle-calxeda.c  |    4 +++-
 drivers/cpuidle/cpuidle-kirkwood.c |    5 +++--
 3 files changed, 13 insertions(+), 3 deletions(-)

For the kirkwood bit:

thx,

Jason.

#2 lore raw

PATCH 1/1 cpuidle: add maintainer entry

In reply to Daniel Lezcano
Quoted 81 lines · Daniel Lezcano

Currently the cpuidle drivers are spread across the different archs.

The patch submission for cpuidle are following different path: the cpuidle core code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific tree, sh goes through sh arch tree, pseries goes through PowerPC and finally intel goes through Len's tree while acpi_idle goes under linux-pm.

That makes difficult to consolidate the code and to propagate modifications from the cpuidle core to the different drivers.

Hopefully, a movement has initiated to put the cpuidle drivers into the drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c

Add an explicit maintainer entry in the MAINTAINER to clarify the situation and prevent new cpuidle drivers to goes to an arch directory.

The upstreaming process is unchanged: Rafael takes the patches to merge them into its tree but with the acked-by from the driver's maintainer. So the header must contains the name of the maintainer.

This organization will be the same than cpufreq.

---
 MAINTAINERS                        |    7 +++++++
 drivers/cpuidle/cpuidle-calxeda.c  |    4 +++-
 drivers/cpuidle/cpuidle-kirkwood.c |    5 +++--
 3 files changed, 13 insertions(+), 3 deletions(-)
MAINTAINERS +7 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:	Maintained
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
+CPUIDLE DRIVERS
+M:	Rafael J. Wysocki <[email protected]>
+L:	linux-pm at vger.kernel.org
+S:	Maintained
+F:	drivers/cpuidle/*
+F:	include/linux/cpuidle.h
+
 CPU FREQUENCY DRIVERS - ARM BIG LITTLE
 M:	Viresh Kumar <[email protected]>
 M:	Sudeep KarkadaNagesha <[email protected]>
drivers/cpuidle/cpuidle-calxeda.c +3 -1
index e344b56..2378c39 100644
@@ -1,7 +1,6 @@
 /*
  * Copyright 2012 Calxeda, Inc.
  *
- * Based on arch/arm/plat-mxc/cpuidle.c:
  * Copyright 2012 Freescale Semiconductor, Inc.
  * Copyright 2012 Linaro Ltd.
  *
@@ -16,6 +15,9 @@
  *
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author    : Rob Herring <[email protected]>
+ * Maintainer: Rob Herring <[email protected]>
  */
 
 #include <linux/cpuidle.h>
drivers/cpuidle/cpuidle-kirkwood.c +0 -2
index 53290e1..521b0a7 100644
@@ -1,6 +1,4 @@
 /*
- * arch/arm/mach-kirkwood/cpuidle.c
- *
  * CPU idle Marvell Kirkwood SoCs
  *
  * This file is licensed under the terms of the GNU General Public

drivers/cpuidle/cpuidle-kirkwood.c line 16

Quoted 8 lines
drivers/cpuidle/cpuidle-kirkwood.c +3 -0
@@ -11,6 +9,9 @@
  * to implement two idle states -
  * #1 wait-for-interrupt
  * #2 wait-for-interrupt and DDR self refresh
+ *
+ * Maintainer: Jason Cooper <[email protected]>
+ * Maintainer: Andrew Lunn <[email protected]>
  */
 

For the Kirkwood part

Andrew

#3 lore raw

PATCH 1/1 cpuidle: add maintainer entry

In reply to Daniel Lezcano

Rafael,

Daniel Lezcano <[email protected]> writes:

[...]

Quoted 5 lines
MAINTAINERS +0 -0
index 61677c3..effa0f3 100644

MAINTAINERS S: Maintained · line 2214

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2206,6 +2206,13 @@ S:	Maintained
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
+CPUIDLE DRIVERS
+M:	Rafael J. Wysocki <[email protected]>
+L:	linux-pm at vger.kernel.org
+S:	Maintained
+F:	drivers/cpuidle/*
+F:	include/linux/cpuidle.h

What do you think about having Daniel listed here as a co-maintainer?

He has been driving a significant consolidation effort, and will continue to do that, so I think he should help take care of this area and ensure all drivers are moving in the right direction.

Kevin

#4 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 14 lines · Kevin Hilman

Rafael,

Daniel Lezcano <[email protected]> writes:

[...]

Quoted 8 lines
MAINTAINERS +0 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:     Maintained
 F:   drivers/cpufreq/
 F:   include/linux/cpufreq.h
 
Quoted 8 lines

MAINTAINERS S: Maintained · line 2214

Quoted 6 lines
MAINTAINERS +6 -0
+CPUIDLE DRIVERS
+M:   Rafael J. Wysocki <[email protected]>
+L:   linux-pm at vger.kernel.org
+S:   Maintained
+F:   drivers/cpuidle/*
+F:   include/linux/cpuidle.h

What do you think about having Daniel listed here as a co-maintainer?

I second that. He will bring useful embedded knowledge to the subsystem.

Yours,
Linus Walleij

#5 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 24 lines · Linus Walleij
Quoted 14 lines · Kevin Hilman

Rafael,

Daniel Lezcano <[email protected]> writes:

[...]

Quoted 8 lines
MAINTAINERS +0 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:     Maintained
 F:   drivers/cpufreq/
 F:   include/linux/cpufreq.h
 
Quoted 8 lines

MAINTAINERS S: Maintained · line 2214

Quoted 6 lines
MAINTAINERS +6 -0
+CPUIDLE DRIVERS
+M:   Rafael J. Wysocki <[email protected]>
+L:   linux-pm at vger.kernel.org
+S:   Maintained
+F:   drivers/cpuidle/*
+F:   include/linux/cpuidle.h

What do you think about having Daniel listed here as a co-maintainer?

Quoted 2 lines

I second that. He will bring useful embedded knowledge to the subsystem.

I'd still like to have a say about the core, but if Daniel is willing to maintain ARM cpuidle drivers and all of the relevant ARM people agree with that, that'll be great.

Thanks,
Rafael

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
#6 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 11 lines · Rafael J. Wysocki
Quoted 6 lines · Linus Walleij
Quoted 1 line · Kevin Hilman

What do you think about having Daniel listed here as a co-maintainer?

I second that. He will bring useful embedded knowledge to the subsystem.

I'd still like to have a say about the core, but if Daniel is willing to maintain ARM cpuidle drivers and all of the relevant ARM people agree with that, that'll be great.

OK Daniel can you post a v2 adding yourself as co-maintainer as well? Add my Acked-by if you wish.

Yours,
Linus Walleij

#7 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 9 lines · Linus Walleij
Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Linus Walleij
Quoted 1 line · Kevin Hilman

What do you think about having Daniel listed here as a co-maintainer?

I second that. He will bring useful embedded knowledge to the subsystem.

Quoted 6 lines
Quoted 3 lines

I'd still like to have a say about the core, but if Daniel is willing to maintain ARM cpuidle drivers and all of the relevant ARM people agree with that, that'll be great.

OK Daniel can you post a v2 adding yourself as co-maintainer as well? Add my Acked-by if you wish.

Sure, I can help and ensure the drivers are going to the right direction, especially the ARM drivers. I will add also Rafael's git tree link.

Thanks
-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#8 lore raw

PATCH 1/1 cpuidle: add maintainer entry

In reply to Daniel Lezcano
Quoted 13 lines · Daniel Lezcano

Currently the cpuidle drivers are spread across the different archs.

The patch submission for cpuidle are following different path: the cpuidle core code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific tree, sh goes through sh arch tree, pseries goes through PowerPC and finally intel goes through Len's tree while acpi_idle goes under linux-pm.

That makes difficult to consolidate the code and to propagate modifications from the cpuidle core to the different drivers.

Hopefully, a movement has initiated to put the cpuidle drivers into the drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c

Quoted 6 lines

Add an explicit maintainer entry in the MAINTAINER to clarify the situation and prevent new cpuidle drivers to goes to an arch directory.

The upstreaming process is unchanged: Rafael takes the patches to merge them into its tree but with the acked-by from the driver's maintainer. So the header must contains the name of the maintainer.

Shouldn't MAINTAINERS contain the driver maintainers too?

Quoted 33 lines

This organization will be the same than cpufreq.

---
 MAINTAINERS                        |    7 +++++++
 drivers/cpuidle/cpuidle-calxeda.c  |    4 +++-
 drivers/cpuidle/cpuidle-kirkwood.c |    5 +++--
 3 files changed, 13 insertions(+), 3 deletions(-)
MAINTAINERS +7 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:	Maintained
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
+CPUIDLE DRIVERS
+M:	Rafael J. Wysocki <[email protected]>
+L:	linux-pm at vger.kernel.org
+S:	Maintained
+F:	drivers/cpuidle/*
+F:	include/linux/cpuidle.h
+
 CPU FREQUENCY DRIVERS - ARM BIG LITTLE
 M:	Viresh Kumar <[email protected]>
 M:	Sudeep KarkadaNagesha <[email protected]>
drivers/cpuidle/cpuidle-calxeda.c +0 -0
index e344b56..2378c39 100644

drivers/cpuidle/cpuidle-calxeda.c line 4

Quoted 4 lines
drivers/cpuidle/cpuidle-calxeda.c +0 -1
@@ -1,7 +1,6 @@
 /*
  * Copyright 2012 Calxeda, Inc.
  *
- * Based on arch/arm/plat-mxc/cpuidle.c:

This file may have moved, but it existed at the time this was committed. So the comment still applies and documents what part of the file the FSL and Linaro copyright applies to.

Of course most of what was copied here was the boilerplate which your patch series removes. The heart of the functionality was developed by me.

drivers/cpuidle/cpuidle-calxeda.c line 20

Quoted 10 lines
drivers/cpuidle/cpuidle-calxeda.c +3 -0
  * Copyright 2012 Freescale Semiconductor, Inc.
  * Copyright 2012 Linaro Ltd.
  *
@@ -16,6 +15,9 @@
  *
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author    : Rob Herring <[email protected]>
+ * Maintainer: Rob Herring <[email protected]>

As mentioned above, this doesn't seem right.

Rob

Quoted 25 lines
drivers/cpuidle/cpuidle-calxeda.c +0 -0
  */
 
 #include <linux/cpuidle.h>
drivers/cpuidle/cpuidle-kirkwood.c +3 -2
index 53290e1..521b0a7 100644
@@ -1,6 +1,4 @@
 /*
- * arch/arm/mach-kirkwood/cpuidle.c
- *
  * CPU idle Marvell Kirkwood SoCs
  *
  * This file is licensed under the terms of the GNU General Public
@@ -11,6 +9,9 @@
  * to implement two idle states -
  * #1 wait-for-interrupt
  * #2 wait-for-interrupt and DDR self refresh
+ *
+ * Maintainer: Jason Cooper <[email protected]>
+ * Maintainer: Andrew Lunn <[email protected]>
  */
 
 #include <linux/kernel.h>
#9 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 14 lines · Rob Herring
Quoted 13 lines · Daniel Lezcano

Currently the cpuidle drivers are spread across the different archs.

The patch submission for cpuidle are following different path: the cpuidle core code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific tree, sh goes through sh arch tree, pseries goes through PowerPC and finally intel goes through Len's tree while acpi_idle goes under linux-pm.

That makes difficult to consolidate the code and to propagate modifications from the cpuidle core to the different drivers.

Hopefully, a movement has initiated to put the cpuidle drivers into the drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c

Quoted 8 lines
Quoted 6 lines

Add an explicit maintainer entry in the MAINTAINER to clarify the situation and prevent new cpuidle drivers to goes to an arch directory.

The upstreaming process is unchanged: Rafael takes the patches to merge them into its tree but with the acked-by from the driver's maintainer. So the header must contains the name of the maintainer.

Shouldn't MAINTAINERS contain the driver maintainers too?

It should contains the upstream maintainer for the subsystem, and optionally a co-maintainer.

The MAINTAINERS file gives informations about the patch submission path.

The file's header should contain the maintainer of the driver, so the submitted patches will go to the subsystem maintainer for upstreaming and to the driver maintainer for acked-by.

If you add an entry in MAINTAINERS like:

ARM/CALXEDA HIGHBANK ARCHITECTURE

M:      Rob Herring <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-highbank/

+F: drivers/cpuidle/cpuidle-calxeda.c

That will add confusion while we are trying to clarify the situation with a single entry point for the patches submission. If someone wants to submit a patch for this driver, it will look at the MAINTAINERS file and won't know if it should send the patch against arm-soc or linux-pm.

At some exceptions, this is how is organized the different drivers, for cpufreq, clocksource, ...

Quoted 32 lines
Quoted 32 lines

This organization will be the same than cpufreq.

---
 MAINTAINERS                        |    7 +++++++
 drivers/cpuidle/cpuidle-calxeda.c  |    4 +++-
 drivers/cpuidle/cpuidle-kirkwood.c |    5 +++--
 3 files changed, 13 insertions(+), 3 deletions(-)
MAINTAINERS +7 -0
index 61677c3..effa0f3 100644
@@ -2206,6 +2206,13 @@ S:	Maintained
 F:	drivers/cpufreq/
 F:	include/linux/cpufreq.h
 
+CPUIDLE DRIVERS
+M:	Rafael J. Wysocki <[email protected]>
+L:	linux-pm at vger.kernel.org
+S:	Maintained
+F:	drivers/cpuidle/*
+F:	include/linux/cpuidle.h
+
 CPU FREQUENCY DRIVERS - ARM BIG LITTLE
 M:	Viresh Kumar <[email protected]>
 M:	Sudeep KarkadaNagesha <[email protected]>
drivers/cpuidle/cpuidle-calxeda.c +0 -0
index e344b56..2378c39 100644
@@ -1,7 +1,6 @@
Quoted 8 lines

drivers/cpuidle/cpuidle-calxeda.c line 4

Quoted 4 lines
drivers/cpuidle/cpuidle-calxeda.c +0 -1
 /*
  * Copyright 2012 Calxeda, Inc.
  *
- * Based on arch/arm/plat-mxc/cpuidle.c:

This file may have moved, but it existed at the time this was committed. So the comment still applies and documents what part of the file the FSL and Linaro copyright applies to.

Ok. As this file moved to arch/arm/mach-imx and changed a lot, may be we can add the tag #v3.7 in the comment...

Quoted 15 lines

Of course most of what was copied here was the boilerplate which your patch series removes. The heart of the functionality was developed by me.

drivers/cpuidle/cpuidle-calxeda.c line 20

Quoted 10 lines
drivers/cpuidle/cpuidle-calxeda.c +3 -0
  * Copyright 2012 Freescale Semiconductor, Inc.
  * Copyright 2012 Linaro Ltd.
  *
@@ -16,6 +15,9 @@
  *
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author    : Rob Herring <[email protected]>
+ * Maintainer: Rob Herring <[email protected]>

As mentioned above, this doesn't seem right.

It is based on Robert Lee's cpuidle driver for imx, but you wrote this driver, no ?

If I refer to commit be6a98d3f00c292d347465d96acbec9d8c2783cf, you are author of this driver. Suffice to say the driver was initially based on imx, which is the case in the top of the header.

I suggest to keep the Author and the Maintainer because if, in the future, you don't want to maintain anymore the driver and someone wants to know the initial author of the driver for any reasons, he can check that in the file header without archaeological digs in the git history.

-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#10 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 20 lines · Daniel Lezcano
Quoted 1 line · Rob Herring

Shouldn't MAINTAINERS contain the driver maintainers too?

It should contains the upstream maintainer for the subsystem, and optionally a co-maintainer.

The MAINTAINERS file gives informations about the patch submission path.

The file's header should contain the maintainer of the driver, so the submitted patches will go to the subsystem maintainer for upstreaming and to the driver maintainer for acked-by.

If you add an entry in MAINTAINERS like:

ARM/CALXEDA HIGHBANK ARCHITECTURE

M:      Rob Herring <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-highbank/
Quoted 6 lines

+F: drivers/cpuidle/cpuidle-calxeda.c

That will add confusion while we are trying to clarify the situation with a single entry point for the patches submission. If someone wants to submit a patch for this driver, it will look at the MAINTAINERS file and won't know if it should send the patch against arm-soc or linux-pm.

I though otherwise. We can add entry in MAINTAINERS for any module. Module can be a framework/architecture or a single driver.

Adding entry for cpuidle driver of a architecture as you wrote for calxeda is wrong as it adds to confusion and so there should be a separate entry for this driver rather than merging it with arch/ entries.

#11 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 23 lines · Viresh Kumar
Quoted 22 lines · Daniel Lezcano
Quoted 1 line · Rob Herring

Shouldn't MAINTAINERS contain the driver maintainers too?

It should contains the upstream maintainer for the subsystem, and optionally a co-maintainer.

The MAINTAINERS file gives informations about the patch submission path.

The file's header should contain the maintainer of the driver, so the submitted patches will go to the subsystem maintainer for upstreaming and to the driver maintainer for acked-by.

If you add an entry in MAINTAINERS like:

ARM/CALXEDA HIGHBANK ARCHITECTURE

M:      Rob Herring <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-highbank/

+F: drivers/cpuidle/cpuidle-calxeda.c

Quoted 7 lines
Quoted 4 lines

That will add confusion while we are trying to clarify the situation with a single entry point for the patches submission. If someone wants to submit a patch for this driver, it will look at the MAINTAINERS file and won't know if it should send the patch against arm-soc or linux-pm.

I though otherwise. We can add entry in MAINTAINERS for any module. Module can be a framework/architecture or a single driver.

IMO, there are too much drivers for that. It is simpler for someone to read the MAINTAINERS file to find the cpuidle drivers goes through linux-pm. I think we can trust Rafael to ask for the acked-by from the maintainer of the driver before taking the patches.

Quoted 3 lines

Adding entry for cpuidle driver of a architecture as you wrote for calxeda is wrong as it adds to confusion and so there should be a separate entry for this driver rather than merging it with arch/ entries.

Yes, actually it was an example to show the confusion we could be facing.

Thanks
-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#12 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 29 lines · Daniel Lezcano
Quoted 28 lines · Viresh Kumar
Quoted 26 lines · Daniel Lezcano
Quoted 1 line · Rob Herring

Shouldn't MAINTAINERS contain the driver maintainers too?

It should contains the upstream maintainer for the subsystem, and optionally a co-maintainer.

The MAINTAINERS file gives informations about the patch submission path.

The file's header should contain the maintainer of the driver, so the submitted patches will go to the subsystem maintainer for upstreaming and to the driver maintainer for acked-by.

If you add an entry in MAINTAINERS like:

ARM/CALXEDA HIGHBANK ARCHITECTURE

M:      Rob Herring <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-highbank/

+F: drivers/cpuidle/cpuidle-calxeda.c

That will add confusion while we are trying to clarify the situation with a single entry point for the patches submission. If someone wants to submit a patch for this driver, it will look at the MAINTAINERS file and won't know if it should send the patch against arm-soc or linux-pm.

Quoted 7 lines
Quoted 2 lines

I though otherwise. We can add entry in MAINTAINERS for any module. Module can be a framework/architecture or a single driver.

IMO, there are too much drivers for that. It is simpler for someone to read the MAINTAINERS file to find the cpuidle drivers goes through linux-pm. I think we can trust Rafael to ask for the acked-by from the maintainer of the driver before taking the patches.

It not a maintainer's job to solicit acks. It is the submitter's job to Cc the correct people. The maintainer should only check for necessary CC/acks and bitch at the submitter if they did not use get_maintainers.pl.

Perhaps the MAINTAINERS file needs to be distributed to scale better or we need a way to put the maintainer data into the source and be usable by get_maintainers.pl.

Quoted 5 lines
Quoted 3 lines

Adding entry for cpuidle driver of a architecture as you wrote for calxeda is wrong as it adds to confusion and so there should be a separate entry for this driver rather than merging it with arch/ entries.

Yes, actually it was an example to show the confusion we could be facing.

I'm confused about what is the confusion...

Rob

#13 lore raw

PATCH 1/1 cpuidle: add maintainer entry

Quoted 39 lines · Rob Herring
Quoted 29 lines · Daniel Lezcano
Quoted 28 lines · Viresh Kumar
Quoted 26 lines · Daniel Lezcano
Quoted 1 line · Rob Herring

Shouldn't MAINTAINERS contain the driver maintainers too?

It should contains the upstream maintainer for the subsystem, and optionally a co-maintainer.

The MAINTAINERS file gives informations about the patch submission path.

The file's header should contain the maintainer of the driver, so the submitted patches will go to the subsystem maintainer for upstreaming and to the driver maintainer for acked-by.

If you add an entry in MAINTAINERS like:

ARM/CALXEDA HIGHBANK ARCHITECTURE

M:      Rob Herring <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-highbank/

+F: drivers/cpuidle/cpuidle-calxeda.c

That will add confusion while we are trying to clarify the situation with a single entry point for the patches submission. If someone wants to submit a patch for this driver, it will look at the MAINTAINERS file and won't know if it should send the patch against arm-soc or linux-pm.

Quoted 7 lines
Quoted 2 lines

I though otherwise. We can add entry in MAINTAINERS for any module. Module can be a framework/architecture or a single driver.

IMO, there are too much drivers for that. It is simpler for someone to read the MAINTAINERS file to find the cpuidle drivers goes through linux-pm. I think we can trust Rafael to ask for the acked-by from the maintainer of the driver before taking the patches.

Quoted 4 lines

It not a maintainer's job to solicit acks. It is the submitter's job to Cc the correct people. The maintainer should only check for necessary CC/acks and bitch at the submitter if they did not use get_maintainers.pl.

Ok, I was saying exactly the same, but it was misphrased.
I meant, we can be confident Rafael won't accept patches if they are not acked by the correct people.

Quoted 3 lines

Perhaps the MAINTAINERS file needs to be distributed to scale better or we need a way to put the maintainer data into the source and be usable by get_maintainers.pl.

Yep, the latter could be a good idea.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Adding entry for cpuidle driver of a architecture as you wrote for calxeda is wrong as it adds to confusion and so there should be a separate entry for this driver rather than merging it with arch/ entries.

Yes, actually it was an example to show the confusion we could be facing.

I'm confused about what is the confusion...

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog