Skip to contentSkip to conversation

cgroup: restore the call to eventfd->poll()

PATCH Applied Li Zefan 2 participants 2 messages Apr 26, 2013 cgroup

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 cgroup: restore the call to eventfd->poll()

I mistakenly removed the call to eventfd->poll() while I was actually intending to remove the return value...

Calling evenfd->poll() will hook cgroup_event_wake() to the poll waitqueue, which will be called to unregister eventfd when rmdir a cgroup or close eventfd.

---
 kernel/cgroup.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/cgroup.c +2 -0
index a45aa12..4b0f2ef 100644
@@ -3882,6 +3882,8 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
 	if (ret)
 		goto fail;
 
+	efile->f_op->poll(efile, &event->pt);
+
 	/*
 	 * Events should be removed after rmdir of cgroup directory, but before
 	 * destroying subsystem state objects. Let's take reference to cgroup
Signature · 1 line
1.8.0.2
maintainer Applied
#1 lore raw
Quoted 8 lines · Li Zefan

I mistakenly removed the call to eventfd->poll() while I was actually intending to remove the return value...

Calling evenfd->poll() will hook cgroup_event_wake() to the poll waitqueue, which will be called to unregister eventfd when rmdir a cgroup or close eventfd.

Applied to cgroup/for-3.10. It'd have been better if the patch description pointed to the specific commit which caused the problem.

Thanks.

Signature · 1 line
tejun