OKI ML86V7667 driver and R8A7778/BOCK-W VIN support
Subsystems (5)
v3 cover OKI ML86V7667 driver and R8A7778/BOCK-W VIN support
Hello.
Here's the set of 5 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130422' tag and my recent yet unapplied patches. Here we add the OKI ML86V7667 video decoder driver and the VIN platform code working on the R8A7778/BOCK-W with ML86V7667. The driver patch also applies (with offsets) to Mauro's 'media_tree.git'...
[1/5] V4L2: I2C: ML86V7667 video decoder driver
[2/5] sh-pfc: r8a7778: add VIN pin groups
[3/5] ARM: shmobile: r8a7778: add VIN support
[4/5] ARM: shmobile: BOCK-W: add VIN and ML86V7667 support [5/5] ARM: shmobile: BOCK-W: enable VIN and ML86V7667 in defconfig
WBR, Sergei
PATCH v3 1/5 V4L2: I2C: ML86V7667 video decoder driver
From: Vladimir Barinov <[email protected]>
Add OKI Semiconductor ML86V7667 video decoder driver.
[Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of ml86v7667_probe(); some cleanup.]
---
Changes since version 2:
- removed now unused #include;
- fixed querystd() method to return currently detected video standard;
- switched from using V4L2_STD_[PAL|NTSC] to using V4L2_STD_[625_50|525_60].
Changes since the original posting:
- fixed ACCC_CHROMA_CB_MASK;
- got rid of the autodetection feature;
- removed querystd() method calls from other methods;
- removed deprecated g_chip_ident() method.
drivers/media/i2c/Kconfig | 9 drivers/media/i2c/Makefile | 1 drivers/media/i2c/ml86v7667.c | 480 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 490 insertions(+)
drivers/media/i2c/Kconfig +9 -0
@@ -227,6 +227,15 @@ config VIDEO_KS0127 To compile this driver as a module, choose M here: the module will be called ks0127. +config VIDEO_ML86V7667 + tristate "OKI ML86V7667 video decoder" + depends on VIDEO_V4L2 && I2C + ---help--- + Support for the OKI Semiconductor ML86V7667 video decoder. + + To compile this driver as a module, choose M here: the + module will be called ml86v7667. + config VIDEO_SAA7110 tristate "Philips SAA7110 video decoder" depends on VIDEO_V4L2 && I2C
drivers/media/i2c/Makefile +1 -0
@@ -64,3 +64,4 @@ obj-$(CONFIG_VIDEO_AS3645A) += as3645a.o obj-$(CONFIG_VIDEO_SMIAPP_PLL) += smiapp-pll.o obj-$(CONFIG_VIDEO_AK881X) += ak881x.o obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o +obj-$(CONFIG_VIDEO_ML86V7667) += ml86v7667.o
drivers/media/i2c/ml86v7667.c new file +480 -0
480 lines not on this page · raw message
PATCH v3 3/5 ARM: shmobile: r8a7778: add VIN support
In reply to Sergei ShtylyovFrom: Vladimir Barinov <[email protected]>
Add VIN clocks and platform devices on R8A7778 SoC; add function to register the VIN platform devices.
[Sergei: added 'id' parameter check to r8a7779_add_vin_device(), used '*pdata' in *sizeof* operator there, renamed some variables, annotated 'vin[01]_info' and vin[01]_resources[] as '__initdata'.]
---
Changes from version 2:
- annotated 'vin[01]_info' and vin[01]_resources[] as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- refreshed the patch.
arch/arm/mach-shmobile/clock-r8a7778.c | 5 +++ arch/arm/mach-shmobile/include/mach/r8a7778.h | 3 ++ arch/arm/mach-shmobile/setup-r8a7778.c | 33 ++++++++++++++++++++++++++ 3 files changed, 41 insertions(+)
arch/arm/mach-shmobile/clock-r8a7778.c +5 -0
@@ -106,6 +106,7 @@ static struct clk *main_clks[] = {enum {MSTP323 ,MSTP322 ,MSTP321 ,MSTP114 , +MSTP110 ,MSTP109 ,MSTP100 ,MSTP030 ,MSTP029 ,MSTP028 ,MSTP027 ,MSTP026 ,MSTP025 ,MSTP024 ,MSTP023 ,MSTP022 ,MSTP021 ,
@@ -117,6 +118,8 @@ static struct clk mstp_clks[MSTP_NR] = { [MSTP322] = SH_CLK_MSTP32(&p_clk, MSTPCR3, 22, 0), /* SDHI1 */ [MSTP321] = SH_CLK_MSTP32(&p_clk, MSTPCR3, 21, 0), /* SDHI2 */ [MSTP114] = SH_CLK_MSTP32(&p_clk, MSTPCR1, 14, 0), /* Ether */ + [MSTP110] = SH_CLK_MSTP32(&s_clk, MSTPCR1, 10, 0), /* VIN0 */ + [MSTP109] = SH_CLK_MSTP32(&s_clk, MSTPCR1, 9, 0), /* VIN1 */ [MSTP100] = SH_CLK_MSTP32(&p_clk, MSTPCR1, 0, 0), /* USB0/1 */ [MSTP030] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 30, 0), /* I2C0 */ [MSTP029] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 29, 0), /* I2C1 */
@@ -140,6 +143,8 @@ static struct clk_lookup lookups[] = {CLKDEV_DEV_ID ("sh_mobile_sdhi.1" , &mstp_clks[MSTP322 ]),/* SDHI1 */ CLKDEV_DEV_ID ("sh_mobile_sdhi.2" , &mstp_clks[MSTP321 ]),/* SDHI2 */ CLKDEV_DEV_ID ("sh-eth" , &mstp_clks[MSTP114 ]),/* Ether */ +CLKDEV_DEV_ID ("rcar_vin.0" , &mstp_clks[MSTP110 ]),/* VIN0 */ +CLKDEV_DEV_ID ("rcar_vin.1" , &mstp_clks[MSTP109 ]),/* VIN1 */ CLKDEV_DEV_ID ("ehci-platform" , &mstp_clks[MSTP100 ]),/* USB EHCI port0/1 */ CLKDEV_DEV_ID ("ohci-platform" , &mstp_clks[MSTP100 ]),/* USB OHCI port0/1 */ CLKDEV_DEV_ID("i2c-rcar.0", &mstp_clks[MSTP030]), /* I2C0 */
arch/arm/mach-shmobile/include/mach/r8a7778.h +3 -0
@@ -21,11 +21,14 @@#include <linux/mmc/sh_mobile_sdhi.h> #include <linux/sh_eth.h> #include <linux/usb/rcar-phy.h> +#include <linux/platform_data/camera-rcar.h> extern void r8a7778_add_standard_devices (void );extern void r8a7778_add_standard_devices_dt (void );extern void r8a7778_add_ether_device (struct sh_eth_plat_data *pdata);extern void r8a7778_add_usb_phy_device (struct rcar_phy_platform_data *pdata); +extern void r8a7778_add_vin_device (int id, +struct rcar_vin_platform_data *pdata);extern void r8a7778_init_late (void );extern void r8a7778_init_delay (void );extern void r8a7778_init_irq (void );
arch/arm/mach-shmobile/setup-r8a7778.c +33 -0
@@ -299,6 +299,39 @@ void __init r8a7778_sdhi_init(int id, info, sizeof(*info)); } +/* VIN */ +#define R8A7778_VIN (idx) \ +static struct resource vin##idx##_resources[] __initdata = { \ + DEFINE_RES_MEM(0xffc50000 + 0x1000 * (idx), 0x1000), \ + DEFINE_RES_IRQ(gic_iid(0x5a)), \ +}; \ + \ +static struct platform_device_info vin##idx##_info __initdata = { \ + .parent = &platform_bus, \ + .name = "rcar_vin", \ + .id = idx, \ + .res = vin##idx##_resources, \ + .num_res = ARRAY_SIZE(vin##idx##_resources), \ + .dma_mask = DMA_BIT_MASK(32), \ +} + +R8A7778_VIN (0 ); +R8A7778_VIN (1 ); + +static struct platform_device_info *vin_info_table[]__initdata = { + &vin0_info, + &vin1_info, +}; + +void __init r8a7778_add_vin_device (int id,struct rcar_vin_platform_data *pdata) +{ +BUG_ON (id <0 || id >1 ); + + vin_info_table[id]->data = pdata; + vin_info_table[id]->size_data =sizeof (*pdata); +platform_device_register_full (vin_info_table[id]); +} +void __init r8a7778_add_standard_devices (void ) {int i;
PATCH v3 4/5 ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
In reply to Sergei ShtylyovFrom: Vladimir Barinov <[email protected]>
Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data.
[Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated all platform data as '__initdata'.]
---
Changes since version 2:
- removed duplicate #include <linux/pinctrl/machine.h>;
- annotated all platform data as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- resolved rejects, refreshed the patch.
arch/arm/mach-shmobile/board-bockw.c | 39 +++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
arch/arm/mach-shmobile/board-bockw.c +39 -0
@@ -3,6 +3,7 @@* * Copyright (C) 2013 Renesas Solutions Corp. * Copyright (C) 2013 Kuninori Morimoto <[email protected]> +* Copyright (C) 2013 Cogent Embedded, Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
@@ -25,6 +26,7 @@#include <linux/regulator/fixed.h> #include <linux/regulator/machine.h> #include <linux/smsc911x.h> +#include <media/soc_camera.h> #include <mach/common.h> #include <mach/irqs.h> #include <mach/r8a7778.h>
@@ -65,6 +67,25 @@ static struct sh_mobile_sdhi_info sdhi0_static struct rcar_phy_platform_data usb_phy_platform_data__initdata ; +static struct rcar_vin_platform_data vin_platform_data__initdata = { + .flags =RCAR_VIN_BT656 , +}; + +/* In the default configuration both decoders reside on I2C bus 0 */ +#define BOCKW_CAMERA (idx) \ +static struct i2c_board_info camera##idx##_info = { \ + I2C_BOARD_INFO("ml86v7667", 0x41 + 2 * (idx)), \ +}; \ + \ +static struct soc_camera_link iclink##idx##_ml86v7667 __initdata = { \ + .bus_id = idx, \ + .i2c_adapter_id = 0, \ + .board_info = &camera##idx##_info, \ +}; + +BOCKW_CAMERA (0 ); +BOCKW_CAMERA (1 ); +static const struct pinctrl_map bockw_pinctrl_map[] = {/* SCIF0 */ PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
@@ -80,6 +101,16 @@ static const struct pinctrl_map bockw_pi "sdhi0_data4", "sdhi0"),PIN_MAP_MUX_GROUP_DEFAULT ("sh_mobile_sdhi.0" ,"pfc-r8a7778" ,"sdhi0_wp" ,"sdhi0" ), +/* VIN0 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_clk" ,"vin0" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_data8" ,"vin0" ), +/* VIN1 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , +"vin1_clk" ,"vin1" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , + "vin1_data8", "vin1"), };#define FPGA 0x18200000
@@ -94,6 +125,14 @@ static void __init bockw_init(void)r8a7778_init_irq_extpin (1 );r8a7778_add_standard_devices ();r8a7778_add_usb_phy_device (&usb_phy_platform_data); +r8a7778_add_vin_device (0 , &vin_platform_data); +r8a7778_add_vin_device (1 , &vin_platform_data); +platform_device_register_data (&platform_bus,"soc-camera-pdrv" ,0 , + &iclink0_ml86v7667, +sizeof (iclink0_ml86v7667)); +platform_device_register_data (&platform_bus,"soc-camera-pdrv" ,1 , + &iclink1_ml86v7667, +sizeof (iclink1_ml86v7667));pinctrl_register_mappings (bockw_pinctrl_map,ARRAY_SIZE (bockw_pinctrl_map));
PATCH v3 4/5 ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
Hello.
Quoted 24 lines · Sergei Shtylyov
From: Vladimir Barinov <[email protected]>
Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data.
Signed-off-by Vladimir Barinov <[email protected]>[Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated all platform data as '
__initdata'.]Signed-off-by Sergei Shtylyov <[email protected]>---
Changes since version 2:
- removed duplicate #include <linux/pinctrl/machine.h>;
- annotated all platform data as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- resolved rejects, refreshed the patch.arch/arm/mach-shmobile/board-bockw.c | 39 +++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)Index:
renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================arch/arm/mach-shmobile/board-bockw.c +0
-0
[...]
Quoted 5 lines
arch/arm/mach-shmobile/board-bockw.c +1
-0@@ -80,6 +101,16 @@ static const struct pinctrl_map bockw_pi "sdhi0_data4", "sdhi0"),PIN_MAP_MUX_GROUP_DEFAULT ("sh_mobile_sdhi.0" ,"pfc-r8a7778" , "sdhi0_wp", "sdhi0"), +/* VIN0 */
arch/arm/mach-shmobile/board-bockw.c static const struct pinctrl_map bockw_pi · line 114
Quoted 10 lines
arch/arm/mach-shmobile/board-bockw.c +9
-0+PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_clk" ,"vin0" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_data8" ,"vin0" ), +/* VIN1 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , +"vin1_clk" ,"vin1" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , + "vin1_data8", "vin1"), };
It turned out that VIN1 signal VI1_CLK conflicts with Ether signalETH_REF_CLK.
So I'm a bit at a loss here: whether I should totally remove VIN1 device if I'm going
to add Ether device, or add a BOCK-W specific submenu to Kconfig, or add driver
specific #ifdef's in the code to disable VIN1 if sh_eth driver is enabled?...
WBR, Sergei
PATCH v3 4/5 ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
Quoted 47 lines · Sergei Shtylyov
Hello.
Quoted 24 lines · Sergei Shtylyov
From: Vladimir Barinov <[email protected]>
Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data.
Signed-off-by Vladimir Barinov <[email protected]>[Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated all platform data as '
__initdata'.]Signed-off-by Sergei Shtylyov <[email protected]>---
Changes since version 2:
- removed duplicate #include <linux/pinctrl/machine.h>;
- annotated all platform data as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- resolved rejects, refreshed the patch.arch/arm/mach-shmobile/board-bockw.c | 39 +++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)Index:
renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================arch/arm/mach-shmobile/board-bockw.c +0
-0[...]
Quoted 5 lines
arch/arm/mach-shmobile/board-bockw.c +1
-0@@ -80,6 +101,16 @@ static const struct pinctrl_map bockw_pi "sdhi0_data4", "sdhi0"),PIN_MAP_MUX_GROUP_DEFAULT ("sh_mobile_sdhi.0" ,"pfc-r8a7778" , "sdhi0_wp", "sdhi0"), +/* VIN0 */ arch/arm/mach-shmobile/board-bockw.c static const struct pinctrl_map bockw_pi · line 114
Quoted 10 lines
arch/arm/mach-shmobile/board-bockw.c +9
-0+PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_clk" ,"vin0" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_data8" ,"vin0" ), +/* VIN1 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , +"vin1_clk" ,"vin1" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , + "vin1_data8", "vin1"), };
Quoted 8 lines
It turned out that VIN1 signal
VI1_CLKconflicts with Ether
signalETH_REF_CLK.
So I'm a bit at a loss here: whether I should totally remove VIN1 device if I'm going
to add Ether device, or add a BOCK-W specific submenu toKconfig, or add driver
specific #ifdef's in the code to disable VIN1 ifsh_ethdriver is enabled?...
My preference, in order is:
* Remove VIN1 (is it used?)
* Kconfig-foo
* #ifdef nastiness
PATCH v3 4/5 ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
Hello.
Quoted 54 lines · Simon Horman
Quoted 45 lines · Sergei Shtylyov
Quoted 25 lines
From: Vladimir Barinov <[email protected]>
Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data.
Signed-off-by Vladimir Barinov <[email protected]>[Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated all platform data as '
__initdata'.]Signed-off-by Sergei Shtylyov <[email protected]>---
Changes since version 2:
- removed duplicate #include <linux/pinctrl/machine.h>;
- annotated all platform data as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- resolved rejects, refreshed the patch.arch/arm/mach-shmobile/board-bockw.c | 39 +++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)Index:
renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================arch/arm/mach-shmobile/board-bockw.c +0
-0[...]
Quoted 5 lines
arch/arm/mach-shmobile/board-bockw.c +1
-0@@ -80,6 +101,16 @@ static const struct pinctrl_map bockw_pi "sdhi0_data4", "sdhi0"),PIN_MAP_MUX_GROUP_DEFAULT ("sh_mobile_sdhi.0" ,"pfc-r8a7778" , "sdhi0_wp", "sdhi0"), +/* VIN0 */ arch/arm/mach-shmobile/board-bockw.c static const struct pinctrl_map bockw_pi · line 114
Quoted 10 lines
arch/arm/mach-shmobile/board-bockw.c +9
-0+PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_clk" ,"vin0" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_data8" ,"vin0" ), +/* VIN1 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , +"vin1_clk" ,"vin1" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , + "vin1_data8", "vin1"), };Quoted 8 lines
It turned out that VIN1 signal
VI1_CLKconflicts with Ether
signalETH_REF_CLK.
So I'm a bit at a loss here: whether I should totally remove VIN1 device if I'm going
to add Ether device, or add a BOCK-W specific submenu toKconfig, or add driver
specific #ifdef's in the code to disable VIN1 ifsh_ethdriver is enabled?...
Quoted 3 lines
My preference, in order is:
* Remove VIN1 (is it used?)
At least video decoders are connected to both VIN0 and VIN1.
Quoted 2 lines
* Kconfig-foo
* #ifdef nastiness
I took the 3rd approach but luckily it was possible without #ifdef, using
*if* (!IS_ENABLED(CONFIG_SH_ETH)) statement. Working patch posted on Monday.
WBR, Sergei
PATCH v3 4/5 ARM: shmobile: BOCK-W: add VIN and ML86V7667 support
Quoted 62 lines · Sergei Shtylyov
Hello.
Quoted 54 lines · Simon Horman
Quoted 45 lines · Sergei Shtylyov
Quoted 25 lines
From: Vladimir Barinov <[email protected]>
Add ML86V7667 platform devices on BOCK-W board, configure VIN0/1 pins, and register VIN0/1 devices with the ML86V7667 specific platform data.
Signed-off-by Vladimir Barinov <[email protected]>[Sergei: some macro/comment cleanup; updated the copyrights, removed duplicate #include, annotated all platform data as '
__initdata'.]Signed-off-by Sergei Shtylyov <[email protected]>---
Changes since version 2:
- removed duplicate #include <linux/pinctrl/machine.h>;
- annotated all platform data as '__initdata' since they're kmemdup()'ed while registering the platform devices anyway;
- resolved rejects, refreshed the patch.arch/arm/mach-shmobile/board-bockw.c | 39 +++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)Index:
renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================arch/arm/mach-shmobile/board-bockw.c +0
-0[...]
Quoted 5 lines
arch/arm/mach-shmobile/board-bockw.c +1
-0@@ -80,6 +101,16 @@ static const struct pinctrl_map bockw_pi "sdhi0_data4", "sdhi0"),PIN_MAP_MUX_GROUP_DEFAULT ("sh_mobile_sdhi.0" ,"pfc-r8a7778" , "sdhi0_wp", "sdhi0"), +/* VIN0 */ arch/arm/mach-shmobile/board-bockw.c static const struct pinctrl_map bockw_pi · line 114
Quoted 10 lines
arch/arm/mach-shmobile/board-bockw.c +9
-0+PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_clk" ,"vin0" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.0" ,"pfc-r8a7778" , +"vin0_data8" ,"vin0" ), +/* VIN1 */ +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , +"vin1_clk" ,"vin1" ), +PIN_MAP_MUX_GROUP_DEFAULT ("rcar_vin.1" ,"pfc-r8a7778" , + "vin1_data8", "vin1"), };Quoted 8 lines
It turned out that VIN1 signal
VI1_CLKconflicts with Ether
signalETH_REF_CLK.
So I'm a bit at a loss here: whether I should totally remove VIN1 device if I'm going
to add Ether device, or add a BOCK-W specific submenu toKconfig, or add driver
specific #ifdef's in the code to disable VIN1 ifsh_ethdriver is enabled?...Quoted 3 lines
My preference, in order is:
* Remove VIN1 (is it used?)
Quoted 8 lines
At least video decoders are connected to both VIN0 and VIN1.
Quoted 2 lines
* Kconfig-foo
* #ifdef nastinessI took the 3rd approach but luckily it was possible without
#ifdef, using *if* (!IS_ENABLED(CONFIG_SH_ETH)) statement. Working patch posted on Monday.
Thanks.
PATCH v3 5/5 ARM: shmobile: BOCK-W: enable VIN and ML86V7667 in defconfig
In reply to Sergei ShtylyovFrom: Vladimir Barinov <[email protected]>
Add the VIN and ML86V7667 drivers to 'bockw_defconfig'.
--- arch/arm/configs/bockw_defconfig | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/configs/bockw_defconfig +7 -0
@@ -76,6 +76,13 @@ CONFIG_SERIAL_SH_SCI_CONSOLE=y # CONFIG_HWMON is not set CONFIG_I2C=y CONFIG_I2C_RCAR=y +CONFIG_MEDIA_SUPPORT=y +CONFIG_MEDIA_CAMERA_SUPPORT=y +CONFIG_V4L_PLATFORM_DRIVERS=y +CONFIG_SOC_CAMERA=y +CONFIG_VIDEO_RCAR_VIN=y +# CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set +CONFIG_VIDEO_ML86V7667=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_EHCI_HCD=y