Array subscript above array bounds warning
Could someone clarify for me what I am missing here?
in drivers/net/ethernet/via/velocity.h is the following definition:
struct mac_regs {
volatile u8 PAR[6]; /* 0x00 */
...
}
I am trying to add the following function but it keeps giving array bounds warnings:
static void velocity_set_power_state(struct velocity_info *vptr, char state) {
struct mac_regs __iomem *regs = vptr->mac_regs;
if (vptr->bustype == BUS_PCI) {pci_set_power_state(vptr->pdev, state);
} else {writeb(state, (®s->PAR[0]) + 0x154);
}
}
gives:
/home/sentient/linux-git/server/arch/arm/include/asm/io.h:83:2: warning:
array subscript is above array bounds [-Warray-bounds]
If I change the function to:
static void velocity_set_power_state(struct velocity_info *vptr, char state) {
void __iomem *addr;
struct mac_regs __iomem *regs = vptr->mac_regs;
if (vptr->bustype == BUS_PCI)pci_set_power_state(vptr->pdev, state);
else {
addr = ®s->PAR[0];writeb(state, addr + 0x154);
}
}
I get the following warning:
drivers/net/ethernet/via/via-velocity.c:99:8: warning: assignment discards ?volatile? qualifier from pointer target type [enabled by default]
What is the correct way to go about this?
Regards
Tony Prisk
El 27/04/13 20:29, Tony Prisk escribi?:
Quoted 18 lines
Could someone clarify for me what I am missing here?
in
drivers/net/ethernet/via/velocity.his the following definition:struct
mac_regs{
volatile u8 PAR[6]; /*0x00*/
...
}I am trying to add the following function but it keeps giving array bounds warnings:
static void
velocity_set_power_state(struct velocity_info *vptr, char state)
{
structmac_regs__iomem*regs =vptr->mac_regs;
Quoted 4 lines
if (
vptr->bustype==BUS_PCI) {pci_set_power_state(vptr->pdev, state);
} else {writeb(state, (®s->PAR[0]) + 0x154);
This would be equivalent to
writeb(state, regs->PAR + 0x154);
or
writeb(state, ®s->PAR[340]);
Which would be out of bounds, right? As it's an u8 array with just 6 elements, not 341+
Quoted 25 lines · Emilio L?pez
El 27/04/13 20:29, Tony Prisk escribi?:
Quoted 18 lines
Could someone clarify for me what I am missing here?
in
drivers/net/ethernet/via/velocity.his the following definition:struct
mac_regs{
volatile u8 PAR[6]; /*0x00*/
...
}I am trying to add the following function but it keeps giving array bounds warnings:
static void
velocity_set_power_state(struct velocity_info *vptr, char state)
{
structmac_regs__iomem*regs =vptr->mac_regs;Quoted 4 lines
if (
vptr->bustype==BUS_PCI) {pci_set_power_state(vptr->pdev, state);
} else {writeb(state, (®s->PAR[0]) + 0x154);This would be equivalent to
Quoted 8 lines
writeb(state, regs->PAR + 0x154);or
writeb(state, ®s->PAR[340]);Which would be out of bounds, right? As it's an u8 array with just 6 elements, not 341+
Yeah sorry - stupid question.
I just thought about the code while out for a walk and realised I should have looked at what the original author was trying to do rather than copy it verbatim.I have solved the issue now.
Regards
Tony P