Skip to contentSkip to conversation

cpuset: fix compile warning when CONFIG_SMP=n

PATCH Applied Li Zefan 3 participants 3 messages Apr 28, 2013 cgroup

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 cpuset: fix compile warning when CONFIG_SMP=n

Reported by Fengguang's kbuild test robot:

kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used

Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b ("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()), which removed generate_sched_domains() from cpuset_hotplug_workfn().

---
 kernel/cpuset.c | 7 -------
 1 file changed, 7 deletions(-)
kernel/cpuset.c +0 -7
index ef05901..2422c5b 100644
@@ -789,13 +789,6 @@ out:
 static void rebuild_sched_domains_locked(void)
 {
 }
-
-static int generate_sched_domains(cpumask_var_t **domains,
-			struct sched_domain_attr **attributes)
-{
-	*domains = NULL;
-	return 1;
-}
 #endif /* CONFIG_SMP */
 
 void rebuild_sched_domains(void)
Signature · 1 line
1.8.0.2
#1 lore raw
Quoted 1 line · Li Zefan

Reported by Fengguang's kbuild test robot:

Thank you for the quick fix, Zefan.

Strong robot :)

Thanks, Zhong

Quoted 31 lines

kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used

Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b ("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()), which removed generate_sched_domains() from cpuset_hotplug_workfn().

---
 kernel/cpuset.c | 7 -------
 1 file changed, 7 deletions(-)
kernel/cpuset.c +0 -7
index ef05901..2422c5b 100644
@@ -789,13 +789,6 @@ out:
 static void rebuild_sched_domains_locked(void)
 {
 }
-
-static int generate_sched_domains(cpumask_var_t **domains,
-			struct sched_domain_attr **attributes)
-{
-	*domains = NULL;
-	return 1;
-}
 #endif /* CONFIG_SMP */
 
 void rebuild_sched_domains(void)
maintainer Applied
#2 lore raw
In reply to Li Zefan
Quoted 10 lines · Li Zefan

Reported by Fengguang's kbuild test robot:

kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used

Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b ("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()), which removed generate_sched_domains() from cpuset_hotplug_workfn().

Applied to cgroup/for-3.10. Thanks.

Signature · 1 line
tejun