Skip to contentSkip to conversation

qdev: Report errors collected during device realization

PATCH Applied Jan Kiszka 3 participants 3 messages Apr 29, 2013 – Apr 30, 2013

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 qdev: Report errors collected during device realization

Better than just releasing the error object silently.

---
 hw/core/qdev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
hw/core/qdev.c +1 -0
index 4eb0134..ab1d8f5 100644
@@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
 
     object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
     if (local_err != NULL) {
+        qerror_report_err(local_err);
         error_free(local_err);
         qdev_free(dev);
         return -1;
Signature · 1 line
1.7.3.4
Reviewed-by on v1 1/1
#1 lore raw

Am 29.04.2013 14:35, schrieb Jan Kiszka:

Quoted 3 lines

Better than just releasing the error object silently.

but CC'ing monitor guys to verify this is the right print function.

Andreas

Quoted 17 lines
---
 hw/core/qdev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
hw/core/qdev.c +1 -0
index 4eb0134..ab1d8f5 100644
@@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
 
     object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
     if (local_err != NULL) {
+        qerror_report_err(local_err);
         error_free(local_err);
         qdev_free(dev);
         return -1;
Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg