Skip to contentSkip to conversation

rtc: rtc-ab3100: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 3, 2013 Real time clock (RTC)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 3/42 rtc: rtc-ab3100: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-ab3100.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-ab3100.c +0 -1
index 47a4f2c..572208d 100644
@@ -242,7 +242,6 @@ static int __init ab3100_rtc_probe(struct platform_device *pdev)
 
 static int __exit ab3100_rtc_remove(struct platform_device *pdev)
 {
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-ab3100.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-ab3100.c +0 -0
index 47a4f2c..572208d 100644

drivers/rtc/rtc-ab3100.c static int __init ab3100_rtc_probe(struct platform_device *pdev) · line 246

Quoted 6 lines
drivers/rtc/rtc-ab3100.c +0 -1
@@ -242,7 +242,6 @@ static int __init ab3100_rtc_probe(struct platform_device *pdev)
 
 static int __exit ab3100_rtc_remove(struct platform_device *pdev)
 {
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }

Since it's empty you can remove the function altogether.

Same comment for all the other patches in this series where the function ends up being empty