mmc: sdhci-acpi: remove unnecessary platform_set_drvdata()
PATCH 15/22 mmc: sdhci-acpi: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/mmc/host/sdhci-acpi.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-acpi.c +0 -2
@@ -211,7 +211,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)return 0 ; err_free: -platform_set_drvdata (pdev,NULL );sdhci_free_host (c->host);return err; }
@@ -230,7 +229,6 @@ static int sdhci_acpi_remove(struct platform_device *pdev) dead = (sdhci_readl (c->host,SDHCI_INT_STATUS ) == ~0 );sdhci_remove_host (c->host, dead); -platform_set_drvdata (pdev,NULL );sdhci_free_host (c->host);return 0 ;
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 25 lines
--- drivers/mmc/host/sdhci-acpi.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-acpi.c +0
-2@@ -211,7 +211,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)return 0 ; err_free: -platform_set_drvdata (pdev,NULL );sdhci_free_host (c->host);return err; }@@ -230,7 +229,6 @@ static int sdhci_acpi_remove(struct platform_device *pdev) dead = (sdhci_readl (c->host,SDHCI_INT_STATUS ) == ~0 );sdhci_remove_host (c->host, dead); -platform_set_drvdata (pdev,NULL );sdhci_free_host (c->host);return 0 ;