net: can: c_can: remove unnecessary platform_set_drvdata()
Subsystems (3)
PATCH 2/36 net: can: c_can: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/net/can/c_can/c_can_platform.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/can/c_can/c_can_platform.c +0 -2
@@ -234,7 +234,6 @@ static int c_can_plat_probe(struct platform_device *pdev)return 0 ; exit_free_device: -platform_set_drvdata (pdev,NULL );free_c_can_dev (dev); exit_iounmap:iounmap (addr);
@@ -255,7 +254,6 @@ static int c_can_plat_remove(struct platform_device *pdev)struct resource *mem;unregister_c_can_dev (dev); -platform_set_drvdata (pdev,NULL );free_c_can_dev (dev);iounmap (priv->base);
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |