Skip to contentSkip to conversation

drivers/media/media-entity.c:477:1-11: second lock on line 479

PATCH Sylwester Nawrocki 1 participant 1 message May 10, 2013 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20130509232644.GI30128@mwanda

Sylwester Nawrocki

author
#1 lore raw
Quoted 3 lines · Dan Carpenter

Hi Sylwester,

FYI, there are coccinelle warnings in

Thanks a lot for this bug report. I've just re-tested the patch and the bug is evident there, looks like it was introduced in a "last minute" changes and the test environment wasn't updated properly. The corrected patch to follow.

Regards,
Sylwester

Quoted 33 lines
tree:   git://linuxtv.org/snawrocki/samsung.git next/exynos-is
head:   90029a2ca496f71ba629ea932ac761e16f4e823b
commit: cae9aa2c7b182d1b687196292059bca2f2cedf0f [3/17] media: Add function removing all media entity links
Quoted 1 line
Quoted 1 line

drivers/media/media-entity.c:477:1-11: second lock on line 479

--

Quoted 1 line
Quoted 1 line

drivers/media/media-entity.c:477:1-11: second lock on line 479

git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git
git remote update linuxtv-samsung
git checkout cae9aa2c7b182d1b687196292059bca2f2cedf0f
vim +477 drivers/media/media-entity.c

cae9aa2c Sylwester Nawrocki 2013-05-08  471  
cae9aa2c Sylwester Nawrocki 2013-05-08  472  void media_entity_remove_links(struct media_entity *entity)
cae9aa2c Sylwester Nawrocki 2013-05-08  473  {
cae9aa2c Sylwester Nawrocki 2013-05-08  474  	if (WARN_ON_ONCE(entity->parent == NULL))
cae9aa2c Sylwester Nawrocki 2013-05-08  475  		return;
cae9aa2c Sylwester Nawrocki 2013-05-08  476  
cae9aa2c Sylwester Nawrocki 2013-05-08 @477  	mutex_lock(&entity->parent->graph_mutex);
cae9aa2c Sylwester Nawrocki 2013-05-08  478  	__media_entity_remove_links(entity);
cae9aa2c Sylwester Nawrocki 2013-05-08 @479  	mutex_lock(&entity->parent->graph_mutex);
cae9aa2c Sylwester Nawrocki 2013-05-08  480  }
cae9aa2c Sylwester Nawrocki 2013-05-08  481  EXPORT_SYMBOL_GPL(media_entity_remove_links);

cae9aa2c Sylwester Nawrocki 2013-05-08 482

---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
[email protected]
https://lists.01.org/mailman/listinfo/kbuild