Skip to contentSkip to conversation

beaglebone: update to linux 3.8

PATCH New Anders Darander 2 participants 4 messages May 11, 2013 – May 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 beaglebone: update to linux 3.8

Hi Arnout,

(Resending as I first sent from an unsubcribed email).

Quoted 9 lines · Arnout Vandecappelle
Quoted 3 lines · Anders Darander

From: Anders Darander <[email protected]>

The kernel config here, is basically the default one from the TI

kernel.

Quoted 1 line

Thus, it's omap2plus_defconfig, which is rather generic.

So why include a config in buildroot? If it's just the defconfig that is already in the kernel tree, you can use it.

Well, the intention was to reduce it in the next patch, just to show how it was derived. Though, I'll squash them in the next revision.

Quoted 11 lines
Quoted 1 line

As the beaglebone support is mainlined, there's no support for the

old

Quoted 1 line

board setup files, and the only supported run-time configuration is

through

Quoted 7 lines

the device tree.

We're also setting the kernel headers to follow the 3.8 series.

---
  board/beaglebone/linux-3.2.9.config |  252
Quoted 6 lines

----------------------------

Quoted 1 line
  board/beaglebone/linux-3.8.config   |  315

+++++++++++++++++++++++++++++++++++

Please create your patches with the -M option to send-email or
format-patch, so that we can actually see the diff crossing the rename.

Hmm, strange, I was using -M, but I might have to tweak the threshold a little bit. I'll look into that for the next revision.

Quoted 10 lines

Otherwise it's pretty hard to review.

Quoted 5 lines
  configs/beaglebone_defconfig        |   22 +--
  3 files changed, 321 insertions(+), 268 deletions(-)

delete mode 100644 board/beaglebone/linux-3.2.9.config create mode 100644 board/beaglebone/linux-3.8.config

[snip]

Review

Quoted 1 line
(quoted diff) +0 -0

b/configs/beaglebone_defconfig

Quoted 14 lines

configs/beaglebone_defconfig line 7

Quoted 12 lines

index 2177068..f80dd79 100644

configs/beaglebone_defconfig +1 -3
@@ -1,24 +1,14 @@
-# architecture
  BR2_arm=y
  BR2_cortex_a8=y
+BR2_KERNEL_HEADERS_3_8=y
  BR2_EXTRA_GCC_CONFIG_OPTIONS="--with-fpu=vfpv3 --with-float=hard"
  # BR2_SOFT_FLOAT is not set
-
-# system

Please don't remove these comments, they're useful. You can selectively

Ok, then I guess that I should keep the old ordering, even though savedefconfig have reordered some of them.?

Quoted 11 lines

undo changes with 'git checkout -p configs/beaglebone_defconfig'.

configs/beaglebone_defconfig line 8

Quoted 3 lines
configs/beaglebone_defconfig +0 -0
  BR2_LINUX_KERNEL=y
  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 

-BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL="git://github.com/koenkooi/linux.git"

Quoted 1 line

-BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="linux-ti33x-psp-3.2-r5a+gitr09e9651bcf2ee8d86685f2a8075bc6557b1d3b91"

Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL="git://

git.ti.com/ti-linux-kernel/ti-linux-kernel.git"

Quoted 5 lines
Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="935f6c2f82056d538b528272e2bdbb5c08d69a58"

Isn't there a tag you can clone from? That's much faster, because then we can (usually) do a shallow clone.

I'm not sure if there's a tag available in this case.

Ok, so tags preferred if they exists... Good to know, I'll check it and change it if there's a tag.

The list few years I've mainly been working with another build system, where SHA1's are preferred over tags for network-less building.

I'll come back with a new series in a couple of days.

Thanks for the feedback!

Cheers,
Anders

Signature · 4 lines
Anders Darander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130511/5d3d6858/attachment.html>
#1 lore raw

PATCH 1/5 beaglebone: update to linux 3.8

Quoted 3 lines · Anders Darander

Hi Arnout,

(Resending as I first sent from an unsubcribed email).

Yeah, the subscribed-only sending can get annoying.

BTW your re-sending lost the in-reply-to headers, which is unfortunate.

Quoted 7 lines
Quoted 2 lines · Arnout Vandecappelle <arnout at mind.be <mailto:[email protected]>> wrote:
Quoted 1 line · Anders Darander

From: Anders Darander <[email protected]

<mailto:[email protected]>>

Quoted 2 lines
Quoted 2 lines

The kernel config here, is basically the default one from the TI

Quoted 8 lines
Quoted 5 lines

kernel.

Quoted 1 line

Thus, it's omap2plus_defconfig, which is rather generic.

So why include a config in buildroot? If it's just the defconfig that is already in the kernel tree, you can use it.

Well, the intention was to reduce it in the next patch, just to show how it was derived. Though, I'll squash them in the next revision.

Good reasoning, but it still makes reviewing more difficult :-)

Quoted 14 lines
Quoted 10 lines
Quoted 2 lines

As the beaglebone support is mainlined, there's no support for the

old

Quoted 1 line

board setup files, and the only supported run-time configuration is

through

Quoted 5 lines

the device tree.

We're also setting the kernel headers to follow the 3.8 series.

<mailto:[email protected]>>

Quoted 3 lines
Quoted 2 lines
---
  board/beaglebone/linux-3.2.9.config |  252

----------------------------

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
  board/beaglebone/linux-3.8.config   |  315

+++++++++++++++++++++++++++++++++++

Please create your patches with the -M option to send-email or
format-patch, so that we can actually see the diff crossing the rename.

Hmm, strange, I was using -M, but I might have to tweak the threshold a little bit. I'll look into that for the next revision.

Ah, it's probably because you didn't squash in the next patch: now the
differences are too high to pass the threshold.

Quoted 26 lines
Quoted 11 lines

Otherwise it's pretty hard to review.

Quoted 5 lines
  configs/beaglebone_defconfig        |   22 +--
  3 files changed, 321 insertions(+), 268 deletions(-)

delete mode 100644 board/beaglebone/linux-3.2.9.config create mode 100644 board/beaglebone/linux-3.8.config

[snip]

Review

Quoted 1 line
(quoted diff) +0 -0

b/configs/beaglebone_defconfig

Quoted 14 lines

configs/beaglebone_defconfig line 7

Quoted 12 lines

index 2177068..f80dd79 100644

configs/beaglebone_defconfig +1 -3
@@ -1,24 +1,14 @@
-# architecture
  BR2_arm=y
  BR2_cortex_a8=y
+BR2_KERNEL_HEADERS_3_8=y
  BR2_EXTRA_GCC_CONFIG_OPTIONS="--with-fpu=vfpv3 --with-float=hard"
  # BR2_SOFT_FLOAT is not set
-
-# system

Please don't remove these comments, they're useful. You can selectively

Quoted 2 lines

Ok, then I guess that I should keep the old ordering, even though savedefconfig have reordered some of them.?

No, the new ordering is good - I do prefer to see things in the 'make
savedefconfig' order.

Quoted 18 lines
Quoted 9 lines

undo changes with 'git checkout -p configs/beaglebone_defconfig'.

configs/beaglebone_defconfig line 8

Quoted 3 lines
configs/beaglebone_defconfig +0 -0
  BR2_LINUX_KERNEL=y
  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 

-BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL="git://github.com/koenkooi/linux.git <http://github.com/koenkooi/linux.git>"

Quoted 1 line
Quoted 8 lines

-BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="linux-ti33x-psp-3.2-r5a+gitr09e9651bcf2ee8d86685f2a8075bc6557b1d3b91"

Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_REPO_URL="git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git <http://git.ti.com/ti-linux-kernel/ti-linux-kernel.git>"

Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION="935f6c2f82056d538b528272e2bdbb5c08d69a58"

Isn't there a tag you can clone from? That's much faster, because then we can (usually) do a shallow clone.

Quoted 7 lines

I'm not sure if there's a tag available in this case.

Ok, so tags preferred if they exists... Good to know, I'll check it and change it if there's a tag.

The list few years I've mainly been working with another build system, where SHA1's are preferred over tags for network-less building.

Do you know if there's a specific reason for that? The 'network-less'
doesn't make a difference because the tags are always equally available, unless you clone/fetch with --no-tags.

Regards,
Arnout

Quoted 10 lines

I'll come back with a new series in a couple of days.

Thanks for the feedback!

Cheers,
Anders

--
Anders Darander

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/5 beaglebone: update to linux 3.8

Quoted 10 lines · Arnout Vandecappelle
Quoted 4 lines · Anders Darander

Hi Arnout,

(Resending as I first sent from an unsubcribed email).

Yeah, the subscribed-only sending can get annoying.

BTW your re-sending lost the in-reply-to headers, which is unfortunate.

Yes, that wan unfortunate side effect... (I was handling that mail from a tablet, thus I was lacking a proper e-mail client for my work e-mail). However, that e-mail is now subscribed, though without e-mail deliveries... Hopefully the best of both worlds!

Quoted 20 lines
Quoted 19 lines · Arnout Vandecappelle <arnout at mind.be <mailto:[email protected]>> wrote:
Quoted 2 lines · Anders Darander
Quoted 1 line

From: Anders Darander <[email protected]

<mailto:[email protected]>**>

Quoted 15 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/configs/beaglebone_**defconfig

Quoted 12 lines

index 2177068..f80dd79 100644

configs/beaglebone_defconfig +1 -3
@@ -1,24 +1,14 @@
-# architecture
  BR2_arm=y
  BR2_cortex_a8=y
+BR2_KERNEL_HEADERS_3_8=y
  BR2_EXTRA_GCC_CONFIG_OPTIONS="**--with-fpu=vfpv3 --with-float=hard"
  # BR2_SOFT_FLOAT is not set
-
-# system
Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Please don't remove these comments, they're useful. You can selectively

Ok, then I guess that I should keep the old ordering, even though savedefconfig have reordered some of them.?

No, the new ordering is good - I do prefer to see things in the 'make
savedefconfig' order.

Ok, good to know. Though I decided to keep the old version of those line, and lock the kernel headers. Though, I'd also prefer to keep the savedefconfig ordering.

Adding those comments automatically might be a good exercise for a rainy day...

Quoted 29 lines

undo changes with 'git checkout -p configs/beaglebone_defconfig'.

Quoted 27 lines
Quoted 6 lines

configs/beaglebone_defconfig line 8

Quoted 5 lines
configs/beaglebone_defconfig +0 -0
  BR2_LINUX_KERNEL=y
  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 

-BR2_LINUX_KERNEL_CUSTOM_GIT_**REPO_URL="git://github.com/**

koenkooi/linux.git <http://github.com/koenkooi/linux.git> <
http://github.com/koenkooi/**linux.git<http://github.com/koenkooi/linux.git>

Quoted 3 lines

"

Quoted 1 line

-BR2_LINUX_KERNEL_CUSTOM_GIT_**VERSION="linux-ti33x-psp-3.2-**r5a+**

gitr09e9651bcf2ee8d86685f2a807**5bc6557b1d3b91"

Quoted 2 lines
Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_**REPO_URL="git://git.ti.com/ti-**

linux-kernel/ti-linux-kernel.**git<http://git.ti.com/ti-linux-kernel/ti-linux-kernel.git><
http://git.ti.com/ti-linux-**kernel/ti-linux-kernel.git<http://git.ti.com/ti-linux-kernel/ti-linux-kernel.git>

Quoted 4 lines

"

Quoted 1 line

+BR2_LINUX_KERNEL_CUSTOM_GIT_**VERSION="**

935f6c2f82056d538b528272e2bdbb**5c08d69a58"

Quoted 3 lines

Isn't there a tag you can clone from? That's much faster, because then we can (usually) do a shallow clone.

I'm not sure if there's a tag available in this case.

Unfortunsately no tags exists...

Quoted 11 lines

Ok, so tags preferred if they exists... Good to know, I'll check it and

Quoted 5 lines

change it if there's a tag.

The list few years I've mainly been working with another build system, where SHA1's are preferred over tags for network-less building.

Do you know if there's a specific reason for that? The 'network-less'
doesn't make a difference because the tags are always equally available, unless you clone/fetch with --no-tags.

Well, I just looked into it, and it seems that they (openmbedded and thus Yocto Project) uses git ls-remote to resolve the tag name. I'm not quite sure of the rationaly for that, though...

Cheers,
Anders
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130511/1183f20c/attachment-0001.html>

#3 lore raw

PATCH 1/5 beaglebone: update to linux 3.8

Quoted 2 lines · Anders Darander

On 11 May 2013 08:10, Arnout Vandecappelle <[email protected] <mailto:[email protected]>> wrote:

[snip]

Quoted 10 lines

No, the new ordering is good - I do prefer to see things in the
'make savedefconfig' order.

Ok, good to know. Though I decided to keep the old version of those line, and lock the kernel headers. Though, I'd also prefer to keep the savedefconfig ordering.

Adding those comments automatically might be a good exercise for a rainy day...

Seems a pretty difficult task - savedefconfig strips everything that is
default, so how can it know which comments to keep and which to remove?

Quoted 24 lines

          >undo changes with 'git checkout -p configs/beaglebone_defconfig'.
          >

          >>   BR2_LINUX_KERNEL=y
          >>   BR2_LINUX_KERNEL_CUSTOM_GIT=y
          >>
          >-BR2_LINUX_KERNEL_CUSTOM_GIT___REPO_URL="git://github.com/__koenkooi/linux.git <http://github.com/koenkooi/linux.git> <http://github.com/koenkooi/__linux.git <http://github.com/koenkooi/linux.git>>"
          >>
          >-BR2_LINUX_KERNEL_CUSTOM_GIT___VERSION="linux-ti33x-psp-3.2-__r5a+__gitr09e9651bcf2ee8d86685f2a807__5bc6557b1d3b91"
          >>
          >+BR2_LINUX_KERNEL_CUSTOM_GIT___REPO_URL="git://git.ti.com/ti-__linux-kernel/ti-linux-kernel.__git <http://git.ti.com/ti-linux-kernel/ti-linux-kernel.git> <http://git.ti.com/ti-linux-__kernel/ti-linux-kernel.git <http://git.ti.com/ti-linux-kernel/ti-linux-kernel.git>>"

          >>
          >+BR2_LINUX_KERNEL_CUSTOM_GIT___VERSION="__935f6c2f82056d538b528272e2bdbb__5c08d69a58"
          >
          >Isn't there a tag you can clone from? That's much faster,
        because then
          >we can (usually) do a shallow clone.

        I'm not sure if there's a tag available in this case.
Quoted 1 line

Unfortunsately no tags exists...

How about using the ti2013.04.00 tag? It's based on 3.8.8 instead of
3.8.11, though.

Quoted 9 lines

Ok, so tags preferred if they exists... Good to know, I'll check it and
change it if there's a tag.

The list few years I've mainly been working with another build system,
where SHA1's are preferred over tags for network-less building.

Quoted 8 lines

Do you know if there's a specific reason for that? The
'network-less' doesn't make a difference because the tags are always equally available, unless you clone/fetch with --no-tags.

Well, I just looked into it, and it seems that they (openmbedded and thus Yocto Project) uses git ls-remote to resolve the tag name. I'm not quite sure of the rationaly for that, though...

Weird... Anyway, we don't have that issue in buildroot.

Regards,
Arnout

Quoted 3 lines

Cheers,
Anders

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F