gst-plugins-bad: fix build of directfb plugin
PATCH 1/1 gst-plugins-bad: fix build of directfb plugin
From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
--- .../gst-plugins-bad-0002-fix-dfb-example.patch | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch
package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch new file +22 -0
@@ -0,0 +1,22 @@ +Fix dfb-example + +Order of inclusion gives a strange effect on the definition of +gst_debug_log. Swapping the include statements solve it. + +Not upstreamed since there will be no more updates to this version +of gst-plugins-bad. + +Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> +--- +diff -rup gst-plugins-bad-0.10.23/ext/directfb/dfb-example.c gst-plugins-bad-0.10.23.fixed/ext/directfb/dfb-example.c +--- gst-plugins-bad-0.10.23/ext/directfb/dfb-example.c 2011-12-11 19:49:11.000000000 +0100 ++++ gst-plugins-bad-0.10.23.fixed/ext/directfb/dfb-example.c 2013-05-13 00:32:00.507469138 +0200 +@@ -1,7 +1,7 @@ + +-#include <directfb.h> + #include <stdio.h> + #include <gst/gst.h> ++#include <directfb.h> + + static IDirectFB *dfb = NULL; + static IDirectFBSurface *primary = NULL;
Signature · 1 line
1.8.2.1
PATCH 1/1 gst-plugins-bad: fix build of directfb plugin
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]> Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> ---
Arnout> .../gst-plugins-bad-0002-fix-dfb-example.patch | 22 ++++++++++++++++++++++
Arnout> 1 file changed, 22 insertions(+)
Arnout> create mode 100644 package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch
Arnout> diff --git a/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch b/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch Arnout> new file mode 100644
Arnout> index 0000000..b205748
Arnout> --- /dev/null
Arnout> +++ b/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch
Arnout> @@ -0,0 +1,22 @@
Arnout> +Fix dfb-example
Arnout> +
That's an odd title. Did you mean somtehing like 'Fix directfb plugin with dfb 1.6.x'?
Other than that it looks good. Thanks for looking into it, it was still on my todo.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 gst-plugins-bad: fix build of directfb plugin
Quoted 18 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]> Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> ---
Arnout> .../gst-plugins-bad-0002-fix-dfb-example.patch | 22 ++++++++++++++++++++++Arnout> 1 file changed, 22 insertions(+)
Arnout> create mode 100644package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patchArnout> diff --git a/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch b/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch Arnout> new file mode 100644 Arnout> index 0000000..b205748 Arnout> --- /dev/null Arnout> +++ b/package/multimedia/gst-plugins-bad/gst-plugins-bad-0002-fix-dfb-example.patch Arnout> @@ -0,0 +1,22 @@ Arnout> +Fix dfb-example Arnout> +
Quoted 2 lines
That's an odd title. Did you mean somtehing like 'Fix directfb plugin with dfb 1.6.x'?
It's not actually the plugin that fails to compile, it's the
dfb-example program that is built but not installed. So perhaps a simpler solution would have been to remove it from Makefile.am and autoreconfigure.
I'm probably not going to have time to resubmit in the coming days, so
if you're willing to take over, please do.
Regards,
Arnout
Quoted 4 lines
Other than that it looks good. Thanks for looking into it, it was still on my todo.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 gst-plugins-bad: fix build of directfb plugin
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
That's an odd title. Did you mean somtehing like 'Fix directfb plugin with dfb 1.6.x'?
Arnout> It's not actually the plugin that fails to compile, it's the Arnout> dfb-example program that is built but not installed. So perhaps a Arnout> simpler solution would have been to remove it from Makefile.am and Arnout> autoreconfigure.
Ahh, ok - Then it's fine. Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard