Skip to contentSkip to conversation

Make sure to use tools as found by configure

PATCH In review Christoph Egger 4 participants 11 messages May 10, 2013 – May 16, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Make sure to use tools as found by configure

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.
This is already required to build tools and stubdom anyway.

This makes an other patch work as submitted:
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html

Christoph

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

Config.mk +0 -0
index b1f12ec..149f55a 100644
@@ -7,6 +7,7 @@ endif
 # fallback for older make
 realpath = $(wildcard $(foreach file,$(1),$(shell cd -P $(dir $(file))

&& echo "$$PWD/$(notdir $(file))")))

+-include $(XEN_ROOT)/config/Tools.mk
-include $(XEN_ROOT)/.config

# A debug build of Xen and tools?
@@ -76,7 +77,6 @@ EXTRA_INCLUDES += $(EXTRA_PREFIX)/include
EXTRA_LIB += $(EXTRA_PREFIX)/lib
endif

-PYTHON ?= python
PYTHON_PREFIX_ARG ?= --prefix="$(PREFIX)"
# The above requires that PREFIX contains *no spaces*. This variable is
here

 # to permit the user to set PYTHON_PREFIX_ARG to '' to workaround this bug:
tools/Rules.mk +0 -1
index 3f03a31..7694a7f 100644
@@ -3,7 +3,6 @@
 # `all' is the default target
 all:
 
--include $(XEN_ROOT)/config/Tools.mk
 include $(XEN_ROOT)/Config.mk
 
 export _INSTALL := $(INSTALL)

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

Config.mk +1 -1
index b1f12ec..149f55a 100644
@@ -7,6 +7,7 @@ endif
 # fallback for older make
 realpath = $(wildcard $(foreach file,$(1),$(shell cd -P $(dir $(file)) && echo "$$PWD/$(notdir $(file))")))
 
+-include $(XEN_ROOT)/config/Tools.mk
 -include $(XEN_ROOT)/.config
 
 # A debug build of Xen and tools?
@@ -76,7 +77,6 @@ EXTRA_INCLUDES += $(EXTRA_PREFIX)/include
 EXTRA_LIB += $(EXTRA_PREFIX)/lib
 endif
 
-PYTHON      ?= python
 PYTHON_PREFIX_ARG ?= --prefix="$(PREFIX)"
 # The above requires that PREFIX contains *no spaces*. This variable is here
 # to permit the user to set PYTHON_PREFIX_ARG to '' to workaround this bug:
tools/Rules.mk +0 -1
index 3f03a31..7694a7f 100644
@@ -3,7 +3,6 @@
 # `all' is the default target
 all:
 
--include $(XEN_ROOT)/config/Tools.mk
 include $(XEN_ROOT)/Config.mk
 
 export _INSTALL := $(INSTALL)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#1 lore raw
Quoted 5 lines · Christoph Egger

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Quoted 8 lines

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.

This is already required to build tools and stubdom anyway.

The hypervisor maintainers have explicitly required that configure not be required to build the hypervisor. You can be pretty sure they will NAK this change, which you didn't even CC to them, I have added them now.

If the instructions above do not work then I think you need to fix them.

Quoted 2 lines

This makes an other patch work as submitted:
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html

That patch remains wrong. Irrespective of this change the docs subtree should include its own Perl detection stuff in the configure script, such that it can be run independently. I explained this in my original reply to that patch.

Ian.

#2 lore raw
Quoted 13 lines · Ian Campbell
Quoted 11 lines · Christoph Egger

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.

Quoted 6 lines
Quoted 1 line

This is already required to build tools and stubdom anyway.

The hypervisor maintainers have explicitly required that configure not be required to build the hypervisor. You can be pretty sure they will NAK this change, which you didn't even CC to them, I have added them now.

Indeed, on that basis: Nack. Please confine autoconf-related goop to the parts of the tree that use it.

Tim.

#3 lore raw
Quoted 6 lines · Tim Deegan
Quoted 5 lines · Ian Campbell
Quoted 3 lines · Christoph Egger

Note, this patch enforces to run configure before you can compile the xen kernel.

Quoted 7 lines
Quoted 4 lines

The hypervisor maintainers have explicitly required that configure not be required to build the hypervisor. You can be pretty sure they will NAK this change, which you didn't even CC to them, I have added them now.

Indeed, on that basis: Nack. Please confine autoconf-related goop to the parts of the tree that use it.

I don't want to dog pile, but I agree: Nack, autoconf shouldn't be required for the hypervisor tree.

--msw

#4 lore raw
In reply to Christoph Egger
Quoted 20 lines · Christoph Egger

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.
This is already required to build tools and stubdom anyway.

This makes an other patch work as submitted:
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html

Christoph

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Quoted 8 lines
Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

1) rework the patch before posting
2) propose the patch on xen-devel for comment from hypervisor maintainers

Matt

#5 lore raw
Quoted 24 lines · Matt Wilson
Quoted 23 lines · Christoph Egger

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.
This is already required to build tools and stubdom anyway.

This makes an other patch work as submitted:
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html

Christoph

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Christoph, please be more careful in future not to misrepresent peoples review.

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

Ian.

#6 lore raw
Quoted 35 lines · Ian Campbell
Quoted 24 lines · Matt Wilson
Quoted 23 lines · Christoph Egger

Hi,

attached patch makes the build process work as described at
http://wiki.xen.org/wiki/Compiling_Xen_From_Source_on_NetBSD

Without this patch compiling the xen kernel fails with
python: No such file or directory

Note, this patch enforces to run configure before you can compile the xen kernel.
This is already required to build tools and stubdom anyway.

This makes an other patch work as submitted:
http://lists.xen.org/archives/html/xen-devel/2013-04/msg02098.html

Christoph

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Quoted 7 lines

Christoph, please be more careful in future not to misrepresent peoples review.

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

Understood.

Christoph

#7 lore raw
In reply to Ian Campbell
Quoted 17 lines · Ian Campbell
Quoted 6 lines · Matt Wilson
Quoted 5 lines · Christoph Egger

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Quoted 7 lines

Christoph, please be more careful in future not to misrepresent peoples review.

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

I think it could help avoid mistakes, but it might cause some complications. I asked Christoph to post patches with the appropriate Reviewed-by:/Acked-by:/etc. line because I'm in a timezone that's fairly far from him and most committers. I sometimes get behind on xen-devel mail and it's possible that a committer might commit a posted patch before I reply on the list, and we'd lose a valuable bit of audit trail in the history.

--msw

#8 lore raw
Quoted 21 lines · Matt Wilson
Quoted 20 lines · Ian Campbell
Quoted 6 lines · Matt Wilson
Quoted 5 lines · Christoph Egger

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Christoph, please be more careful in future not to misrepresent peoples review.

Quoted 8 lines
Quoted 4 lines

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

I think it could help avoid mistakes, but it might cause some complications. I asked Christoph to post patches with the appropriate Reviewed-by:/Acked-by:/etc. line

I'm confused, you Nacked this patch and then asked Christoph to post it with your Reviewed-by anyway?

Quoted 5 lines

because I'm in a timezone that's
fairly far from him and most committers. I sometimes get behind on xen-devel mail and it's possible that a committer might commit a posted patch before I reply on the list, and we'd lose a valuable bit of audit trail in the history.

I'm not sure what you are worried about here, we could always revert if when you catch up you aren't happy with the commit.

Ian.

#9 lore raw
Quoted 27 lines · Ian Campbell
Quoted 26 lines · Matt Wilson
Quoted 24 lines · Ian Campbell
Quoted 6 lines · Matt Wilson
Quoted 5 lines · Christoph Egger

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Christoph, please be more careful in future not to misrepresent peoples review.

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

Quoted 6 lines
Quoted 3 lines

I think it could help avoid mistakes, but it might cause some complications. I asked Christoph to post patches with the appropriate Reviewed-by:/Acked-by:/etc. line

I'm confused, you Nacked this patch and then asked Christoph to post it with your Reviewed-by anyway?

I think, this is my fault. We agreed on moving the discussion about the patch to xen-devel and not the patch itself.

One reason for my mistake is that I didn't understand the design of the build system. I was thinking in: there is a hypervisor and a tools part. But in real there is a hypervisor part, a tools part, a stubdom part and a docs part and each part has its own configure except the hypervisor part.

Christoph

Quoted 13 lines
Quoted 6 lines

because I'm in a timezone that's
fairly far from him and most committers. I sometimes get behind on xen-devel mail and it's possible that a committer might commit a posted patch before I reply on the list, and we'd lose a valuable bit of audit trail in the history.

I'm not sure what you are worried about here, we could always revert if when you catch up you aren't happy with the commit.

Ian.

#10 lore raw
In reply to Ian Campbell
Quoted 27 lines · Ian Campbell
Quoted 26 lines · Matt Wilson
Quoted 24 lines · Ian Campbell
Quoted 6 lines · Matt Wilson
Quoted 5 lines · Christoph Egger

commit 7172e6e0020328d14638a0bbb66a52c905cb4b0b

Author: Christoph Egger <[email protected]>
Date:   Thu Feb 7 14:29:19 2013 +0000
Quoted 7 lines
Quoted 5 lines

Make sure to use tools as found by configure. Fold inclusion of Tools.mk into toplevel Config.mk.

To be clear, I Nack'ed this in review and gave two options:

I was about to query this, thanks for clarifying.

Christoph, please be more careful in future not to misrepresent peoples review.

In general I would think it a good idea if Reviewed-by tags are posted publicly by the Reviewer on xen-devel, even if the review was carried out internally prior to posting, this would help avoid this sort of issue. Not a rule I don't think, but would help avoid mistakes...

Quoted 6 lines
Quoted 3 lines

I think it could help avoid mistakes, but it might cause some complications. I asked Christoph to post patches with the appropriate Reviewed-by:/Acked-by:/etc. line

I'm confused, you Nacked this patch and then asked Christoph to post it with your Reviewed-by anyway?

No, that was a misunderstanding by Christoph. I asked that he post the patches with either "Acked-by:" or "Reviewed-by:" when those are given in our internal review. I gave neither in this case.

Quoted 8 lines
Quoted 5 lines

because I'm in a timezone that's
fairly far from him and most committers. I sometimes get behind on xen-devel mail and it's possible that a committer might commit a posted patch before I reply on the list, and we'd lose a valuable bit of audit trail in the history.

I'm not sure what you are worried about here, we could always revert if when you catch up you aren't happy with the commit.

It's not the case when a patch needs to be rolled back that I'm concerned about. I think that it's useful to have all signoffs in the history so that if there's ever a question in the future about a change an the primary author is unavailable, others can be identified to answer questions, defend the change, etc.

Does that make sense?
--msw