kexec: Replace printf() with die() to error out to stderr
Subsystems (2)
PATCH 1/1 kexec: Replace printf() with die() to error out to stderr
Error messages are mixed stderr with stdout when we use die() along with printf(). So use die() to keep error out consistent.
--- kexec/kexec.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
kexec/kexec.c +7 -7
@@ -1176,17 +1176,17 @@ int main(int argc, char *argv[]) }if ((kexec_flags &KEXEC_ON_CRASH ) && !is_crashkernel_mem_reserved ()) { -printf ("Memory for crashkernel is not reserved\n" ); -printf ("Please reserve memory by passing " ); -printf ("\"crashkernel=X@Y\" parameter to the kernel\n" ); -die ("Then try loading kdump kernel\n" ); +die ("Memory for crashkernel is not reserved\n" +"Please reserve memory by passing" +"\"crashkernel=X@Y\" parameter to kernel\n" +"Then try to loading kdump kernel\n" ); }if (do_load && (kexec_flags &KEXEC_PRESERVE_CONTEXT ) && mem_max ==ULONG_MAX ) { -printf ("Please specify memory range used by kexeced kernel\n" ); -printf ("to preserve the context of original kernel with \n" ); -die ("\"--mem-max\" parameter\n" ); +die ("Please specify memory range used by kexeced kernel\n" +"to preserve the context of original kernel with \n" +"\"--mem-max\" parameter\n" ); } fileind = optind;
Signature · 7 lines
1.8.2.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Simon Horman
AppliedQuoted 4 lines · WANG Chao
Error messages are mixed stderr with stdout when we use
die()along withprintf(). So usedie()to keep error out consistent.Signed-off-by WANG Chao <[email protected]>
Thanks, applied.
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 2 lines · WANG Chao
Error messages are mixed stderr with stdout when we use
die()along withprintf(). So usedie()to keep error out consistent.
Looks good to me.
Quoted 25 lines
Signed-off-by WANG Chao <[email protected]>--- kexec/kexec.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)kexec/kexec.c +4
-4@@ -1176,17 +1176,17 @@ int main(int argc, char *argv[]) }if ((kexec_flags &KEXEC_ON_CRASH ) && !is_crashkernel_mem_reserved ()) { -printf ("Memory for crashkernel is not reserved\n" ); -printf ("Please reserve memory by passing " ); -printf ("\"crashkernel=X@Y\" parameter to the kernel\n" ); -die ("Then try loading kdump kernel\n" ); +die ("Memory for crashkernel is not reserved\n" +"Please reserve memory by passing" +"\"crashkernel=X@Y\" parameter to kernel\n" +"Then try to loading kdump kernel\n" ); } if (do_load && (kexec_flags & KEXEC_PRESERVE_CONTEXT) &&
kexec/kexec.c int main(int argc, char *argv[]) · line 1192
Quoted 10 lines
kexec/kexec.c +3
-3mem_max == ULONG_MAX) { -printf ("Please specify memory range used by kexeced kernel\n" ); -printf ("to preserve the context of original kernel with \n" ); -die ("\"--mem-max\" parameter\n" ); +die ("Please specify memory range used by kexeced kernel\n" +"to preserve the context of original kernel with \n" +"\"--mem-max\" parameter\n" ); } fileind = optind;
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec