checkpatch: avoid warning on page flag acessors
PATCH 1/1 checkpatch: avoid warning on page flag acessors
Using Page*() triggers a camelcase warning, but shouldn't.
Introduced by be987d9f80354e2e919926349282facd74992f90, which added the other Page flag users.
Pipe ('|') at the end of a grouping doesn't cause the grouping to match an emtpy string, use ? after the grouping instead to get the desired behavior.
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE",
Signature · 1 line
1.8.2.2
Quoted 20 lines · Cody P Schafer
Using Page*() triggers a camelcase warning, but shouldn't.
Introduced by
be987d9f80354e2e919926349282facd74992f90, which added the other Page flag users.Pipe ('|') at the end of a grouping doesn't cause the grouping to match an emtpy string, use ? after the grouping instead to get the desired behavior.
Signed-off-by Cody P Schafer <[email protected]>--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/checkpatch.pl +0
-0
scripts/checkpatch.pl sub process { · line 2945
Quoted 8 lines
scripts/checkpatch.pl +1
-1@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE",
Nix this, appears to still be broken
WARNING: Avoid CamelCase: <PageBuddy>
#51: FILE: mm/page_alloc.c:449:
+ VM_BUG_ON(!PageBuddy(page));
total: 0 errors, 1 warnings, 46 lines checked
/home/cody/mm/0008-page_alloc-add-return_pages_to_zone-when-DYNAMIC_NUM.patch has style problems, please review.
PATCH v2 1/1 checkpatch: avoid warning on page flag acessors
In reply to Cody P SchaferUsing Page*() triggers a camelcase warning, but shouldn't.
be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double quote) breaking the regex.
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE",
Signature · 1 line
1.8.2.2
Joe Perches
maintainerQuoted 4 lines · Cody P Schafer
Using Page*() triggers a camelcase warning, but shouldn't.
be987d9f80354e2e919926349282facd74992f90added a spurious '"' (double quote) breaking the regex.
[]
scripts/checkpatch.pl
Quoted 1 line
scripts/checkpatch.pl +0
-0
[]
scripts/checkpatch.pl sub process { · line 2942
Quoted 6 lines
scripts/checkpatch.pl +1
-1@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
I think you need to delete the ", leave the | and remove the ? Dunno where that " came from.
Quoted 2 lines · Joe Perches
I think you need to delete the ", leave the | and remove the ? Dunno where that " came from.
Ya. commit goof on my part, see v3
PATCH v3 1/1 checkpatch: avoid warning on page flag acessors
In reply to Cody P SchaferUsing Page*() triggers a camelcase warning, but shouldn't.
be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double quote) breaking the regex.
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
---
Appologies for the noise, I updated my commit message but not the patch in the previous version.
scripts/checkpatch.pl +1 -1
@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE",
Signature · 1 line
1.8.2.2
PATCH v4 1/1 checkpatch: avoid warning on page flag acessors
In reply to Cody P SchaferUsing Page*() triggers a camelcase warning, but shouldn't.
be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double quote) breaking the regex.
--- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
---
And using sha1s in format-patch means I have to actually copy the new ones. (Again, sorry).
scripts/checkpatch.pl +1 -1
@@ -2939,7 +2939,7 @@ sub process { my $var = $1; if ($var !~ /$Constant/ && $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && + $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && !defined $camelcase{$var}) { $camelcase{$var} = 1; WARN("CAMELCASE",
Signature · 1 line
1.8.2.2