Skip to contentSkip to conversation

mmc: fix env in mmc with redundant compile error

PATCH New Bo Shen 2 participants 3 messages May 13, 2013 – May 15, 2013

lore
Share & tools
lore

Bo Shen

author
#0 lore raw

PATCH 1/1 mmc: fix env in mmc with redundant compile error

The commit d196bd8 (env_mmc: add support for redundant environment) introduce the following compile error when enable reduandant environment support with MMC
---8<---
env_mmc.c:149: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:267: error: 'env_t' has no member named 'flags' make[1]: *** [env_mmc.o] Error 1
--->8---

Add this patch to fix it

---
 include/environment.h |    6 ++++++
 1 file changed, 6 insertions(+)
include/environment.h +6 -0
index 4c6a37b..460ccb4 100644
@@ -75,6 +75,12 @@
 # endif
 #endif	/* CONFIG_ENV_IS_IN_FLASH */
 
+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
 #if defined(CONFIG_ENV_IS_IN_NAND)
 # if defined(CONFIG_ENV_OFFSET_OOB)
 #  ifdef CONFIG_ENV_OFFSET_REDUND
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mmc: fix env in mmc with redundant compile error

Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:

Quoted 32 lines

The commit d196bd8 (env_mmc: add support for redundant environment) introduce the following compile error when enable reduandant environment support with MMC
---8<---
env_mmc.c:149: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:267: error: 'env_t' has no member named 'flags' make[1]: *** [env_mmc.o] Error 1
--->8---

Add this patch to fix it

---
 include/environment.h |    6 ++++++
 1 file changed, 6 insertions(+)
include/environment.h +0 -0
index 4c6a37b..460ccb4 100644
@@ -75,6 +75,12 @@
 # endif
 #endif	/* CONFIG_ENV_IS_IN_FLASH */

include/environment.h line 86

Quoted 10 lines
include/environment.h +6 -0
 
+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
 #if defined(CONFIG_ENV_IS_IN_NAND)
 # if defined(CONFIG_ENV_OFFSET_OOB)
 #  ifdef CONFIG_ENV_OFFSET_REDUND

s/reduandant/redundant/

author
#2 lore raw

PATCH 1/1 mmc: fix env in mmc with redundant compile error

Hi Michael,

Quoted 33 lines · Michael Heimpold

Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:

Quoted 32 lines

The commit d196bd8 (env_mmc: add support for redundant environment) introduce the following compile error when enable reduandant environment support with MMC
---8<---
env_mmc.c:149: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:248: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:250: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:252: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:254: error: 'env_t' has no member named 'flags' env_mmc.c:267: error: 'env_t' has no member named 'flags' make[1]: *** [env_mmc.o] Error 1
--->8---

Add this patch to fix it

---
  include/environment.h |    6 ++++++
  1 file changed, 6 insertions(+)
include/environment.h +0 -0
index 4c6a37b..460ccb4 100644
@@ -75,6 +75,12 @@
  # endif
  #endif	/* CONFIG_ENV_IS_IN_FLASH */
 
Quoted 12 lines

include/environment.h line 86

Quoted 10 lines
include/environment.h +6 -0
+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+#  define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
  #if defined(CONFIG_ENV_IS_IN_NAND)
  # if defined(CONFIG_ENV_OFFSET_OOB)
  #  ifdef CONFIG_ENV_OFFSET_REDUND

s/reduandant/redundant/

Thanks for figure out this, I will correct it in next version.

Quoted 1 line

In next version, I will add your Reviewed-by tag.

Best Regards,
Bo Shen