xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
PATCH v3 1/1 xfstests generic 312: test fallocate(2) ENOSPC when file size is greater than 4G
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
---
v3: rebase on top of master
v2: Check for $SCRATCH_DEV size, _notrun if it's smaller than 5G
tests/generic/312 | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/312.out | 2 ++ tests/generic/group | 1 + 3 files changed, 75 insertions(+) create mode 100644 tests/generic/312 create mode 100644 tests/generic/312.out
tests/generic/312 new file +72 -0
@@ -0,0 +1,72 @@ +#! /bin/bash +# FS QA Test No. 312 +# +# ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G +# +# Regression test for commit +# 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate() +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_xfs_io_falloc +_require_scratch + +# 5G in byte +fssize=$((2**30 * 5)) +required_blocks=$(($fssize / 1024)) +dev_blocks=$(grep $(basename $(readlink -f $SCRATCH_DEV)) /proc/partitions | $AWK_PROG '{print $3}') +if [ $required_blocks -gt $dev_blocks ];then + _notrun "this test requires \$SCRATCH_DEV has ${fssize}B space" +fi + +rm -f $seqres.full +_scratch_mkfs_sized $fssize >>$seqres.full 2>&1 +_scratch_mount >>$seqres.full 2>&1 + +echo "Silence is golden" + +# fallocate(2) a 6G(> 4G) file on a 5G fs +$XFS_IO_PROG -f -c "falloc 0 6g" $SCRATCH_MNT/testfile.$seq >>$seqres.full 2>&1 + +_scratch_unmount +_check_scratch_fs +status=0 +exit
tests/generic/312.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 312 +Silence is golden
tests/generic/group +1 -0
@@ -114,3 +114,4 @@ 309 auto quick 310 auto 311 auto metadata log +312 auto quick prealloc enospc
Signature · 6 lines
1.8.2.1 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 9 lines · Eryu Guan
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast inext4_fallocate()Signed-off-by Eryu Guan <[email protected]>---
v3: rebase on top of master
v2: Check for $SCRATCH_DEV size,_notrunif it's smaller than 5G
Any comments on this test case?
Thanks!
Eryu Guan
Quoted 106 lines
tests/generic/312 | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/312.out | 2 ++ tests/generic/group | 1 + 3 files changed, 75 insertions(+) create mode 100644 tests/generic/312 create mode 100644 tests/generic/312.outtests/generic/312 new file +72
-0@@ -0,0 +1,72 @@ +#! /bin/bash +# FS QA Test No. 312 +# +# ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G +# +# Regression test for commit +# 29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate() +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_xfs_io_falloc +_require_scratch + +# 5G in byte +fssize=$((2**30 * 5)) +required_blocks=$(($fssize / 1024)) +dev_blocks=$(grep $(basename $(readlink -f $SCRATCH_DEV)) /proc/partitions | $AWK_PROG '{print $3}') +if [ $required_blocks -gt $dev_blocks ];then + _notrun "this test requires \$SCRATCH_DEV has ${fssize}B space" +fi + +rm -f $seqres.full +_scratch_mkfs_sized $fssize >>$seqres.full 2>&1 +_scratch_mount >>$seqres.full 2>&1 + +echo "Silence is golden" + +# fallocate(2) a 6G(> 4G) file on a 5G fs +$XFS_IO_PROG -f -c "falloc 0 6g" $SCRATCH_MNT/testfile.$seq >>$seqres.full 2>&1 + +_scratch_unmount +_check_scratch_fs +status=0 +exittests/generic/312.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 312 +Silence is goldentests/generic/group +1
-0@@ -114,3 +114,4 @@ 309 auto quick 310 auto 311 auto metadata log +312 auto quick prealloc enospcSignature · 1 line
1.8.2.1
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Eryu Guan
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast inext4_fallocate()Signed-off-by Eryu Guan <[email protected]>
Tested fine for xfs and ext4, Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Eryu Guan
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast inext4_fallocate()Signed-off-by Eryu Guan <[email protected]>---
This patch has been committed:
commit 355beacfaf705294b119a3da372512589ff893e9
Author: Eryu Guan <[email protected]> Date: Wed May 15 07:48:41 2013 -0500
ENOSPC in fallocate(2) could corrupt ext4 when file size > 4G
Regression test for commit
29ae07b ext4: Fix overflow caused by missing cast in ext4_fallocate()
Thanks
--Rich
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs