Makefile: Fix some macro redefinition warnings
Subsystems (2)
PATCH 2/3 Makefile: Fix some macro redefinition warnings
In particular, gcc complains as follows:
CC sparse-llvm.o
<command line>:1:1: warning: "__STDC_CONSTANT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definition <command line>:1:1: warning: "__STDC_FORMAT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definition <command line>:1:1: warning: "__STDC_LIMIT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definition
The warnings are caused by the macros being defined twice on the gcc command line. These command line -D macro definitions come originally from the output of 'llvm-config --cflags', which is recorded in the $(LLVM_CFLAGS) variable. This variable is then included in the $(BASIC_CFLAGS) variable twice due to duplication of the target-specific additions to the BASIC_CFLAGS, viz:
sparse-llvm_EXTRA_DEPS := sparse-llvm.o sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS)
In order to suppress the warnings, we remove the duplication of the sparse-llvm.o target in the above rule.
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -90,7 +90,7 @@ LLVM_LIBS := $(shell llvm-config --libs) PROGRAMS += $(LLVM_PROGS) INST_PROGRAMS += sparse-llvm sparsec sparse-llvm_EXTRA_DEPS := sparse-llvm.o -sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS) +$(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS) sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) endif endif
Signature · 1 line
1.8.2
Christopher Li
maintainerQuoted 18 lines · Ramsay Jones
In particular, gcc complains as follows:
CC sparse-llvm.o
<command line>:1:1: warning: "__STDC_CONSTANT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definition <command line>:1:1: warning: "__STDC_FORMAT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definition <command line>:1:1: warning: "__STDC_LIMIT_MACROS" redefined <command line>:1:1: warning: this is the location of the previous definitionThe warnings are caused by the macros being defined twice on the gcc command line. These command line -D macro definitions come originally from the output of 'llvm-config --cflags', which is recorded in the $(LLVM_CFLAGS) variable. This variable is then included in the $(BASIC_CFLAGS) variable twice due to duplication of the target-specific additions to the
BASIC_CFLAGS, viz:
Quoted 7 lines
sparse-llvm_EXTRA_DEPS := sparse-llvm.o sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS)In order to suppress the warnings, we remove the duplication of the sparse-llvm.o target in the above rule.
Signed-off-by Ramsay Jones <[email protected]>
I already commit a similar fix to remove the duplication. I did not realize it can generate warning though.
Chris