Skip to contentSkip to conversation

cfi_flash: use CFI driver without a monitor program

PATCH New Masahiro Yamada 2 participants 3 messages May 17, 2013 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfi_flash: use CFI driver without a monitor program

When CONFIG_SYS_MONITOR_BASE is not defined and CONFIG_SYS_FLASH_BASE is defined as zero, compile failed with an error.

We can work around this problem by defining CONFIG_SYS_MONITOR_BASE as any value even though a monitor program is not used. But this is not a correct way.

Using CFI driver should not depend on the use of a monitor program.

So, this commit corrects the build error by adding "if defined(CONFIG_SYS_MONITOR_BASE)" condition.

---
 drivers/mtd/cfi_flash.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mtd/cfi_flash.c +2 -1
index 22d8440..e418c22 100644
@@ -2308,7 +2308,8 @@ void flash_protect_default(void)
 #endif
 
 	/* Monitor protection ON by default */
-#if (CONFIG_SYS_MONITOR_BASE >= CONFIG_SYS_FLASH_BASE) && \
+#if defined(CONFIG_SYS_MONITOR_BASE) && \
+	(CONFIG_SYS_MONITOR_BASE >= CONFIG_SYS_FLASH_BASE) &&	\
 	(!defined(CONFIG_MONITOR_IS_IN_RAM))
 	flash_protect(FLAG_PROTECT_SET,
 		       CONFIG_SYS_MONITOR_BASE,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 cfi_flash: use CFI driver without a monitor program

Quoted 8 lines · Masahiro Yamada

When CONFIG_SYS_MONITOR_BASE is not defined and CONFIG_SYS_FLASH_BASE is defined as zero, compile failed with an error.

We can work around this problem by defining CONFIG_SYS_MONITOR_BASE as any value even though a monitor program is not used. But this is not a correct way.

CONFIG_SYS_MONITOR_BASE should be defined to the value, where the U-Boot image (monitor) is located.

Quoted 2 lines

Using CFI driver should not depend on the use of a monitor program.

Could you please explain, what a "monitor program" is?

Is it correct to assume, that you are using the CFI NOR flash driver, but have U-Boot located in some other location (NAND, MMC...)?

Thanks,
Stefan

#2 lore raw

PATCH 1/1 cfi_flash: use CFI driver without a monitor program

Hello, Stefan,

Thank you for your reply.

Quoted 1 line

Could you please explain, what a "monitor program" is?

I don't actually know what a "monitor program" is. But, I just thought it is like a stab program used by GDB or something.
(I am not using GDB either, but somehow I just imagined so.)

You mentioned "monitor" is U-Boot image, and I read README file. Now I realized I had completely misunderstood
the meaning of "monitor".

Quoted 2 lines

Is it correct to assume, that you are using the CFI NOR flash driver, but have U-Boot located in some other location (NAND, MMC...)?

Yes.
U-Boot is located sometimes in SRAM, or sometimes in NOR flash or other cases in NAND.
(My SoC board is a little special.
Memory devices such as SRAM, NOR flash, NAND flash can be attached to kind of expantion slots of SoC board,
which allows to easily change boot devices.)

Please let me retract this patch.
I'm sorry for wasting your time.

Best Regards
Masahiro Yamada