Skip to contentSkip to conversation

kernel/sched/core.c: need return NULL when BUG() is defined as empty.

PATCH In review Chen Gang 3 participants 6 messages May 20, 2013 – May 23, 2013 Scheduler

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 kernel/sched/core.c: need return NULL when BUG() is defined as empty.

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

It is generated by randconfig with MMU for arm s5pv210 with EXTRA_CFALGS=-W.

The related warnings:
kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type]

---
 kernel/sched/core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/sched/core.c +1 -0
index 9ff7744..94ef8ff 100644
@@ -2350,6 +2350,7 @@ pick_next_task(struct rq *rq)
 	}
 
 	BUG(); /* the idle class will always have a runnable task */
+	return NULL;
 }
 
 /*
Signature · 1 line
1.7.7.6
maintainer
#1 lore raw
Quoted 3 lines · Chen Gang

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

What will such a kernel do? Happily continue running whenever we hit a BUG? that seems like a particularly bad idea. Should we not have a stub BUG() function like:

void BUG(void) __attribute__((noreturn))

{
	local_irq_disable();
	while (1) ;
}

Which would at least halt things?

author
#2 lore raw
Quoted 8 lines · Peter Zijlstra
Quoted 3 lines · Chen Gang
Quoted 3 lines

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

What will such a kernel do? Happily continue running whenever we hit a BUG? that seems like a particularly bad idea. Should we not have a stub BUG() function like:

Quoted 9 lines

void BUG(void) __attribute__((noreturn))

{
	local_irq_disable();
	while (1) ;
}

Which would at least halt things?

At least for me, it is a good idea. :-)

In menuconfig we can set !CONFIG_BUG and !HAVE_ARCH_BUG manually under any architectures:

"> General setup > Configure standard kernel features (expert users) > BUG() Support"

So I think, we really need your patch.

Thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation
#3 lore raw
In reply to Peter Zijlstra
Quoted 9 lines · Peter Zijlstra
Quoted 3 lines · Chen Gang

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

What will such a kernel do? Happily continue running whenever we hit a BUG? that seems like a particularly bad idea. Should we not have a stub BUG() function like:

Quoted 5 lines

void BUG(void) __attribute__((noreturn))

{
	local_irq_disable();
	while (1) ;
}

Eww. So you've a platform where you have things like panic_on_oops enabled, and you hit this bug... do we really want to just stop? Wouldn't replacing BUG() with panic("BUG"); be better ?

But, this begs the question - what is the point of being able to turn off BUG() ? As BUG() on any sensible architecture is implemented by placing the minimum of code at the callsite (eg, one instruction if not using verbose) anything like the above is likely to be bigger.

So, I'd actually argue that rather than trying to "fix" this, get rid of CONFIG_BUG and make it always enabled everywhere - just like what has recently been done with hotplug.

maintainer
#4 lore raw
Quoted 20 lines · Russell King - ARM Linux
Quoted 9 lines · Peter Zijlstra
Quoted 3 lines · Chen Gang

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

What will such a kernel do? Happily continue running whenever we hit a BUG? that seems like a particularly bad idea. Should we not have a stub BUG() function like:

Quoted 5 lines

void BUG(void) __attribute__((noreturn))

{
	local_irq_disable();
	while (1) ;
}

Eww. So you've a platform where you have things like panic_on_oops enabled, and you hit this bug... do we really want to just stop? Wouldn't replacing BUG() with panic("BUG"); be better ?

Quoted 8 lines

But, this begs the question - what is the point of being able to turn off BUG() ? As BUG() on any sensible architecture is implemented by placing the minimum of code at the callsite (eg, one instruction if not using verbose) anything like the above is likely to be bigger.

So, I'd actually argue that rather than trying to "fix" this, get rid of CONFIG_BUG and make it always enabled everywhere - just like what has recently been done with hotplug.

Works for me.

author
#5 lore raw
Quoted 26 lines · Peter Zijlstra
Quoted 25 lines · Russell King - ARM Linux
Quoted 25 lines · Peter Zijlstra
Quoted 9 lines
Quoted 9 lines · Chen Gang
Quoted 3 lines
Quoted 3 lines

When neither CONFIG_BUG nor HAVE_ARCH_BUG is defined, need let function return failure value ('NULL') instead of random value.

What will such a kernel do? Happily continue running whenever we hit a BUG? that seems like a particularly bad idea. Should we not have a stub BUG() function like:

Quoted 5 lines
Quoted 5 lines

void BUG(void) __attribute__((noreturn))

{
	local_irq_disable();
	while (1) ;
}

Eww. So you've a platform where you have things like panic_on_oops enabled, and you hit this bug... do we really want to just stop? Wouldn't replacing BUG() with panic("BUG"); be better ?

But, this begs the question - what is the point of being able to turn off BUG() ? As BUG() on any sensible architecture is implemented by placing the minimum of code at the callsite (eg, one instruction if not using verbose) anything like the above is likely to be bigger.

Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

So, I'd actually argue that rather than trying to "fix" this, get rid of CONFIG_BUG and make it always enabled everywhere - just like what has recently been done with hotplug.

Works for me.

Thanks all, I should send the related patch for it.

Excuse me, I have to do another things, so I will finish it within this week (2013-05-26)

Welcome any additional suggestions and completions.

Thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation