bonding: add synchronize_net() after netdev_rx_handler_unregister
Subsystems (3)
PATCH 1/1 bonding: add synchronize_net() after netdev_rx_handler_unregister
commit 00cfec3 (net: add a synchronize_net() in netdev_rx_handler_unregister()) add a synchronize_net() in netdev_rx_handler_unregister() to guarantee the rx_handler is NULL when rx_handler_data is a non NULL in rcu_read_lock().
so the caller should not use netdev_rx_handler_unregister in atomic as it may schedule and sleep, the bonding release met the problem.
the commit fcd99434f (bonding: get netdev_rx_handler_unregister out of locks) fix the bug in bond release, but there is no action to guarantee the rx_handler_data is NULL when bond release, so add synchronize_net() behind netdev_rx_handler_unregister() to guarantee it.
This patch adds more comments to netdev_rx_handler_unregister(), as its more reasonable.
--- drivers/net/bonding/bond_main.c | 2 ++ net/core/dev.c | 3 +++ 2 files changed, 5 insertions(+)
drivers/net/bonding/bond_main.c +2 -0
@@ -2007,6 +2007,8 @@ static int __bond_release_one(struct net_device *bond_dev,* for this slave anymore. */ netdev_rx_handler_unregister (slave_dev); +synchronize_net (); +write_lock_bh (&bond->lock);if (!all && !bond->params.fail_over_mac) {
net/core/dev.c +3 -0
@@ -3344,6 +3344,9 @@ EXPORT_SYMBOL_GPL(netdev_rx_handler_register);* Unregister a receive handler from a device. * * The caller must hold the rtnl_mutex. +* +* The function should only be called outside the atomic as it +* might sleep and schedule. */ void netdev_rx_handler_unregister (struct net_device *dev) {
Signature · 1 line
1.8.0
Quoted 12 lines · dingtianhong
commit 00cfec3 (net: add a
synchronize_net()innetdev_rx_handler_unregister()) add asynchronize_net()innetdev_rx_handler_unregister()to guarantee therx_handleris NULL whenrx_handler_datais a non NULL inrcu_read_lock().so the caller should not use
netdev_rx_handler_unregisterin atomic as it may schedule and sleep, the bonding release met the problem.the commit
fcd99434f(bonding: getnetdev_rx_handler_unregisterout of locks) fix the bug in bond release, but there is no action to guarantee therx_handler_datais NULL when bond release, so addsynchronize_net()behindnetdev_rx_handler_unregister()to guarantee it.
Quoted 8 lines
This patch adds more comments to
netdev_rx_handler_unregister(), as its more reasonable.Signed-off-by Ding Tianhong <[email protected]>--- drivers/net/bonding/bond_main.c | 2 ++ net/core/dev.c | 3 +++ 2 files changed, 5 insertions(+)
I NACK this patch. This makes absolutely no sense to me.