Remove unecessary ERROR when removing non-empty directory
PATCH 1/1 Remove unecessary ERROR when removing non-empty directory
While removing a non-empty directory, the kernel dumps a message:
(rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39
Suppress the error message from being printed in the dmesg so users don't panic.
---
fs/ocfs2/namei.c +1 -1
@@ -947,7 +947,7 @@ leave:ocfs2_free_dir_lookup_result (&orphan_insert);ocfs2_free_dir_lookup_result (&lookup); -if (status) +if (status && (status != -ENOTEMPTY ))mlog_errno (status);return status;
PATCH 1/1 Remove unecessary ERROR when removing non-empty directory
Quoted 23 lines · Goldwyn Rodrigues
While removing a non-empty directory, the kernel dumps a message:
(rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39Suppress the error message from being printed in the dmesg so users don't panic.
Signed-off-by Goldwyn Rodrigues <[email protected]>---
fs/ocfs2/namei.c +1
-1@@ -947,7 +947,7 @@ leave:ocfs2_free_dir_lookup_result (&orphan_insert);ocfs2_free_dir_lookup_result (&lookup); -if (status) +if (status && (status != -ENOTEMPTY ))mlog_errno (status);return status;
Quoted 5 lines
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20130522/23383a46/attachment.html
PATCH 1/1 Remove unecessary ERROR when removing non-empty directory
In reply to Goldwyn RodriguesShould we also add this (status != -ENOTEMPTY) in end of ocfs2_rename? It also may hit this unecessary error.
Thanks,
xiaowei
Quoted 29 lines · Goldwyn Rodrigues
While removing a non-empty directory, the kernel dumps a message:
(rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39Suppress the error message from being printed in the dmesg so users don't panic.
Signed-off-by Goldwyn Rodrigues <[email protected]>---
fs/ocfs2/namei.c +1
-1@@ -947,7 +947,7 @@ leave:ocfs2_free_dir_lookup_result (&orphan_insert);ocfs2_free_dir_lookup_result (&lookup); -if (status) +if (status && (status != -ENOTEMPTY ))mlog_errno (status);return status;_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
PATCH 1/1 Remove unecessary ERROR when removing non-empty directory
Quoted 2 lines · xiaowei.hu
Should we also add this (status !=
-ENOTEMPTY) in end ofocfs2_rename? It also may hit this unecessary error.
This definitely is the same thing like ocfs2_unlink() that need to be fixed.
Thanks,
-Jeff
Quoted 40 lines
Thanks,
xiaoweiQuoted 23 lines · Goldwyn Rodrigues
While removing a non-empty directory, the kernel dumps a message:
(rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39Suppress the error message from being printed in the dmesg so users don't panic.
Signed-off-by Goldwyn Rodrigues <[email protected]>---
fs/ocfs2/namei.c +1
-1@@ -947,7 +947,7 @@ leave:ocfs2_free_dir_lookup_result (&orphan_insert);ocfs2_free_dir_lookup_result (&lookup); -if (status) +if (status && (status != -ENOTEMPTY ))mlog_errno (status);return status;Quoted 6 lines
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel