arch: mips: ralink: using strlcpy() instead of strncpy()
Subsystems (3)
PATCH 1/1 arch: mips: ralink: using strlcpy() instead of strncpy()
'compatible' is used by strlen() in __of_device_is_compatible().
So for NUL terminated string, need always be sure of ended by zero.
'of_ids' is not a structure in "include/uapi/*", so not need initialize all bytes, just use strlcpy() instead of strncpy().
Signed-off-by Chen Gang <[email protected]>
--- arch/mips/ralink/of.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/ralink/of.c +1 -1
@@ -104,7 +104,7 @@ static int __init plat_of_setup(void)if (!of_have_populated_dt ())panic ("device tree not present" ); -strncpy (of_ids[0 ].compatible, soc_info.compatible, len); +strlcpy (of_ids[0 ].compatible, soc_info.compatible, len);strncpy (of_ids[1 ].compatible,"palmbus" , len);if (of_platform_populate (NULL , of_ids,NULL ,NULL ))
Signature · 1 line
1.7.7.6
Quoted 9 lines · Chen Gang
'compatible' is used by
strlen()in__of_device_is_compatible().So for NUL terminated string, need always be sure of ended by zero.
'
of_ids' is not a structure in "include/uapi/*", so not need initialize all bytes, just usestrlcpy()instead ofstrncpy().Signed-off-by Chen Gang<[email protected]>
Acked-by John Crispin <[email protected]>