Skip to contentSkip to conversation

mmc: of_mmc_spi: fix card detect irq

PATCH New Jean-Christophe PLAGNIOL-VILLARD 2 participants 4 messages May 26, 2013 – May 27, 2013 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: of_mmc_spi: fix card detect irq

set missing irq type the IRQF_ONESHOT

Cc stable <[email protected]> # 3.4+
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/of_mmc_spi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/of_mmc_spi.c +2 -2
index d720b5e..cfb2e61 100644
@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
 {
 	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
 
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+		IRQF_ONESHOT, dev_name(dev), mmc);
 }
 
 static void of_mmc_spi_exit(struct device *dev, void *mmc)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 mmc: of_mmc_spi: fix card detect irq

Hello.

Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD

set missing irq type the IRQF_ONESHOT

Cc stable <[email protected]> # 3.4+
Cc linux-mmc at vger.kernel.org
---
  drivers/mmc/host/of_mmc_spi.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/of_mmc_spi.c +0 -0
index d720b5e..cfb2e61 100644

drivers/mmc/host/of_mmc_spi.c static int of_mmc_spi_init(struct device *dev, · line 78

Quoted 7 lines
drivers/mmc/host/of_mmc_spi.c +2 -2
@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
  {
  	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
 
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+		IRQF_ONESHOT, dev_name(dev), mmc);

Please don't change the indentation.

WBR, Sergei

#2 lore raw

PATCH 1/1 mmc: of_mmc_spi: fix card detect irq

Quoted 13 lines · Sergei Shtylyov

Hello.

Quoted 9 lines · Jean-Christophe PLAGNIOL-VILLARD

set missing irq type the IRQF_ONESHOT

Cc stable <[email protected]> # 3.4+
Cc linux-mmc at vger.kernel.org
---
 drivers/mmc/host/of_mmc_spi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

drivers/mmc/host/of_mmc_spi.c static int of_mmc_spi_init(struct device *dev, · line 77

Quoted 11 lines
drivers/mmc/host/of_mmc_spi.c +2 -2
index d720b5e..cfb2e61 100644
@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
 {
 	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+		IRQF_ONESHOT, dev_name(dev), mmc);

Please don't change the indentation.

too long > 80

Best Regards,
J.

#3 lore raw

PATCH 1/1 mmc: of_mmc_spi: fix card detect irq

Hello.

Quoted 23 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines
Quoted 8 lines

set missing irq type the IRQF_ONESHOT

Cc stable <[email protected]> # 3.4+
Cc linux-mmc at vger.kernel.org
---
  drivers/mmc/host/of_mmc_spi.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

drivers/mmc/host/of_mmc_spi.c static int of_mmc_spi_init(struct device *dev, · line 77

Quoted 11 lines
drivers/mmc/host/of_mmc_spi.c +2 -2
index d720b5e..cfb2e61 100644
@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
  {
  	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+		IRQF_ONESHOT, dev_name(dev), mmc);

Please don't change the indentation.

Quoted 1 line

too long > 80

Reflow it then into several lines.

Quoted 2 lines

Best Regards,
J.

WBR, Sergei