thermal: step_wise: cdev only needs update on a new target state
PATCH 1/1 thermal: step_wise: cdev only needs update on a new target state
The cooling device only needs update on a new target state. Since we already check old target in thermal_zone_trip_update(), we can do one more check to see if it's a new target state. If not, we can reasonably save some uncecesary code execution.
--- drivers/thermal/step_wise.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/thermal/step_wise.c +3 -0
@@ -133,6 +133,9 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) old_target = instance->target; instance->target =get_target_state (instance, trend, throttle); +if (old_target == instance->target) +continue ; +/* Activate a passive thermal instance */ if (old_target ==THERMAL_NO_TARGET && instance->target !=THERMAL_NO_TARGET )
Signature · 1 line
1.7.9.5
PATCH 1/1 thermal: step_wise: cdev only needs update on a new target state
Rui,
Quoted 5 lines · Shawn Guo
The cooling device only needs update on a new target state. Since we already check old target in
thermal_zone_trip_update(), we can do one more check to see if it's a new target state. If not, we can reasonably save some uncecesary code execution.
typo above:
s/uncecesary/unnecessary
Quoted 2 lines
Signed-off-by Shawn Guo <[email protected]>---
A part from the above typo, I believe we must have this change in:
Quoted 18 lines
drivers/thermal/step_wise.c | 3 +++ 1 file changed, 3 insertions(+)drivers/thermal/step_wise.c +3
-0@@ -133,6 +133,9 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) old_target = instance->target; instance->target =get_target_state (instance, trend, throttle); +if (old_target == instance->target) +continue ; +/* Activate a passive thermal instance */ if (old_target ==THERMAL_NO_TARGET && instance->target !=THERMAL_NO_TARGET )
Signature · 11 lines
You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130529/34c0cea2/attachment.sig>