Skip to contentSkip to conversation

bonding: change igmp_retrans type from s8 to u8

PATCH In review [email protected] 1 participant 2 messages May 29, 2013 – May 30, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding: change igmp_retrans type from s8 to u8

From: Nikolay Aleksandrov <[email protected]>

According to the bonding documentation and to the error messages the resend_igmp should be between 0 and 255, but since the type of the variable that counts is wrong, this is not the case.
We have igmp_retrans = resend_igmp when the work is started.

---
 drivers/net/bonding/bonding.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bonding.h +1 -1
index 2baec24..f989e15 100644
@@ -225,7 +225,7 @@ struct bonding {
 	rwlock_t curr_slave_lock;
 	u8	 send_peer_notif;
 	s8	 setup_by_slave;
-	s8       igmp_retrans;
+	u8       igmp_retrans;
 #ifdef CONFIG_PROC_FS
 	struct   proc_dir_entry *proc_entry;
 	char     proc_file_name[IFNAMSIZ];
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 9 lines · On 29/05/13 17:02, [email protected] wrote:

From: Nikolay Aleksandrov <[email protected]>

According to the bonding documentation and to the error messages the resend_igmp should be between 0 and 255, but since the type of the variable that counts is wrong, this is not the case.
We have igmp_retrans = resend_igmp when the work is started.

---

Self-NACK, there's another related bug and this is not a full fix. Dave please don't apply this patch, I'll resend a proper fix.

Nik