Skip to contentSkip to conversation

opengl: correct detection of virtual packages having no dependencies

PATCH New Will Wagner 3 participants 3 messages May 30, 2013

lore
Share & tools
lore

Will Wagner

author
#0 lore raw

PATCH 1/1 opengl: correct detection of virtual packages having no dependencies

I believe the original intent was to make it that the configure step for the opengl virtual packages fails if there is not at least one dependency. This patch fixes the logic so that it actually fails if dependency list is empty

Signed-off-by Will Wagner <[email protected]>
---
  package/opengl/libegl/libegl.mk       |    2 +-
  package/opengl/libgles/libgles.mk     |    2 +-
  package/opengl/libopenvg/libopenvg.mk |    2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/package/opengl/libegl/libegl.mk
index c495496..8ff24e8 100644

package/opengl/libegl/libegl.mk +1 -1
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
  LIBEGL_DEPENDENCIES += rpi-userland
  endif
 
-ifeq ($(LIBEGL_DEPENDENCIES),y)
+ifeq ($(LIBEGL_DEPENDENCIES),)
  define LIBEGL_CONFIGURE_CMDS
  	echo "No libEGL implementation selected. Configuration error."
  	exit 1
(quoted diff) +0 -0

b/package/opengl/libgles/libgles.mk
index f0d0eec..675d11f 100644

package/opengl/libgles/libgles.mk +1 -1
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
  LIBGLES_DEPENDENCIES += rpi-userland
  endif
 
-ifeq ($(LIBGLES_DEPENDENCIES),y)
+ifeq ($(LIBGLES_DEPENDENCIES),)
  define LIBGLES_CONFIGURE_CMDS
  	echo "No libGLES implementation selected. Configuration error."
  	exit 1
(quoted diff) +0 -0

b/package/opengl/libopenvg/libopenvg.mk
index 573fa78..746b52c 100644

package/opengl/libopenvg/libopenvg.mk +1 -1
@@ -10,7 +10,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
  LIBOPENVG_DEPENDENCIES += rpi-userland
  endif
 
-ifeq ($(LIBOPENVG_DEPENDENCIES),y)
+ifeq ($(LIBOPENVG_DEPENDENCIES),)
  define LIBOPENVG_CONFIGURE_CMDS
  	echo "No libOpenVG implementation selected. Configuration error."
  	exit 1

--
1.7.2.5

#1 lore raw

PATCH 1/1 opengl: correct detection of virtual packages having no dependencies

Dear Will Wagner,

Quoted 6 lines · Will Wagner

I believe the original intent was to make it that the configure step for the opengl virtual packages fails if there is not at least one dependency. This patch fixes the logic so that it actually fails if dependency list is empty

Signed-off-by Will Wagner <[email protected]>

Indeed. Thanks for spotting the mistake!

Reviewed-by Thomas Petazzoni <[email protected]>

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 opengl: correct detection of virtual packages having no dependencies

In reply to Will Wagner
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Will" == Will Wagner <[email protected]> writes:

Will> I believe the original intent was to make it that the configure step Will> for the opengl virtual packages fails if there is not at least one Will> dependency. This patch fixes the logic so that it actually fails if Will> dependency list is empty

Will> Signed-off-by: Will Wagner <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard