ocfs2: Add missing dlm_put() in dlm_begin_reco_handler
PATCH 1/1 ocfs2: Add missing dlm_put() in dlm_begin_reco_handler
Function dlm_begin_reco_handler returns without putting dlm when dlm recovery state is DLM_RECO_STATE_FINALIZE.
Signed-off-by joyce <[email protected]>
--- fs/ocfs2/dlm/dlmrecovery.c | 1 + 1 file changed, 1 insertion(+)
fs/ocfs2/dlm/dlmrecovery.c +1 -0
@@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data, dlm->name, br->node_idx, br->dead_node, dlm->reco.dead_node, dlm->reco.new_master);spin_unlock (&dlm->spinlock); +dlm_put (dlm);return -EAGAIN ; }spin_unlock (&dlm->spinlock);
-- 1.7.9.7
PATCH 1/1 ocfs2: Add missing dlm_put() in dlm_begin_reco_handler
Hi Jiufei,
Quoted 4 lines · Xue jiufei
Function
dlm_begin_reco_handlerreturns without putting dlm when dlm recovery state isDLM_RECO_STATE_FINALIZE.Signed-off-by joyce <[email protected]>
The patch looks good to me, you can consider adding:
Reviewed-by Jie Liu <[email protected]>
Thanks,
-Jeff
Quoted 23 lines
--- fs/ocfs2/dlm/dlmrecovery.c | 1 + 1 file changed, 1 insertion(+)fs/ocfs2/dlm/dlmrecovery.c +1
-1@@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data, dlm->name, br->node_idx, br->dead_node, dlm->reco.dead_node, dlm->reco.new_master);spin_unlock (&dlm->spinlock); +dlm_put (dlm);return -EAGAIN ; }spin_unlock (&dlm->spinlock); -- 1.7.9.7_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel