Skip to contentSkip to conversation

ocfs2: Add missing dlm_put() in dlm_begin_reco_handler

PATCH New Xue jiufei 2 participants 2 messages May 31, 2013 OCFS2

lore
Share & tools
lore

Xue jiufei

author
#0 lore raw

PATCH 1/1 ocfs2: Add missing dlm_put() in dlm_begin_reco_handler

Function dlm_begin_reco_handler returns without putting dlm when dlm recovery state is DLM_RECO_STATE_FINALIZE.

---
 fs/ocfs2/dlm/dlmrecovery.c |    1 +
 1 file changed, 1 insertion(+)
fs/ocfs2/dlm/dlmrecovery.c +1 -0
index eeac97b..a145cf8 100644
@@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
 		     dlm->name, br->node_idx, br->dead_node,
 		     dlm->reco.dead_node, dlm->reco.new_master);
 		spin_unlock(&dlm->spinlock);
+		dlm_put(dlm);
 		return -EAGAIN;
 	}
 	spin_unlock(&dlm->spinlock);

-- 1.7.9.7

#1 lore raw

PATCH 1/1 ocfs2: Add missing dlm_put() in dlm_begin_reco_handler

Hi Jiufei,

Quoted 4 lines · Xue jiufei

Function dlm_begin_reco_handler returns without putting dlm when dlm recovery state is DLM_RECO_STATE_FINALIZE.

The patch looks good to me, you can consider adding:

Thanks,
-Jeff

Quoted 23 lines
---
 fs/ocfs2/dlm/dlmrecovery.c |    1 +
 1 file changed, 1 insertion(+)
fs/ocfs2/dlm/dlmrecovery.c +1 -1
index eeac97b..a145cf8 100644
@@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
 		     dlm->name, br->node_idx, br->dead_node,
 		     dlm->reco.dead_node, dlm->reco.new_master);
 		spin_unlock(&dlm->spinlock);
+		dlm_put(dlm);
 		return -EAGAIN;
 	}
 	spin_unlock(&dlm->spinlock);
-- 1.7.9.7

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel