ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

PATCH In review Chen Gang 3 participants 7 messages May 20, 2013 – Jun 3, 2013

Subsystems (4)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos Generic include/asm header files

lore

Share & tools

lore

Chen Gang

author

2013-05-20 08:54 UTC #0 lore raw

PATCH 1/1 ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:

arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm/plat-samsung/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/plat-samsung/Kconfig +1 -0

index f8ed2de..1d38541 100644
@@ -483,6 +483,7 @@ config S5P_PM
 
 config S5P_SLEEP
 	bool
+	select ARM_CPU_SUSPEND
 	help
 	  Internal config node to apply common S5P sleep management code.
 	  Can be selected by S5P and newer SoCs with similar sleep procedure.

Signature · 1 line

1.7.7.6

Chen Gang

author

2013-05-27 10:05 UTC #1 lore raw

Hello Maintainers:

Please help check this patch whether OK, when you have time.

Thanks.

Quoted 26 lines · Chen Gang

When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/plat-samsung/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-samsung/Kconfig +1 -0
index f8ed2de..1d38541 100644
@@ -483,6 +483,7 @@ config S5P_PM
 
 config S5P_SLEEP
 	bool
+	select ARM_CPU_SUSPEND
 	help
 	  Internal config node to apply common S5P sleep management code.
 	  Can be selected by S5P and newer SoCs with similar sleep procedure.

Signature · 3 lines

Chen Gang

Asianux Corporation

Kukjin Kim

2013-05-27 10:12 UTC #2 lore raw

Quoted 3 lines · Chen Gang

Hello Maintainers:

Hi,

Quoted 22 lines

Please help check this patch whether OK, when you have time.
Thanks.
Quoted 6 lines · Chen Gang
When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to
`cpu_resume'
arch/arm/plat-
Quoted 8 lines
Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/plat-samsung/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat- renamed from arch/arm/plat-samsung/Kconfig +0 -0
samsung/Kconfig

Quoted 8 lines

arch/arm/plat-samsung/Kconfig config S5P_PM · line 486
Quoted 8 lines
index f8ed2de..1d38541 100644
arch/arm/plat-samsung/Kconfig +1 -0
@@ -483,6 +483,7 @@ config S5P_PM
 
 config S5P_SLEEP
 	bool
+	select ARM_CPU_SUSPEND

Probably,

+ select ARM_CPU_SUSPEND if PM ?

selecting the S5P_SLEEP depends on PM though...

- Kukjin

Chen Gang

author

2013-05-27 10:49 UTC #3 lore raw

Quoted 8 lines · Kukjin Kim

Quoted 3 lines
Quoted 3 lines
config S5P_SLEEP
Quoted 2 lines
arch/arm/plat-samsung/Kconfig config S5P_PM · line 486
Quoted 2 lines
arch/arm/plat-samsung/Kconfig +1 -0
 	bool
+	select ARM_CPU_SUSPEND
Probably,
(quoted diff) +1 -0
+	select ARM_CPU_SUSPEND if PM ?
selecting the S5P_SLEEP depends on PM though...

After reference another platform, they are really all "select ARM_CPU_SUSPEND if PM", we'd really better to follow by to let readers easy understanding.

I will send patch v2.

Thanks.

Signature · 3 lines

Chen Gang

Asianux Corporation

Chen Gang

author

2013-05-27 10:57 UTC #4 lore raw

PATCH v2 1/1 arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND

When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:

arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm/plat-samsung/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/plat-samsung/Kconfig +1 -0

index f8ed2de..b388d93 100644
@@ -483,6 +483,7 @@ config S5P_PM
 
 config S5P_SLEEP
 	bool
+	select ARM_CPU_SUSPEND if PM
 	help
 	  Internal config node to apply common S5P sleep management code.
 	  Can be selected by S5P and newer SoCs with similar sleep procedure.

Signature · 1 line

1.7.7.6

Sylwester Nawrocki

2013-06-01 12:27 UTC #5 lore raw

PATCH v2 1/1 arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND

Quoted 18 lines · Chen Gang

When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
Signed-off-by Chen Gang<[email protected]>
---
  arch/arm/plat-samsung/Kconfig |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-samsung/Kconfig +0 -0
index f8ed2de..b388d93 100644

arch/arm/plat-samsung/Kconfig config S5P_PM · line 489

Quoted 7 lines

arch/arm/plat-samsung/Kconfig +1 -0

@@ -483,6 +483,7 @@ config S5P_PM
 
  config S5P_SLEEP
  	bool
+	select ARM_CPU_SUSPEND if PM
  	help
  	  Internal config node to apply common S5P sleep management code.
  	  Can be selected by S5P and newer SoCs with similar sleep procedure.

We have discussed this about two months ago [1] and the conclusion was to also
remove "select ARM_CPU_SUSPEND if PM" line from arch/arm/mach-exynos/Kconfig.
It is still unresolved then, I'm getting similar linker errors with s3c2410_defconfig...

LD init/built-in.o
arch/arm/mach-s3c24xx/built-in.o: In function `s3c_cpu_resume':
/home/snawrocki/linux/media_tree/arch/arm/mach-s3c24xx/sleep.S:83:
undefined reference to cpu_resume' arch/arm/plat-samsung/built-in.o: In function s3c_pm_enter':
/home/snawrocki/linux/media_tree/arch/arm/plat-samsung/pm.c:305:
undefined reference to `cpu_suspend'
make: *** [vmlinux] Error 1

[1] https://patchwork.kernel.org/patch/2406351

Thanks,
Sylwester

Chen Gang

author

2013-06-03 10:19 UTC #6 lore raw

PATCH v2 1/1 arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND

Quoted 22 lines · Sylwester Nawrocki

Quoted 21 lines · Chen Gang
When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to
`cpu_resume'
Signed-off-by Chen Gang<[email protected]>
---
  arch/arm/plat-samsung/Kconfig |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-samsung/Kconfig +0 -0
index f8ed2de..b388d93 100644
@@ -483,6 +483,7 @@ config S5P_PM
 

Quoted 15 lines

Quoted 7 lines
arch/arm/plat-samsung/Kconfig +1 -0
  config S5P_SLEEP
      bool
+    select ARM_CPU_SUSPEND if PM
      help
        Internal config node to apply common S5P sleep management code.
        Can be selected by S5P and newer SoCs with similar sleep
procedure.
We have discussed this about two months ago [1] and the conclusion was to also
remove "select ARM_CPU_SUSPEND if PM" line from arch/arm/mach-exynos/Kconfig.
It is still unresolved then, I'm getting similar linker errors with s3c2410_defconfig...

I do not think they are the same.

This patch says: S5P_SLEEP need ARM_CPU_SUSPEND, or can not pass compiling (S5P_SLEEP need some functions in ARM_CPU_SUSPEND).

Your patch means PLAT_SAMSUNG need ARM_CPU_SUSPEND, but in fact, PLAT_SAMSUNG may not need ARM_CPU_SUSPEND.

Quoted 10 lines

LD init/built-in.o
arch/arm/mach-s3c24xx/built-in.o: In function `s3c_cpu_resume':
/home/snawrocki/linux/media_tree/arch/arm/mach-s3c24xx/sleep.S:83:
undefined reference to cpu_resume' arch/arm/plat-samsung/built-in.o: In function s3c_pm_enter':
/home/snawrocki/linux/media_tree/arch/arm/plat-samsung/pm.c:305:
undefined reference to `cpu_suspend'
make: *** [vmlinux] Error 1

I guess, this error output means S5P_SLEEP and PM need ARM_CPU_SUSPEND (which has the implementation of 'cpu_resume' and 'cpu_suspend')

Thanks.

Signature · 3 lines

Chen Gang

Asianux Corporation