I2C: Exynos5: Reduce the Delay in s3c24x0 i2c driver
Subsystems (2)
PATCH 1/1 I2C: Exynos5: Reduce the Delay in s3c24x0 i2c driver
From: Alim Akhtar <[email protected]>
When no device is conneted on the i2c channel then i2c_probe command was taking too much of time (around 3 mins) to come out from the loop. Now reduced the delay loop to milisec value.
This is tested on smdk5250 only. As i dont have s3c24x0 boards, so i cannt test on these baord.
--- drivers/i2c/s3c24x0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/s3c24x0_i2c.c +2 -2
@@ -111,7 +111,7 @@ static int WaitForXfer(struct s3c24x0_i2c *i2c) {int i; - i =I2C_TIMEOUT *10000 ; + i =I2C_TIMEOUT *10 ;while (!(readl (&i2c->iiccon) &I2CCON_IRPND ) && (i >0 )) {udelay (100 ); i--;
@@ -292,7 +292,7 @@ static int i2c_transfer(struct s3c24x0_i2c *i2c, }/* Check I2C bus idle */ - i =I2C_TIMEOUT *1000 ; + i =I2C_TIMEOUT *10 ;while ((readl (&i2c->iicstat) &I2CSTAT_BSY ) && (i >0 )) {udelay (1000 ); i--;
Signature · 1 line
1.8.0
PATCH 1/1 I2C: Exynos5: Reduce the Delay in s3c24x0 i2c driver
Dear Alim Akhtar,
Quoted 3 lines · Akshay Saraswat
From: Alim Akhtar <[email protected]>
When no device is conneted on the i2c channel then
i2c_probecommand
conneted -> connected
Quoted 4 lines
was taking too much of time (around 3 mins) to come out from the loop. Now reduced the delay loop to milisec value.
This is tested on smdk5250 only. As i dont have s3c24x0 boards, so i cannt test on these baord.
dont -> don't, cannt -> can't?, baord -> board
And these two line(This is tested... board) should move under "---" line. I think it is not a commit msg.
Quoted 8 lines
Signed-off-by Alim Akhtar <[email protected]>Signed-off-by Doug Anderson <[email protected]>Signed-off-by Akshay Saraswat <[email protected]>--- drivers/i2c/s3c24x0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch looks good.
Please fix typo.
Thanks,
Minkyu Kang.