Skip to contentSkip to conversation

arm, arm335x: add watchdog support

U-Boot Heiko Schocher 3 participants 9 messages Jun 4, 2013 – Jun 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Cc Albert Aribaud <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115 +++++++++++++++++++++++++++++++++
 3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)
 create mode 100644 drivers/watchdog/omap_wdt.c
arch/arm/include/asm/arch-am33xx/cpu.h +20 -0
index 3d3a7c8..fb44654 100644
@@ -61,6 +61,26 @@
 #define PRM_RSTCTRL_RESET		0x01
 #define PRM_RSTST_WARM_RESET_MASK	0x232
 
+/*
+ * Watchdog:
+ * Using the prescaler, the OMAP watchdog could go for many
+ * months before firing.  These limits work without scaling,
+ * with the 60 second default assumed by most tools and docs.
+ */
+#define TIMER_MARGIN_MAX	(24 * 60 * 60)	/* 1 day */
+#define TIMER_MARGIN_DEFAULT	60	/* 60 secs */
+#define TIMER_MARGIN_MIN	1
+
+#define PTV			0	/* prescale */
+#define GET_WLDR_VAL(secs)	(0xffffffff - ((secs) * (32768/(1<<PTV))) + 1)
+#define WDT_WWPS_PEND_WCLR	BIT(0)
+#define WDT_WWPS_PEND_WLDR	BIT(2)
+#define WDT_WWPS_PEND_WTGR	BIT(3)
+#define WDT_WWPS_PEND_WSPR	BIT(4)
+
+#define WDT_WCLR_PRE		BIT(5)
+#define WDT_WCLR_PTV_OFF	2
+
 #ifndef __KERNEL_STRICT_NAMES
 #ifndef __ASSEMBLY__
 struct gpmc_cs {
drivers/watchdog/Makefile +1 -0
index d57578d..46adc42 100644
@@ -34,6 +34,7 @@ COBJS-$(CONFIG_TNETV107X_WATCHDOG) += tnetv107x_wdt.o
 COBJS-$(CONFIG_S5P)               += s5p_wdt.o
 COBJS-$(CONFIG_XILINX_TB_WATCHDOG) += xilinx_tb_wdt.o
 COBJS-$(CONFIG_BFIN_WATCHDOG)  += bfin_wdt.o
+COBJS-$(CONFIG_OMAP_WATCHDOG) += omap_wdt.o
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
drivers/watchdog/omap_wdt.c new file +115 -0

115 lines not on this page · raw message

Signature · 1 line
1.7.11.7
Reviewed-by
#1 lore raw
Quoted 5 lines · Heiko Schocher

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Cc Albert Aribaud <[email protected]>
Cc Tom Rini <[email protected]>

But this is also unused code right now. Enabling on the am335x_evm config is a good place-holder and easy for you to test I assume platform until you can also post the custom board you're working on.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130604/b0d1f811/attachment.pgp>
#2 lore raw

Hello Tom,

Am 04.06.2013 23:24, schrieb Tom Rini:

Quoted 8 lines · Heiko Schocher
Quoted 6 lines

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Cc Albert Aribaud <[email protected]>
Cc Tom Rini <[email protected]>
Quoted 5 lines

But this is also unused code right now. Enabling on the am335x_evm config is a good place-holder and easy for you to test I assume platform until you can also post the custom board you're working on.

I repost this patch with the board support, ok?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 11 lines · Heiko Schocher

Hello Tom,

Am 04.06.2013 23:24, schrieb Tom Rini:

Quoted 8 lines · Heiko Schocher
Quoted 6 lines

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

<[email protected]> Cc: Tom Rini <[email protected]>

Quoted 8 lines
Quoted 6 lines

But this is also unused code right now. Enabling on the am335x_evm config is a good place-holder and easy for you to test I assume platform until you can also post the custom board you're working on.

I repost this patch with the board support, ok?

OK, thanks.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRryzkAAoJENk4IS6UOR1WX0UP/jxsDh51DNxGlUEtqg03LxhR FV4bN1yMrcFogeBacW3YIDhq0kgZ+afvxSo3yigExZt0FnWpnAUN1AD4W3fwtB4D UyNWfmI0KIGyY0/N83hNX1ABtmdILr6eDZEf9xoNfNGh4IQZDGXgaAcgincwZ10d HioI1cYOHRvMG/VZ4LFj7b5QrhSax2fm5dm51bq0ioII1qdfE4vV+bNgX271mPdB hfV2XCVsB1wm7MuC1v8NdRDXUly5g2ARIcHq9smdVOiwHl94nS8KOiaM6QAcwB0R wN/x/h6hYcDVXIrxLvVn+ZRYk96RzurywylNws4xQco7WHKISKTrsWXXmj+ecodX DWVC1Dk+Ch/V/sJyf+1+p7ctg/PfA/P9VYqdjwrhoTrVTj+4Ds34qOwqW+cx0I+J Eb5SbeTtjBzMoMWl9f11eJiQ7HqhR6qSijJ2HQlJgVOqMeBbpv1PKAdzRoGWVz2a QsXUcALr1IkHzn4lKJ2qFDf+erZhTCyWOpeL4BTsqp3hSOJs1BxkRtanpZJU8tzj 9shXkwyCyzXMIxT98WmNB3+p5HaCMoQFOvebVSxTTx9jziuz8+Y9b9+xe7AAcZoU yAA1a+DmZufkc2sygrC2XENWkEukLro1ir1ivi2sInpA6+i2iWv+YmBgdUpXZIjC Q6zC5K0jO13kA2wmrY8P
=e8Ph
-----END PGP SIGNATURE-----

#4 lore raw
In reply to Heiko Schocher

Hi

Quoted 10 lines · Heiko Schocher

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Cc Albert Aribaud <[email protected]>
Cc Tom Rini <[email protected]>
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115

+++++++++++++++++++++++++++++++++

Review

Quoted 4 lines

3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)

 create mode 100644 drivers/watchdog/omap_wdt.c
(quoted diff) +0 -0

b/arch/arm/include/asm/arch-am33xx/cpu.h

Quoted 9 lines

index 3d3a7c8..fb44654 100644

arch/arm/include/asm/arch-am33xx/cpu.h +2 -0
@@ -61,6 +61,26 @@
 #define PRM_RSTCTRL_RESET              0x01
 #define PRM_RSTST_WARM_RESET_MASK      0x232
 
+/*
+ * Watchdog:

arch/arm/include/asm/arch-am33xx/cpu.h line 75

Quoted 10 lines
arch/arm/include/asm/arch-am33xx/cpu.h +10 -0
+ * Using the prescaler, the OMAP watchdog could go for many
+ * months before firing.  These limits work without scaling,
+ * with the 60 second default assumed by most tools and docs.
+ */
+#define TIMER_MARGIN_MAX       (24 * 60 * 60)  /* 1 day */
+#define TIMER_MARGIN_DEFAULT   60      /* 60 secs */
+#define TIMER_MARGIN_MIN       1
+
+#define PTV                    0       /* prescale */
+#define GET_WLDR_VAL(secs)     (0xffffffff - ((secs) * (32768/(1<<PTV)))

+ 1)

Quoted 29 lines
arch/arm/include/asm/arch-am33xx/cpu.h +8 -0
+#define WDT_WWPS_PEND_WCLR     BIT(0)
+#define WDT_WWPS_PEND_WLDR     BIT(2)
+#define WDT_WWPS_PEND_WTGR     BIT(3)
+#define WDT_WWPS_PEND_WSPR     BIT(4)
+
+#define WDT_WCLR_PRE           BIT(5)
+#define WDT_WCLR_PTV_OFF       2
+
 #ifndef __KERNEL_STRICT_NAMES
 #ifndef __ASSEMBLY__
 struct gpmc_cs {
drivers/watchdog/Makefile +1 -0
index d57578d..46adc42 100644
@@ -34,6 +34,7 @@ COBJS-$(CONFIG_TNETV107X_WATCHDOG) += tnetv107x_wdt.o
 COBJS-$(CONFIG_S5P)               += s5p_wdt.o
 COBJS-$(CONFIG_XILINX_TB_WATCHDOG) += xilinx_tb_wdt.o
 COBJS-$(CONFIG_BFIN_WATCHDOG)  += bfin_wdt.o
+COBJS-$(CONFIG_OMAP_WATCHDOG) += omap_wdt.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
drivers/watchdog/omap_wdt.c new file +0 -0
new file mode 100644
index 0000000..dc4df98

drivers/watchdog/omap_wdt.c line 9

Quoted 9 lines
drivers/watchdog/omap_wdt.c new file +9 -0
@@ -0,0 +1,115 @@
+/*
+ * omap_wdt.c
+ *
+ * (C) Copyright 2013
+ * Heiko Schocher, DENX Software Engineering, hs at denx.de.
+ *
+ * Based on:
+ *
+ * Watchdog driver for the TI OMAP 16xx & 24xx/34xx 32KHz (non-secure)

watchdog

drivers/watchdog/omap_wdt.c

Quoted 13 lines
drivers/watchdog/omap_wdt.c new file +13 -0
+ *
+ * Author: MontaVista Software, Inc.
+ *      <[email protected]> or <[email protected]>
+ *
+ * 2003 (c) MontaVista Software, Inc. This file is licensed under the
+ * terms of the GNU General Public License version 2. This program is
+ * licensed "as is" without any warranty of any kind, whether express
+ * or implied.
+ *
+ * History:
+ *
+ * 20030527: George G. Davis <[email protected]>
+ *     Initially based on

linux-2.4.19-rmk7-pxa1/drivers/char/sa1100_wdt.c

drivers/watchdog/omap_wdt.c

Quoted 9 lines
drivers/watchdog/omap_wdt.c new file +9 -0
+ *     (c) Copyright 2000 Oleg Drokin <[email protected]>
+ *     Based on SoftDog driver by Alan Cox <[email protected]>
+ *
+ * Copyright (c) 2004 Texas Instruments.
+ *     1. Modified to support OMAP1610 32-KHz watchdog timer
+ *     2. Ported to 2.6 kernel
+ *
+ * Copyright (c) 2005 David Brownell
+ *     Use the driver model and standard identifiers; handle bigger

timeouts.

Quoted 20 lines
drivers/watchdog/omap_wdt.c new file +20 -0
+ */
+
+#include <common.h>
+#include <watchdog.h>
+#include <asm/arch/hardware.h>
+#include <asm/io.h>
+#include <asm/processor.h>
+#include <asm/arch/cpu.h>
+
+/* Hardware timeout in seconds */
+#define WDT_HW_TIMEOUT 60
+
+static unsigned int wdt_trgr_pattern = 0x1234;
+
+void hw_watchdog_reset(void)
+{
+       struct wd_timer *wdt = (struct wd_timer *)WDT_BASE;
+
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps)) & WDT_WWPS_PEND_WTGR)

drivers/watchdog/omap_wdt.c line 61

Quoted 10 lines
drivers/watchdog/omap_wdt.c new file +10 -0
+               ;
+
+       wdt_trgr_pattern = ~wdt_trgr_pattern;
+       writel(wdt_trgr_pattern, &wdt->wdtwtgr);
+
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
+               ;
+}
+

I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to avoid reset when it is not needed

Michael

Quoted 61 lines
drivers/watchdog/omap_wdt.c new file +54 -1
+static int omap_wdt_set_timeout(unsigned int timeout)
+{
+       struct wd_timer *wdt = (struct wd_timer *)WDT_BASE;
+       u32 pre_margin = GET_WLDR_VAL(timeout);
+
+       /* just count up at 32 KHz */
+       while (readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WLDR)
+               ;
+
+       writel(pre_margin, &wdt->wdtwldr);
+       while (readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WLDR)
+               ;
+
+       return 0;
+}
+
+void hw_watchdog_init(void)
+{
+       struct wd_timer *wdt = (struct wd_timer *)WDT_BASE;
+
+       /* initialize prescaler */
+       while (readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WCLR)
+               ;
+
+       writel(WDT_WCLR_PRE | (PTV << WDT_WCLR_PTV_OFF), &wdt->wdtwclr);
+       while (readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WCLR)
+               ;
+
+       omap_wdt_set_timeout(WDT_HW_TIMEOUT);
+
+       /* Sequence to enable the watchdog */
+       writel(0xBBBB, &wdt->wdtwspr);
+       while ((readl(&wdt->wdtwwps)) & WDT_WWPS_PEND_WSPR)
+               ;
+
+       writel(0x4444, &wdt->wdtwspr);
+       while ((readl(&wdt->wdtwwps)) & WDT_WWPS_PEND_WSPR)
+               ;
+}
+
+void hw_watchdog_disable(void)
+{
+       struct wd_timer *wdt = (struct wd_timer *)WDT_BASE;
+
+       /*
+        * Disable watchdog
+        */
+       writel(0xAAAA, &wdt->wdtwspr);
+       while (readl(&wdt->wdtwwps) != 0x0)
+               ;
+       writel(0x5555, &wdt->wdtwspr);
+       while (readl(&wdt->wdtwwps) != 0x0)
+               ;
+}
--

1.7.11.7

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#5 lore raw

Hello Michael,

Am 05.06.2013 15:31, schrieb Michael Trimarchi:

Quoted 15 lines

Hi

Quoted 12 lines · On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:[email protected]>>…

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Signed-off-by Heiko Schocher <hs at denx.de <mailto:[email protected]>>
Cc Albert Aribaud <albert.u.boot at aribaud.net <mailto:[email protected]>>
Cc Tom Rini <trini at ti.com <mailto:[email protected]>>
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115 +++++++++++++++++++++++++++++++++
 3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)
 create mode 100644 drivers/watchdog/omap_wdt.c

[...]

Quoted 6 lines
Quoted 6 lines
drivers/watchdog/omap_wdt.c new file +0 -0
new file mode 100644
index 0000000..dc4df98
@@ -0,0 +1,115 @@

[...]

Quoted 8 lines

drivers/watchdog/omap_wdt.c line 61

Quoted 5 lines
drivers/watchdog/omap_wdt.c new file +5 -0
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
+               ;
+}
+

I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to avoid reset when it is not needed

I think, I do not understand you ... this is for all watchdogs the case ...

I currently pasted a 500 bytes long string, seeing no problems with the watchdog...

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#6 lore raw

Hi

Quoted 7 lines · Heiko Schocher

Hello Michael,

Am 05.06.2013 15:31, schrieb Michael Trimarchi:

Quoted 3 lines

Hi

On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:[email protected]>>

Quoted 5 lines · wrote:
Quoted 5 lines
Quoted 5 lines

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Signed-off-by Heiko Schocher <hs at denx.de <mailto:[email protected]>>
Cc Albert Aribaud <albert.u.boot at aribaud.net <mailto:

[email protected]>>

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Cc Tom Rini <trini at ti.com <mailto:[email protected]>>
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115

+++++++++++++++++++++++++++++++++

Quoted 10 lines
Quoted 2 lines
Quoted 2 lines

3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)

 create mode 100644 drivers/watchdog/omap_wdt.c

[...]

Quoted 6 lines
Quoted 6 lines
drivers/watchdog/omap_wdt.c new file +0 -0
new file mode 100644
index 0000000..dc4df98
@@ -0,0 +1,115 @@

[...]

Quoted 7 lines
Quoted 7 lines

drivers/watchdog/omap_wdt.c line 61

Quoted 5 lines
drivers/watchdog/omap_wdt.c new file +5 -0
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
+               ;
+}
+

I think that this patch has some problem because watchdog reset is in

getc code. Did you try to paste very long string when it is enabled? You need to

Quoted 8 lines
Quoted 1 line

avoid reset when it is not needed

I think, I do not understand you ... this is for all watchdogs the case ...

I currently pasted a 500 bytes long string, seeing no problems with the watchdog...

OK, maybe was a problem of my version. I have done the same driver 2 month ago and tested on omap3. I optimize the watchdog reset using time delaying. BTW if it works I have no other comments. Sorry for the noise

Michael

Quoted 5 lines

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

#7 lore raw

Hello Michael,

Am 05.06.2013 16:21, schrieb Michael Trimarchi:

Quoted 43 lines

Hi

Quoted 12 lines · On Jun 5, 2013 4:17 PM, "Heiko Schocher" <hs at denx.de <mailto:[email protected]>>…

Hello Michael,

Am 05.06.2013 15:31, schrieb Michael Trimarchi:

Quoted 8 lines

Hi

Quoted 5 lines · On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:[email protected]>…

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Signed-off-by Heiko Schocher <hs at denx.de <mailto:[email protected]> <mailto:hs at denx.de <mailto:[email protected]>>>
Cc Albert Aribaud <albert.u.boot at aribaud.net <mailto:[email protected]> <mailto:[email protected]

<mailto:[email protected]>>>

Quoted 27 lines
Quoted 7 lines
Quoted 7 lines
Cc Tom Rini <trini at ti.com <mailto:[email protected]> <mailto:trini at ti.com <mailto:[email protected]>>>
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115 +++++++++++++++++++++++++++++++++
 3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)
 create mode 100644 drivers/watchdog/omap_wdt.c

[...]

Quoted 6 lines
Quoted 6 lines
drivers/watchdog/omap_wdt.c new file +0 -0
new file mode 100644
index 0000000..dc4df98
@@ -0,0 +1,115 @@

[...]

Quoted 8 lines

drivers/watchdog/omap_wdt.c line 61

Quoted 5 lines
drivers/watchdog/omap_wdt.c new file +5 -0
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
+               ;
+}
+

I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to avoid reset when it is not needed

I think, I do not understand you ... this is for all watchdogs the case ...

Quoted 6 lines
Quoted 3 lines

I currently pasted a 500 bytes long string, seeing no problems with the watchdog...

OK, maybe was a problem of my version. I have done the same driver 2 month ago and tested on omap3. I optimize the watchdog reset using time delaying. BTW if it works I have no other comments. Sorry for the noise

Maybe you have a chance to try this patch on your hw?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#8 lore raw

Hi

Quoted 7 lines · Heiko Schocher

Hello Michael,

Am 05.06.2013 16:21, schrieb Michael Trimarchi:

Quoted 3 lines

Hi

On Jun 5, 2013 4:17 PM, "Heiko Schocher" <hs at denx.de <mailto:[email protected]>>

Quoted 7 lines · wrote:
Quoted 7 lines
Quoted 7 lines

Hello Michael,

Am 05.06.2013 15:31, schrieb Michael Trimarchi:

Quoted 3 lines

Hi

On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:

Quoted 4 lines · [email protected]> <mailto:hs at denx.de <mailto:[email protected]>>> wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.

Signed-off-by Heiko Schocher <hs at denx.de <mailto:[email protected]>

<mailto:hs at denx.de <mailto:[email protected]>>>

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Cc Albert Aribaud <albert.u.boot at aribaud.net <mailto:

[email protected]> <mailto:[email protected]

Quoted 2 lines
Quoted 2 lines

<mailto:[email protected]>>>

Quoted 1 line
Quoted 1 line
Quoted 1 line
Cc Tom Rini <trini at ti.com <mailto:[email protected]> <mailto:

trini at ti.com <mailto:[email protected]>>>

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
---
 arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
 drivers/watchdog/Makefile              |   1 +
 drivers/watchdog/omap_wdt.c            | 115

+++++++++++++++++++++++++++++++++

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)

 create mode 100644 drivers/watchdog/omap_wdt.c

[...]

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/watchdog/omap_wdt.c

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

new file mode 100644
index 0000000..dc4df98

drivers/watchdog/omap_wdt.c new file +0 -0
@@ -0,0 +1,115 @@

[...]

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/watchdog/omap_wdt.c line 61

Quoted 5 lines
drivers/watchdog/omap_wdt.c new file +5 -0
+       /* wait for posted write to complete */
+       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
+               ;
+}
+

I think that this patch has some problem because watchdog reset is

in getc code. Did you try to paste very long string when it is enabled? You need to

Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
Quoted 1 line

avoid reset when it is not needed

I think, I do not understand you ... this is for all watchdogs the case ...

I currently pasted a 500 bytes long string, seeing no problems with the watchdog...

OK, maybe was a problem of my version. I have done the same driver 2

month ago and tested on omap3. I optimize the watchdog reset using time delaying.

Quoted 4 lines
Quoted 1 line

BTW if it works I have no other comments. Sorry for the noise

Maybe you have a chance to try this patch on your hw?

Yes I can or I can ask.

Michael

Quoted 5 lines

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany