simplefb: add support for a8b8g8r8 pixel format
Subsystems (2)
PATCH v2 1/1 simplefb: add support for a8b8g8r8 pixel format
A framebuffer of this format is set up by SHIELD's bootloader. This allows us to use it as a framebuffer console.
---
Changes from v1:
- Added description to motivate the change
- Added ack
Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 + drivers/video/simplefb.c | 1 + 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/video/simple-framebuffer.txt +1 -0
@@ -12,6 +12,7 @@ Required properties: - stride: The number of bytes in each line of the framebuffer. - format: The format of the framebuffer surface. Valid values are: - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b). + - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r). Example:
drivers/video/simplefb.c +1 -0
@@ -84,6 +84,7 @@ struct simplefb_format {static struct simplefb_format simplefb_formats[] = { {"r5g6b5" ,16 , {11 ,5 }, {5 ,6 }, {0 ,5 }, {0 ,0 } }, + {"a8b8g8r8" ,32 , {0 ,8 }, {8 ,8 }, {16 ,8 }, {31 ,8 } }, };struct simplefb_params {
Signature · 1 line
1.8.3
Quoted 31 lines · Alexandre Courbot
A framebuffer of this format is set up by SHIELD's bootloader. This allows us to use it as a framebuffer console.
Signed-off-by Alexandre Courbot <[email protected]>Acked-by Olof Johansson <[email protected]>---
Changes from v1:
- Added description to motivate the change
- Added ackDocumentation/devicetree/bindings/video/simple-framebuffer.txt | 1 + drivers/video/simplefb.c | 1 + 2 files changed, 2 insertions(+)Documentation/devicetree/bindings/video/simple-framebuffer.txt +1
-0@@ -12,6 +12,7 @@ Required properties: - stride: The number of bytes in each line of the framebuffer. - format: The format of the framebuffer surface. Valid values are: - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b). + - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r). Example:drivers/video/simplefb.c +0
-0
drivers/video/simplefb.c struct simplefb_format { · line 87
Quoted 4 lines
drivers/video/simplefb.c +1
-0@@ -84,6 +84,7 @@ struct simplefb_format {static struct simplefb_format simplefb_formats[] = { {"r5g6b5" ,16 , {11 ,5 }, {5 ,6 }, {0 ,5 }, {0 ,0 } }, + {"a8b8g8r8" ,32 , {0 ,8 }, {8 ,8 }, {16 ,8 }, {31 ,8 } },
Hi,
31? I assume in practice this doesn't influence anything, but I think it should have read 24.
Greetings,
Alexander
Quoted 13 lines
drivers/video/simplefb.c +0
-0};struct simplefb_params {Signature · 7 lines
1.8.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Quoted 7 lines · Alexander van Heukelum
drivers/video/simplefb.c struct simplefb_format { · line 87
Quoted 3 lines
static struct
simplefb_formatsimplefb_formats[] = {
{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },drivers/video/simplefb.c +1
-0+ { "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {31, 8} },Hi,
31? I assume in practice this doesn't influence anything, but I think it should have read 24.
Doh. Thanks for pointing it out.
Alex.