Skip to contentSkip to conversation

simplefb: add support for a8b8g8r8 pixel format

PATCH In review Alexandre Courbot 4 participants 4 messages Jun 7, 2013 – Jul 26, 2013

Subsystems (2)
Device tree bindings Framebuffer layer
lore
Share & tools
lore

Alexandre Courbot

author
#0 lore raw

PATCH v3 1/1 simplefb: add support for a8b8g8r8 pixel format

A framebuffer of this format is set up by SHIELD's bootloader.

Signed-off-by Alexandre Courbot <[email protected]>
Acked-by Olof Johansson <[email protected]>

---
Changes from v2:
- Fixed typo in format (Thanks Alexander van Heukelum!)

Changes from v1:
- Added description to motivate the change
- Added ack

 Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 +
 drivers/video/simplefb.c                                       | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/video/simple-framebuffer.txt +1 -0
index 3ea4605..70c26f3 100644
@@ -12,6 +12,7 @@ Required properties:
 - stride: The number of bytes in each line of the framebuffer.
 - format: The format of the framebuffer surface. Valid values are:
   - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b).
+  - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r).
 
 Example:
drivers/video/simplefb.c +1 -0
index e2e9e3e..f015482 100644
@@ -84,6 +84,7 @@ struct simplefb_format {
 
 static struct simplefb_format simplefb_formats[] = {
 	{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
+	{ "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {24, 8} },
 };
 
 struct simplefb_params {
Signature · 1 line
1.8.3
#3 lore raw
In reply to Alexandre Courbot
Quoted 33 lines · Alexandre Courbot

A framebuffer of this format is set up by SHIELD's bootloader.

Signed-off-by Alexandre Courbot <[email protected]>
Acked-by Olof Johansson <[email protected]>

---
Changes from v2:
- Fixed typo in format (Thanks Alexander van Heukelum!)

Changes from v1:
- Added description to motivate the change
- Added ack

 Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 +
 drivers/video/simplefb.c                                       | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/video/simple-framebuffer.txt +1 -0
index 3ea4605..70c26f3 100644
@@ -12,6 +12,7 @@ Required properties:
 - stride: The number of bytes in each line of the framebuffer.
 - format: The format of the framebuffer surface. Valid values are:
   - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b).
+  - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r).
 
 Example:
drivers/video/simplefb.c +0 -0
index e2e9e3e..f015482 100644

drivers/video/simplefb.c struct simplefb_format { · line 90

Quoted 7 lines
drivers/video/simplefb.c +1 -0
@@ -84,6 +84,7 @@ struct simplefb_format {
 
 static struct simplefb_format simplefb_formats[] = {
 	{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
+	{ "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {24, 8} },
 };
 
 struct simplefb_params {

Thanks, I've applied this into my 3.12/fbdev branch.

Tomi