arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Subsystems (3)
PATCH 1/1 arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
atomic_set_mask() and atomic_clear_mask() are the pairs, so the related parameters' type need match with each other.
The type of 'addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask().
For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.
At least, better to fix 3rd (conflict using 'int' and 'long').
using 'long':
./h8300/include/asm/atomic.h:129:static __inline__ void atomic_set_mask(unsigned long mask, unsigned long *v) ./h8300/include/asm/atomic.h:118:static __inline__ void atomic_clear_mask(unsigned long mask, unsigned long *v) ./mn10300/include/asm/atomic.h:211:static inline void atomic_set_mask(unsigned long mask, unsigned long *addr) ./mn10300/include/asm/atomic.h:177:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./m68k/include/asm/atomic.h:192:static inline void atomic_set_mask(unsigned long mask, unsigned long *v) ./m68k/include/asm/atomic.h:187:static inline void atomic_clear_mask(unsigned long mask, unsigned long *v) ./frv/include/asm/bitops.h:113:#define atomic_set_mask(mask, v) atomic_test_and_OR_mask((mask), (v))
./frv/include/asm/bitops.h:112:#define atomic_clear_mask(mask, v) atomic_test_and_ANDNOT_mask((mask), (v))
./x86/include/asm/atomic.h:260:#define atomic_set_mask(mask, addr) \
./x86/include/asm/atomic.h:256:#define atomic_clear_mask(mask, addr) \
also using 'long': (but only atomic_clear_mask, no atomic_set_mask)
./arm64/include/asm/atomic.h:129:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arc/include/asm/atomic.h:89:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arc/include/asm/atomic.h:182:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arm/include/asm/atomic.h:137:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arm/include/asm/atomic.h:200:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
using 'int':
./metag/include/asm/atomic_lock1.h:100:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lnkget.h:127:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lock1.h:90:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lnkget.h:110:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-grb.h:104:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-irq.h:64:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-llsc.h:93:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-grb.h:84:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-irq.h:55:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-llsc.h:79:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./xtensa/include/asm/atomic.h:357:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./xtensa/include/asm/atomic.h:322:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
also using 'int', (better to notice 'signed' and 'unsigned'):
./blackfin/include/asm/atomic.h:31:#define atomic_set_mask(m, v) __raw_atomic_set_asm(&(v)->counter, m)
./blackfin/include/asm/atomic.h:30:#define atomic_clear_mask(m, v) __raw_atomic_clear_asm(&(v)->counter, m)
conflict to use 'int' and 'long':
./m32r/include/asm/atomic.h:289:static __inline__ void atomic_set_mask(unsigned long mask, atomic_t *addr) ./m32r/include/asm/atomic.h:267:static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) ./s390/include/asm/atomic.h:79:static inline void atomic_set_mask(unsigned long mask, atomic_t *v) ./s390/include/asm/atomic.h:74:static inline void atomic_clear_mask(unsigned long mask, atomic_t *v) (in fact, 'generic' is also conflict to use 'int' and 'long')
--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 4 ++-- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)
arch/blackfin/include/asm/atomic.h +2 -2
@@ -27,8 +27,8 @@ asmlinkage int __raw_atomic_test_asm(const volatile int *ptr, int value);#define atomic_add_return (i, v) __raw_atomic_update_asm(&(v)->counter, i)#define atomic_sub_return (i, v) __raw_atomic_update_asm(&(v)->counter, -(i)) -#define atomic_clear_mask (m, v) __raw_atomic_clear_asm(&(v)->counter, m) -#define atomic_set_mask (m, v) __raw_atomic_set_asm(&(v)->counter, m) +#define atomic_clear_mask (m, v) __raw_atomic_clear_asm(&(v)->counter, (int)(m)) +#define atomic_set_mask (m, v) __raw_atomic_set_asm(&(v)->counter, (int)(m))#endif
arch/m32r/include/asm/atomic.h +2 -2
@@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) } -static __inline__void atomic_clear_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_clear_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;
@@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)local_irq_restore (flags); } -static __inline__void atomic_set_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_set_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;
arch/s390/include/asm/atomic.h +2 -2
@@ -71,12 +71,12 @@ static inline int atomic_sub_return(int i, atomic_t *v)#define atomic_dec_return (_v) atomic_sub_return(1, _v)#define atomic_dec_and_test (_v) (atomic_sub_return(1, _v) == 0) -static inline void atomic_clear_mask (unsigned long mask,atomic_t *v) +static inline void atomic_clear_mask (unsigned int mask,atomic_t *v) {__CS_LOOP (v, ~mask,"nr" ); } -static inline void atomic_set_mask (unsigned long mask,atomic_t *v) +static inline void atomic_set_mask (unsigned int mask,atomic_t *v) {__CS_LOOP (v, mask,"or" ); }
include/asm-generic/atomic.h +1 -1
@@ -153,7 +153,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)* Atomically clears the bits set in @mask from @v */ #ifndef atomic_clear_mask -static inline void atomic_clear_mask (unsigned long mask,atomic_t *v) +static inline void atomic_clear_mask (unsigned int mask,atomic_t *v) {unsigned long flags;
Signature · 1 line
1.7.7.6
Haven't done a real review, but my eye fell on it:
arch/m32r/include/asm/atomic.h static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) · line 270
Quoted 13 lines · Chen Gang
arch/m32r/include/asm/atomic.h +1
-1@@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) } -static __inline__void atomic_clear_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_clear_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;
Shouldn't this become "unsigned int tmp" for consistency, too?
arch/m32r/include/asm/atomic.h static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) · line 292
Quoted 9 lines
arch/m32r/include/asm/atomic.h +1
-1@@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)local_irq_restore (flags); } -static __inline__void atomic_set_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_set_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;
Likewise.
There may be other places that need changes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 2 lines · Geert Uytterhoeven
Haven't done a real review, but my eye fell on it:
Thank you for your review, firstly.
Quoted 9 lines · Chen Gang
Quoted 8 lines
Quoted 8 lines
arch/m32r/include/asm/atomic.h +0
-0@@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) }
Quoted 7 lines
Quoted 5 lines
arch/m32r/include/asm/atomic.h static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) · line 270
Quoted 5 lines
arch/m32r/include/asm/atomic.h +1
-1-static __inline__void atomic_clear_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_clear_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;Shouldn't this become "unsigned int tmp" for consistency, too?
It seems better. (although I guess: for 'm32r', both 'long' and 'int' are 32-bit).
I will wait for 1 day at least, if no additional suggestions or completions, I will send patch v2.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
arch/m32r/include/asm/atomic.h +0
-0@@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)local_irq_restore (flags); }
Quoted 8 lines
Quoted 5 lines
arch/m32r/include/asm/atomic.h static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) · line 292
Quoted 5 lines
arch/m32r/include/asm/atomic.h +1
-1-static __inline__void atomic_set_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_set_mask (unsigned int mask,atomic_t *addr) {unsigned long flags;unsigned long tmp;Likewise.
There may be other places that need changes.
OK, I will check them.
Thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
s/geniric/generic/ in subject
Quoted 2 lines · Bjorn Helgaas
s/geniric/generic/ in subject
Could you provide more details information ?
Thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
Quoted 5 lines · Chen Gang
Quoted 2 lines · Bjorn Helgaas
s/geniric/generic/ in subject
Could you provide more details information ?
In your subject line, "geniric" is spelled incorrectly. The correct spelling is "generic."
Quoted 10 lines · Bjorn Helgaas
Quoted 5 lines · Chen Gang
Quoted 5 lines · Bjorn Helgaas
Quoted 2 lines
Quoted 2 lines
s/geniric/generic/ in subject
Could you provide more details information ?
In your subject line, "geniric" is spelled incorrectly. The correct spelling is "generic."
Thanks.
Signature · 3 lines
Chen Gang Asianux Corporation
PATCH v2 1/1 arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
In reply to Bjorn Helgaasatomic_set_mask() and atomic_clear_mask() are the pairs, so the related parameters' type need match with each other.
The type of 'addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask().
For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.
At least, better to fix 3rd (conflict using 'int' and 'long').
using 'long':
./h8300/include/asm/atomic.h:129:static __inline__ void atomic_set_mask(unsigned long mask, unsigned long *v) ./h8300/include/asm/atomic.h:118:static __inline__ void atomic_clear_mask(unsigned long mask, unsigned long *v) ./mn10300/include/asm/atomic.h:211:static inline void atomic_set_mask(unsigned long mask, unsigned long *addr) ./mn10300/include/asm/atomic.h:177:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./m68k/include/asm/atomic.h:192:static inline void atomic_set_mask(unsigned long mask, unsigned long *v) ./m68k/include/asm/atomic.h:187:static inline void atomic_clear_mask(unsigned long mask, unsigned long *v) ./frv/include/asm/bitops.h:113:#define atomic_set_mask(mask, v) atomic_test_and_OR_mask((mask), (v))
./frv/include/asm/bitops.h:112:#define atomic_clear_mask(mask, v) atomic_test_and_ANDNOT_mask((mask), (v))
./x86/include/asm/atomic.h:260:#define atomic_set_mask(mask, addr) \
./x86/include/asm/atomic.h:256:#define atomic_clear_mask(mask, addr) \
also using 'long': (but only atomic_clear_mask, no atomic_set_mask)
./arm64/include/asm/atomic.h:129:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arc/include/asm/atomic.h:89:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arc/include/asm/atomic.h:182:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arm/include/asm/atomic.h:137:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) ./arm/include/asm/atomic.h:200:static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
using 'int':
./metag/include/asm/atomic_lock1.h:100:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lnkget.h:127:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lock1.h:90:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./metag/include/asm/atomic_lnkget.h:110:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-grb.h:104:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-irq.h:64:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-llsc.h:93:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-grb.h:84:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-irq.h:55:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./sh/include/asm/atomic-llsc.h:79:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v) ./xtensa/include/asm/atomic.h:357:static inline void atomic_set_mask(unsigned int mask, atomic_t *v) ./xtensa/include/asm/atomic.h:322:static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
also using 'int', (better to notice 'signed' and 'unsigned'):
./blackfin/include/asm/atomic.h:31:#define atomic_set_mask(m, v) __raw_atomic_set_asm(&(v)->counter, m)
./blackfin/include/asm/atomic.h:30:#define atomic_clear_mask(m, v) __raw_atomic_clear_asm(&(v)->counter, m)
conflict to use 'int' and 'long':
./m32r/include/asm/atomic.h:289:static __inline__ void atomic_set_mask(unsigned long mask, atomic_t *addr) ./m32r/include/asm/atomic.h:267:static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) ./s390/include/asm/atomic.h:79:static inline void atomic_set_mask(unsigned long mask, atomic_t *v) ./s390/include/asm/atomic.h:74:static inline void atomic_clear_mask(unsigned long mask, atomic_t *v) (in fact, 'generic' is also conflict to use 'int' and 'long')
--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 8 ++++---- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)
arch/blackfin/include/asm/atomic.h +2 -2
@@ -27,8 +27,8 @@ asmlinkage int __raw_atomic_test_asm(const volatile int *ptr, int value);#define atomic_add_return (i, v) __raw_atomic_update_asm(&(v)->counter, i)#define atomic_sub_return (i, v) __raw_atomic_update_asm(&(v)->counter, -(i)) -#define atomic_clear_mask (m, v) __raw_atomic_clear_asm(&(v)->counter, m) -#define atomic_set_mask (m, v) __raw_atomic_set_asm(&(v)->counter, m) +#define atomic_clear_mask (m, v) __raw_atomic_clear_asm(&(v)->counter, (int)(m)) +#define atomic_set_mask (m, v) __raw_atomic_set_asm(&(v)->counter, (int)(m))#endif
arch/m32r/include/asm/atomic.h +4 -4
@@ -264,10 +264,10 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) } -static __inline__void atomic_clear_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_clear_mask (unsigned int mask,atomic_t *addr) {unsigned long flags; -unsigned long tmp; +unsigned int tmp;local_irq_save (flags); __asm__ __volatile__ (
@@ -286,10 +286,10 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr)local_irq_restore (flags); } -static __inline__void atomic_set_mask (unsigned long mask,atomic_t *addr) +static __inline__void atomic_set_mask (unsigned int mask,atomic_t *addr) {unsigned long flags; -unsigned long tmp; +unsigned int tmp;local_irq_save (flags); __asm__ __volatile__ (
arch/s390/include/asm/atomic.h +2 -2
@@ -71,12 +71,12 @@ static inline int atomic_sub_return(int i, atomic_t *v)#define atomic_dec_return (_v) atomic_sub_return(1, _v)#define atomic_dec_and_test (_v) (atomic_sub_return(1, _v) == 0) -static inline void atomic_clear_mask (unsigned long mask,atomic_t *v) +static inline void atomic_clear_mask (unsigned int mask,atomic_t *v) {__CS_LOOP (v, ~mask,"nr" ); } -static inline void atomic_set_mask (unsigned long mask,atomic_t *v) +static inline void atomic_set_mask (unsigned int mask,atomic_t *v) {__CS_LOOP (v, mask,"or" ); }
include/asm-generic/atomic.h +1 -1
@@ -153,7 +153,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)* Atomically clears the bits set in @mask from @v */ #ifndef atomic_clear_mask -static inline void atomic_clear_mask (unsigned long mask,atomic_t *v) +static inline void atomic_clear_mask (unsigned int mask,atomic_t *v) {unsigned long flags;
Signature · 1 line
1.7.7.6
Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Quoted 13 lines · Chen Gang
atomic_set_mask()andatomic_clear_mask()are the pairs, so the related parameters' type need match with each other.The type of '
addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and letatomic_set_mask()matchatomic_clear_mask().For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.At least, better to fix 3rd (conflict using 'int' and 'long').
Quoted 7 lines
Signed-off-by Chen Gang <[email protected]>--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 8 ++++---- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)
For the s390 part:
Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Quoted 21 lines · Heiko Carstens
Quoted 13 lines · Chen Gang
Quoted 13 lines
atomic_set_mask()andatomic_clear_mask()are the pairs, so the related parameters' type need match with each other.The type of '
addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and letatomic_set_mask()matchatomic_clear_mask().For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.At least, better to fix 3rd (conflict using 'int' and 'long').
Quoted 7 lines
Quoted 7 lines
Signed-off-by Chen Gang <[email protected]>--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 8 ++++---- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)
Quoted 4 lines
For the s390 part:
Acked-by Heiko Carstens <[email protected]>
Thank you very much !!
Signature · 3 lines
Chen Gang Asianux Corporation
Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Hello Maintainers:
Firstly thank the s390 maintainers again for their 'Acked-by' (in my memory, s390 is the most important business mainframe machine)
Could another related maintainers give a glance for it, when you have time.
Thanks.
Quoted 30 lines · Chen Gang
Quoted 21 lines · Heiko Carstens
Quoted 13 lines · Chen Gang
Quoted 13 lines
atomic_set_mask()andatomic_clear_mask()are the pairs, so the related parameters' type need match with each other.The type of '
addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and letatomic_set_mask()matchatomic_clear_mask().For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.At least, better to fix 3rd (conflict using 'int' and 'long').
Quoted 7 lines
Quoted 7 lines
Signed-off-by Chen Gang <[email protected]>--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 8 ++++---- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)Quoted 4 lines
For the s390 part:
Acked-by Heiko Carstens <[email protected]>Thank you very much !!
Signature · 3 lines
Chen Gang Asianux Corporation
Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long'
Hello Maintainers:
Please help check this patch whether OK, when you have time.
Thanks.
Quoted 42 lines · Chen Gang
Hello Maintainers:
Firstly thank the s390 maintainers again for their 'Acked-by' (in my memory, s390 is the most important business mainframe machine)
Could another related maintainers give a glance for it, when you have time.
Thanks.
Quoted 30 lines · Chen Gang
Quoted 21 lines · Heiko Carstens
Quoted 13 lines · Chen Gang
Quoted 13 lines
atomic_set_mask()andatomic_clear_mask()are the pairs, so the related parameters' type need match with each other.The type of '
addr->counter' is 'int', so use 'unsigned int' instead of 'unsigned long', and letatomic_set_mask()matchatomic_clear_mask().For arch sub-system, currently, have 3 types of definition for them:
1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'.At least, better to fix 3rd (conflict using 'int' and 'long').
Quoted 7 lines
Quoted 7 lines
Signed-off-by Chen Gang <[email protected]>--- arch/blackfin/include/asm/atomic.h | 4 ++-- arch/m32r/include/asm/atomic.h | 8 ++++---- arch/s390/include/asm/atomic.h | 4 ++-- include/asm-generic/atomic.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-)Quoted 4 lines
For the s390 part:
Acked-by Heiko Carstens <[email protected]>Thank you very much !!
Signature · 1 line
Chen Gang