video: mmp: fix memcpy wrong size for mmp_addr issue

PATCH Superseded Jett.Zhou 2 participants 2 messages Jun 9, 2013 Framebuffer layer

lore

Share & tools

lore

Jett.Zhou

author

2013-06-09 08:44 UTC #0 lore raw

PATCH 4/7 video: mmp: fix memcpy wrong size for mmp_addr issue

From: Jing Xiang <[email protected]>

Memcpy used wrong struct of mmp_addr, fix it.

Signed-off-by Jing Xiang <[email protected]>

Signed-off-by Jett.Zhou <[email protected]>

---
 drivers/video/mmp/hw/mmp_ctrl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/video/mmp/hw/mmp_ctrl.c +1 -1

index 8836053..92a5f44 100644
@@ -233,7 +233,7 @@ static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr)
 	struct lcd_regs *regs = path_regs(overlay->path);
 
 	/* FIXME: assert addr supported */
-	memcpy(&overlay->addr, addr, sizeof(struct mmp_win));
+	memcpy(&overlay->addr, addr, sizeof(struct mmp_addr));
 	writel(addr->phys[0], &regs->g_0);
 
 	return overlay->addr.phys[0];

Signature · 1 line

1.7.0.4

Sergei Shtylyov

2013-06-09 12:01 UTC #1 lore raw

PATCH 4/7 video: mmp: fix memcpy wrong size for mmp_addr issue

Hello.

Quoted 3 lines · Jett.Zhou

From: Jing Xiang <[email protected]>
Memcpy used wrong struct of mmp_addr, fix it.

From the patch it follows that 'struct mmp_addr' is the right one. :-)

Quoted 11 lines

Signed-off-by Jing Xiang <[email protected]>
Signed-off-by Jett.Zhou <[email protected]>
---
  drivers/video/mmp/hw/mmp_ctrl.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/mmp/hw/mmp_ctrl.c +0 -0
index 8836053..92a5f44 100644

drivers/video/mmp/hw/mmp_ctrl.c static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr) · line 239

Quoted 8 lines

drivers/video/mmp/hw/mmp_ctrl.c +1 -1

@@ -233,7 +233,7 @@ static int overlay_set_addr(struct mmp_overlay *overlay, struct mmp_addr *addr)
  	struct lcd_regs *regs = path_regs(overlay->path);
 
  	/* FIXME: assert addr supported */
-	memcpy(&overlay->addr, addr, sizeof(struct mmp_win));
+	memcpy(&overlay->addr, addr, sizeof(struct mmp_addr));
  	writel(addr->phys[0], &regs->g_0);
 
  	return overlay->addr.phys[0];

WBR, Sergei